Submission for review when archive is too big

Discussion forum for Extension Writers regarding Extension Development.
User avatar
MarkDHamill
Registered User
Posts: 3487
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Submission for review when archive is too big

Post by MarkDHamill » Mon Dec 05, 2016 12:47 am

As I documented here:

https://tracker.phpbb.com/browse/WEBSITE-1287?filter=-2

I can't upload my Smartfeed extension for review because the archive is too big. This is because it bundles in SimplePie, a third party library.

What's the appropriate way to get a review? I'm thinking I should just remove SimplePie from the archive and in the notes to the review team provide instructions on how to fetch the SimplePie library.
Get the latest versions of my Digests and Smartfeed mods and extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

User avatar
Sajaki
Registered User
Posts: 1350
Joined: Mon Mar 02, 2009 1:41 pm
Name: Andreas
Contact:

Re: Submission for review when archive is too big

Post by Sajaki » Mon Dec 05, 2016 10:36 am

just add it to your composer file ?

Code: Select all

"require": {
        "simplepie/simplepie": "1.3.1"
    }

User avatar
Paul
Infrastructure Team Leader
Infrastructure Team Leader
Posts: 24715
Joined: Sat Dec 04, 2004 3:44 pm
Location: The netherlands.
Name: Paul Sohier
Contact:

Re: Submission for review when archive is too big

Post by Paul » Mon Dec 05, 2016 10:53 am

You should provide a full working package. I poked the website team to get this solved.
Knock knock
Race condition
Who's there?

My BlogMy Photosmy phpBB Extensionscustom phpBB work & Development

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 16719
Joined: Thu Jan 06, 2005 1:30 pm
Location: Fishkill, NY
Name: David Colón
Contact:

Re: Submission for review when archive is too big

Post by DavidIQ » Mon Dec 05, 2016 1:18 pm

We're looking into it. Stand by.
Apply to become a Jr. Extension Validator
My extensions | In need of phpBB services? | Was I helpful today?
No unsolicited PMs unless you're planning on asking for paid help.

User avatar
MarkDHamill
Registered User
Posts: 3487
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: Submission for review when archive is too big

Post by MarkDHamill » Mon Dec 05, 2016 4:01 pm

Awesome! I've been dragging my feet on this for a few months hoping the issue would get noticed. Sounds like a simple tech fix, probably just increase PHP's max_execution_time.
Get the latest versions of my Digests and Smartfeed mods and extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

User avatar
MarkDHamill
Registered User
Posts: 3487
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: Submission for review when archive is too big

Post by MarkDHamill » Mon Dec 05, 2016 4:07 pm

Sajaki wrote:just add it to your composer file ?

Code: Select all

"require": {
        "simplepie/simplepie": "1.3.1"
    }
Already there:

Code: Select all

	"require": {
		"php": ">=5.3.3,<7.0",
		"composer/installers": "~1.0",
		"simplepie/simplepie": ">= 1.3.1,<1.4"
	},
Get the latest versions of my Digests and Smartfeed mods and extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

User avatar
david63
Jr. Extension Validator
Posts: 14724
Joined: Thu Dec 19, 2002 8:08 am
Location: Lancashire, UK
Name: David Wood
Contact:

Re: Submission for review when archive is too big

Post by david63 » Mon Dec 05, 2016 4:16 pm

Just to digress slightly - sorry Mark.

Are there any plans, if it is even possible, that where there are composer dependencies for an extension that the install routine can add the "vendor" files automatically?
David
Remember: You only know what you know and - you don't know what you don't know!
My CDB Contributions | How to install an extension
I will not be accepting translations for any of my extensions in Github - please post any translations in the appropriate topic.
No support requests via PM or email as they will be ignored

User avatar
Paul
Infrastructure Team Leader
Infrastructure Team Leader
Posts: 24715
Joined: Sat Dec 04, 2004 3:44 pm
Location: The netherlands.
Name: Paul Sohier
Contact:

Re: Submission for review when archive is too big

Post by Paul » Mon Dec 05, 2016 4:31 pm

david63 wrote:Just to digress slightly - sorry Mark.

Are there any plans, if it is even possible, that where there are composer dependencies for an extension that the install routine can add the "vendor" files automatically?
Yes. It is planned for 3.3.
Knock knock
Race condition
Who's there?

My BlogMy Photosmy phpBB Extensionscustom phpBB work & Development

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 16719
Joined: Thu Jan 06, 2005 1:30 pm
Location: Fishkill, NY
Name: David Colón
Contact:

Re: Submission for review when archive is too big

Post by DavidIQ » Mon Dec 05, 2016 4:39 pm

MarkDHamill wrote:Awesome! I've been dragging my feet on this for a few months hoping the issue would get noticed. Sounds like a simple tech fix, probably just increase PHP's max_execution_time.
This is actually a little more complicated due to our server infrastructure. Might take a few days so I'll ping you on the ticket once I/we have something in place for you.
Apply to become a Jr. Extension Validator
My extensions | In need of phpBB services? | Was I helpful today?
No unsolicited PMs unless you're planning on asking for paid help.

User avatar
VSE
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 4664
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman
Contact:

Re: Submission for review when archive is too big

Post by VSE » Mon Dec 05, 2016 9:00 pm

Sajaki wrote:just add it to your composer file ?

Code: Select all

"require": {
        "simplepie/simplepie": "1.3.1"
    }
This is not a solution. This means the only way to get it would be to run composer install from the command line (how many people on shared webhosts even have SSH?).

A released extension should, just as phpBB does, include already in its package any external libraries.
Dictated but not read.
Official phpBB Extensions My Extensions & MODs
Please do not PM me for support.

User avatar
3Di
Registered User
Posts: 12945
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: Submission for review when archive is too big

Post by 3Di » Mon Dec 05, 2016 9:25 pm

Yes, as discussed here with Mark

viewtopic.php?p=14505611#p14505611
MarkDHamill wrote:This is because it bundles in SimplePie
On a side note, I don't see in your extension you are checking for the SimplePie mandatory requisites, we already discussed this point about 4 months ago into the topic I above linked. I.e.: (cURL etc..).

That's your choice, preventing though the installation of your extension if those requisites aren't satisfied sounds to me like a good idea, in order to avoid maybe multiple support requests for nothing... nonetheless.
Want to compensate me for my interest? Donate
Please PM me only to request paid works. Thx.
Extensions, Scripts, MOD porting, Update/Upgrades
My development's activity º PhpStorm's proud user

User avatar
MarkDHamill
Registered User
Posts: 3487
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: Submission for review when archive is too big

Post by MarkDHamill » Mon Jan 09, 2017 1:08 am

The bug is still open so I'm guessing it's not addressed. Since I need to put out a new version of Smartfeed, I'll pull SimplePie out of the archive and make a note in the README.md. Yes, composer.json is updated to require SimplePie:

Code: Select all

	"require": {
		"php": ">=5.3.3,<=7.1",
		"composer/installers": "~1.0",
		"simplepie/simplepie": ">= 1.3.1,<1.4"
	},
The new version has been tested with Rhea and is backward compatible with 3.1.
Get the latest versions of my Digests and Smartfeed mods and extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

User avatar
Paul
Infrastructure Team Leader
Infrastructure Team Leader
Posts: 24715
Joined: Sat Dec 04, 2004 3:44 pm
Location: The netherlands.
Name: Paul Sohier
Contact:

Re: Submission for review when archive is too big

Post by Paul » Mon Jan 09, 2017 10:57 am

All dependencies need to be included in the package, we won't be able to approve extensions that have missing dependencies. I again poked the people to get their attention to this.
Knock knock
Race condition
Who's there?

My BlogMy Photosmy phpBB Extensionscustom phpBB work & Development

User avatar
MarkDHamill
Registered User
Posts: 3487
Joined: Fri Aug 02, 2002 12:36 am
Location: Florence, MA USA
Contact:

Re: Submission for review when archive is too big

Post by MarkDHamill » Mon Jan 09, 2017 6:16 pm

I'm happy to do so when they fix the server issue. Thank you for helping.
Get the latest versions of my Digests and Smartfeed mods and extensions.
Need phpBB services or a phpBB consultant? I offer most phpBB services.

User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 16719
Joined: Thu Jan 06, 2005 1:30 pm
Location: Fishkill, NY
Name: David Colón
Contact:

Re: Submission for review when archive is too big

Post by DavidIQ » Mon Jan 09, 2017 6:19 pm

Are you able to attach your complete extension package to this topic without error?
Apply to become a Jr. Extension Validator
My extensions | In need of phpBB services? | Was I helpful today?
No unsolicited PMs unless you're planning on asking for paid help.

Post Reply

Return to “Extension Writers Discussion”

Who is online

Users browsing this forum: No registered users and 5 guests