New Style Template Event in phpBB

Discussion forum for Extension Writers regarding Extension Development.
Post Reply
User avatar
Dark❶
Registered User
Posts: 47
Joined: Mon Jan 15, 2018 1:22 pm
Location: DarK V0id
Name: Dark❶ [dark1]

New Style Template Event in phpBB

Post by Dark❶ » Wed May 09, 2018 4:09 pm

Hi! Dear friends,

I would like to make some Pull request on GitHub for some New Style Template Event in phpBB.

Where should I be making the Pull request (Branch)?, example:
1. https://github.com/phpbb/phpbb/tree/3.2.x
2. https://github.com/phpbb/phpbb/tree/prep-release-3.2.3
3. https://github.com/phpbb/phpbb/tree/prep-release-3.2.2

And what else should I be doing other than making pull request in required template files?

I am making this for upcoming Extension.

BTW this did not help : General forum information/Events requests,
It did not explain where to make the PR.

Thanking you. :)
Best Regards. :D
Dark❶ [dark1]

User avatar
GanstaZ
Registered User
Posts: 376
Joined: Wed Oct 11, 2017 10:29 pm
Location: Zverse

Re: New Style Template Event in phpBB

Post by GanstaZ » Wed May 09, 2018 4:48 pm

Maybe this can help you Development Git
"When answer lies in the question,.. question becomes redundant!"

User avatar
Zoddo
Registered User
Posts: 158
Joined: Thu Aug 18, 2011 2:41 pm
Location: Le Mans, France
Name: Yohan
Contact:

Re: New Style Template Event in phpBB

Post by Zoddo » Wed May 09, 2018 7:16 pm

Hello,

In general rule, PR for adding events should be made against the lowest supported branch, which is currently 3.2.x.

User avatar
Dark❶
Registered User
Posts: 47
Joined: Mon Jan 15, 2018 1:22 pm
Location: DarK V0id
Name: Dark❶ [dark1]

Re: New Style Template Event in phpBB

Post by Dark❶ » Thu May 10, 2018 2:29 pm

GanstaZ wrote:
Wed May 09, 2018 4:48 pm
Maybe this can help you Development Git
&
Zoddo wrote:
Wed May 09, 2018 7:16 pm
Hello,

In general rule, PR for adding events should be made against the lowest supported branch, which is currently 3.2.x.
---------------------------------------
Thanks both of you, I'll make a PR soon.

Best regards. :D
Dark❶ [dark1]

Post Reply

Return to “Extension Writers Discussion”

Who is online

Users browsing this forum: No registered users and 11 guests