New Style Template Event in phpBB

Discussion forum for Extension Writers regarding Extension Development.
Post Reply
User avatar
Dark❶
Registered User
Posts: 395
Joined: Mon Jan 15, 2018 1:22 pm
Location: D@rK V0id
Name: Dark❶ [dark1]
Contact:

New Style Template Event in phpBB

Post by Dark❶ »

Hi! Dear friends,

I would like to make some Pull request on GitHub for some New Style Template Event in phpBB.

Where should I be making the Pull request (Branch)?, example:
1. https://github.com/phpbb/phpbb/tree/3.2.x
2. https://github.com/phpbb/phpbb/tree/prep-release-3.2.3
3. https://github.com/phpbb/phpbb/tree/prep-release-3.2.2

And what else should I be doing other than making pull request in required template files?

I am making this for upcoming Extension.

BTW this did not help : General forum information/Events requests,
It did not explain where to make the PR.

Thanking you. :)
Best Regards. :D
Dark❶ [dark1]
User avatar
GanstaZ
Registered User
Posts: 1187
Joined: Wed Oct 11, 2017 10:29 pm
Location: GZOverse

Re: New Style Template Event in phpBB

Post by GanstaZ »

Maybe this can help you Development Git
Usus est magister optimus! phpBB pre-Triton & latest php environment.
When answer lies in the question, question becomes redundant!
User avatar
Zoddo
Registered User
Posts: 158
Joined: Thu Aug 18, 2011 2:41 pm
Location: Le Mans, France
Name: Yohan
Contact:

Re: New Style Template Event in phpBB

Post by Zoddo »

Hello,

In general rule, PR for adding events should be made against the lowest supported branch, which is currently 3.2.x.
User avatar
Dark❶
Registered User
Posts: 395
Joined: Mon Jan 15, 2018 1:22 pm
Location: D@rK V0id
Name: Dark❶ [dark1]
Contact:

Re: New Style Template Event in phpBB

Post by Dark❶ »

GanstaZ wrote: Wed May 09, 2018 4:48 pm Maybe this can help you Development Git
&
Zoddo wrote: Wed May 09, 2018 7:16 pm Hello,

In general rule, PR for adding events should be made against the lowest supported branch, which is currently 3.2.x.
---------------------------------------
Thanks both of you, I'll make a PR soon.

Best regards. :D
Dark❶ [dark1]
Post Reply

Return to “Extension Writers Discussion”