Page 1 of 1

New Style Template Event in phpBB

Posted: Wed May 09, 2018 4:09 pm
by Dark❶
Hi! Dear friends,

I would like to make some Pull request on GitHub for some New Style Template Event in phpBB.

Where should I be making the Pull request (Branch)?, example:
1. https://github.com/phpbb/phpbb/tree/3.2.x
2. https://github.com/phpbb/phpbb/tree/prep-release-3.2.3
3. https://github.com/phpbb/phpbb/tree/prep-release-3.2.2

And what else should I be doing other than making pull request in required template files?

I am making this for upcoming Extension.

BTW this did not help : General forum information/Events requests,
It did not explain where to make the PR.

Thanking you. :)
Best Regards. :D

Re: New Style Template Event in phpBB

Posted: Wed May 09, 2018 4:48 pm
by GanstaZ
Maybe this can help you Development Git

Re: New Style Template Event in phpBB

Posted: Wed May 09, 2018 7:16 pm
by Zoddo
Hello,

In general rule, PR for adding events should be made against the lowest supported branch, which is currently 3.2.x.

Re: New Style Template Event in phpBB

Posted: Thu May 10, 2018 2:29 pm
by Dark❶
GanstaZ wrote:
Wed May 09, 2018 4:48 pm
Maybe this can help you Development Git
&
Zoddo wrote:
Wed May 09, 2018 7:16 pm
Hello,

In general rule, PR for adding events should be made against the lowest supported branch, which is currently 3.2.x.
---------------------------------------
Thanks both of you, I'll make a PR soon.

Best regards. :D