Page 2 of 2

Re: Textreparser documentation?

Posted: Tue Jun 12, 2018 7:14 am
by Ger
JoshyPHP wrote:
Tue Jun 12, 2018 3:23 am
I don't know whether the CLI uses a lock and I hope not. I don't know why a lock exists.
This made me wonder, since I have seen the lock. It seems to be used only in the cron task: https://github.com/phpbb/phpbb-core/blo ... er.php#L72

I've corrected this in above post. Also, David63 was so kind to send me some textual improvements, those are also incorporated in above post.

Since almost anyone participating in this topic wrote that he doesn't know all the technical bits, I took a look at Github. It seems that Elsensee has written most of the text reparser code.
Elsensee wrote: Gentile poke
@Elsensee: would you be so kind to tell us if we've got the explanation here right?

Re: Textreparser documentation?

Posted: Tue Jun 12, 2018 7:34 am
by 3Di
It's all about CLi it seems, why not to add what the documentation says about the normal behaviour of an update 3.1/3.2?
phpBB 3.2 has a New Text Reparser class which will convert all posts, PMs, signatures, etc. to the new format shortly after updating to 3.2 (this is handled mostly by incremental cron jobs).
https://area51.phpbb.com/docs/dev/3.2.x ... ode-engine
When a board is updated from 3.1 to 3.2, the reparser is called into service in two ways. First, migrations are used to reparse some of the smaller database items (forum descriptions, for example). Second, cron tasks are used to incrementally reparse the larger database items (posts & PMs).
https://area51.phpbb.com/docs/dev/3.2.x ... t-reparser

Which explains a bit about the lock thinghy too.

Missing details about ansi and the meaning of it, also.

Re: Textreparser documentation?

Posted: Tue Jun 12, 2018 9:45 am
by Ger
Thanks, incorporated as well.

Re: Textreparser documentation?

Posted: Wed Jun 13, 2018 2:57 am
by 3Di
Looks good to me.
Just remove those backticks from the update SQL query, please.

Re: Textreparser documentation?

Posted: Wed Jun 13, 2018 7:01 am
by Ger
3Di wrote:
Wed Jun 13, 2018 2:57 am
remove those backticks from the update SQL query, please.
Why?

Re: Textreparser documentation?

Posted: Fri Jun 15, 2018 6:56 pm
by 3Di
I am not quite sure that query will work on every supported DB since doesn't seems to be ANSI SQL, I can't test that though.
Backticks can stay on MySql, yes.

As for more details on CLI commands, please read: https://area51.phpbb.com/docs/dev/3.2.x/cli/index.html

Re: Textreparser documentation?

Posted: Tue Jun 26, 2018 7:17 am
by Ger
Mentioned above and also incorporated some suggestions from the team

Re: Textreparser documentation?

Posted: Tue Jun 26, 2018 12:08 pm
by 3Di
Ger wrote:
Fri Jun 08, 2018 2:48 pm

You can also run in safe-mode, ignoring any extensions you might have:

Code: Select all

php bin/phpbbcli.php --safe-mode reparser:reparse  --ansi
safe-mode also ignores the cache if I correctly recall?
Ger wrote:
Fri Jun 08, 2018 2:48 pm
Suggestions from 3Di[
Extra opening square brace appended to my nickname. :P :)

Side note: --ansi supports 'ANSI' control character sequences for terminals on Unix-like operating systems and Windows.

It does emulate a known terminal (for those of us old dogs) https://en.wikipedia.org/wiki/List_of_t ... _emulators
.. there were also vt-100, vt102, etc.. once upon a time.

Re: Textreparser documentation?

Posted: Tue Jun 26, 2018 12:34 pm
by Ger
Yeah, I don't intent to write extensive documentation about the CLI. The purpose of this doc is to have documentation about the Text Reparser. That needs some short explanation about the Textformatter and the CLI, but those have their own place for documentation. If you think the CLI documentation is incomplete or faulty, I think you should contribute to that specific documentation.

Re: Textreparser documentation?

Posted: Wed Jun 27, 2018 2:41 pm
by VSE
Ger wrote:
Fri Jun 08, 2018 2:48 pm
Right, I now have this:
https://github.com/GerB/quotedwhere/blo ... hp#L50-L55
Are you able to submit an article for this to the knowledgebase here: https://www.phpbb.com/support/docs/en/3.2/kb/

Re: Textreparser documentation?

Posted: Wed Jun 27, 2018 4:38 pm
by Ger
Nope, don't have permission for that. But I have pm discussion about it through JimA with some team members about it. Should go to the KB soon.

Re: Textreparser documentation?

Posted: Wed Jul 04, 2018 12:29 pm
by JimA
Ger wrote:
Wed Jun 27, 2018 4:38 pm
Nope, don't have permission for that. But I have pm discussion about it through JimA with some team members about it. Should go to the KB soon.
This has been posted now. Thanks to everybody contributing, and especially Ger for writing the article itself. :)
Knowledge Base - phpBB 3.2+ Text Reparser

Re: Textreparser documentation?

Posted: Wed Jul 04, 2018 12:47 pm
by Ger
Great, thanks!