Pre Validator and GPL v2

Discussion forum for Extension Writers regarding Extension Development.
Post Reply
User avatar
Restless Rancor
Registered User
Posts: 184
Joined: Tue Sep 18, 2018 1:51 pm

Pre Validator and GPL v2

Post by Restless Rancor » Sun Nov 04, 2018 11:20 am

Hi, I've put my two extensions through the EPV but am getting confusing results.

Both return the same errors:

Code: Select all

Checkout https://github.com/restless-rancor/rr-post-count-on-index from git on branch master.
Running Extension Pre Validator .
Running tests.


Validation: FAILED 
Fatal: 0, Error: 2, Warning: 0, Notice: 0 


Test results for extension:
Error: Packaging structure doesn't meet the extension DB policies.
Expected: restlessrancor/postcountonindex
Got: 
Error: It is required to use the GPL-2.0 as license. MIT is not allowed as per the extension database policies. in /composer.json
The first error about file structure I can ignore, when submitted to the CBD they'll be in restlessrancor/postcountonindex and restlessrancor/attachmentshields respectively.

The second error suggests they are using an MIT license, but they're not, (Post Count On Index | Attachment Shields), and the license.txt for each of them is the GPL v2.

I used the Skeleton Extension to get the base structure of the extensions, which also provided the license info which I haven't changed - do I need to tweak them?

Also, how long roughly will it take for validation? I did submit Post Count On Index to the CBD on Thursday and fell over the EOL Conversion with the translations, which I updated and submitted a new revision for. I don't want to be seen as nagging or anything, it's just so I can sit back and relax until then :roll:

Thanks :geek:
These aren't the droids you're looking for...
My Extensions and Snippets (Ref link)

User avatar
RMcGirr83
Recognised Extension Developer
Posts: 20998
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr
Contact:

Re: Pre Validator and GPL v2

Post by RMcGirr83 » Sun Nov 04, 2018 11:39 am

Extensions usually take roughly 30 days to get validated. Sometime quicker, sometimes longer.
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored

User avatar
Restless Rancor
Registered User
Posts: 184
Joined: Tue Sep 18, 2018 1:51 pm

Re: Pre Validator and GPL v2

Post by Restless Rancor » Sun Nov 04, 2018 11:41 am

Thanks for the info! Would you say I could ignore the license error, as when I submitted it to the CBD it didn't throw any errors about license?
Last edited by Restless Rancor on Sun Nov 04, 2018 11:58 am, edited 1 time in total.
These aren't the droids you're looking for...
My Extensions and Snippets (Ref link)

User avatar
david63
Jr. Extension Validator
Posts: 15060
Joined: Thu Dec 19, 2002 8:08 am
Location: Lancashire, UK
Name: David Wood
Contact:

Re: Pre Validator and GPL v2

Post by david63 » Sun Nov 04, 2018 11:45 am

I don't know if the licence error is a false positive but I notice that you have your licence as GPL-2.0-only. I have always used GPL-2.0 and never had any problems.
David
Remember: You only know what you know and - you don't know what you don't know!
My CDB Contributions | How to install an extension
I will not be accepting translations for any of my extensions in Github - please post any translations in the appropriate topic.
No support requests via PM or email as they will be ignored

User avatar
Restless Rancor
Registered User
Posts: 184
Joined: Tue Sep 18, 2018 1:51 pm

Re: Pre Validator and GPL v2

Post by Restless Rancor » Sun Nov 04, 2018 11:55 am

Thanks for the info, though it just occured to me that when I submitted the extension to the CBD, the license error didn't show. I have taken a look at some of the extensions I have installed and the license varies from GPL-2.0-only and GPL-2.0. I'm probably putting too much thought into it: it's probably a false positive, as the error didn't show when I submitted to the CBD.

Thanks :geek:
These aren't the droids you're looking for...
My Extensions and Snippets (Ref link)

User avatar
kasimi
Extension Customisations
Extension Customisations
Posts: 3360
Joined: Sat Sep 10, 2011 7:12 pm
Location: Germany
Contact:

Re: Pre Validator and GPL v2

Post by kasimi » Sun Nov 04, 2018 11:58 am

The license field in the composer.json needs to be GPL-2.0-only since January. It looks like the EVP at https://www.phpbb.com/extensions/epv/ is outdated.
paul999 wrote: ping

User avatar
Restless Rancor
Registered User
Posts: 184
Joined: Tue Sep 18, 2018 1:51 pm

Re: Pre Validator and GPL v2

Post by Restless Rancor » Sun Nov 04, 2018 11:59 am

Oh thanks for clarifying kasimi!
These aren't the droids you're looking for...
My Extensions and Snippets (Ref link)

User avatar
kasimi
Extension Customisations
Extension Customisations
Posts: 3360
Joined: Sat Sep 10, 2011 7:12 pm
Location: Germany
Contact:

Re: Pre Validator and GPL v2

Post by kasimi » Sun Nov 04, 2018 12:01 pm

You can check the latest queue statistics here: https://www.phpbb.com/customise/db/queu ... /extension

User avatar
Restless Rancor
Registered User
Posts: 184
Joined: Tue Sep 18, 2018 1:51 pm

Re: Pre Validator and GPL v2

Post by Restless Rancor » Sun Nov 04, 2018 12:01 pm

Oh perfect thanks :cool:
These aren't the droids you're looking for...
My Extensions and Snippets (Ref link)

User avatar
david63
Jr. Extension Validator
Posts: 15060
Joined: Thu Dec 19, 2002 8:08 am
Location: Lancashire, UK
Name: David Wood
Contact:

Re: Pre Validator and GPL v2

Post by david63 » Sun Nov 04, 2018 12:10 pm

kasimi wrote:
Sun Nov 04, 2018 11:58 am
The license field in the composer.json needs to be GPL-2.0-only since January. It looks like the EVP at https://www.phpbb.com/extensions/epv/ is outdated.
Where was that posted? I never saw it - but I could easily have missed it as I was in New Zealand at the time.
David
Remember: You only know what you know and - you don't know what you don't know!
My CDB Contributions | How to install an extension
I will not be accepting translations for any of my extensions in Github - please post any translations in the appropriate topic.
No support requests via PM or email as they will be ignored

User avatar
kasimi
Extension Customisations
Extension Customisations
Posts: 3360
Joined: Sat Sep 10, 2011 7:12 pm
Location: Germany
Contact:

Re: Pre Validator and GPL v2

Post by kasimi » Sun Nov 04, 2018 2:05 pm

This is the only reference I could find: https://tracker.phpbb.com/browse/PHPBB3-15525

User avatar
Paul
Infrastructure Team Leader
Infrastructure Team Leader
Posts: 24789
Joined: Sat Dec 04, 2004 3:44 pm
Location: The netherlands.
Name: Paul Sohier
Contact:

Re: Pre Validator and GPL v2

Post by Paul » Sun Nov 04, 2018 2:59 pm

I am not near a pc right now, will check later why the website epv is not up to date.

The deny of your extension was done based on the insta-deny rules. If the insta deny time passed, it can't be longer denied based on epv, and will be fully validated. As said, this can take up to a month, and you will receive a pm once it is validated. If you have more validation specific questions you should post in the queue discussion topic for your extension, as we don't discuss specifics for a extension in public.
david63 wrote:
Sun Nov 04, 2018 12:10 pm
kasimi wrote:
Sun Nov 04, 2018 11:58 am
The license field in the composer.json needs to be GPL-2.0-only since January. It looks like the EVP at https://www.phpbb.com/extensions/epv/ is outdated.
Where was that posted? I never saw it - but I could easily have missed it as I was in New Zealand at the time.
It is a changes from composer, and not phpBB specific.
Knock knock
Race condition
Who's there?

My BlogMy Photosmy phpBB Extensionscustom phpBB work & Development

User avatar
Restless Rancor
Registered User
Posts: 184
Joined: Tue Sep 18, 2018 1:51 pm

Re: Pre Validator and GPL v2

Post by Restless Rancor » Sun Nov 04, 2018 3:08 pm

Thanks Paul, sorry if I've seemed impatient at all- it's a new learning process for me and my brain likes to play tricks on me so I can easily fall over myself :oops:
Paul wrote:
Sun Nov 04, 2018 2:59 pm
If you have more validation specific questions you should post in the queue discussion topic for your extension, as we don't discuss specifics for a extension in public.
Noted and understood, thanks again :geek:
These aren't the droids you're looking for...
My Extensions and Snippets (Ref link)

User avatar
3Di
Registered User
Posts: 13113
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: Pre Validator and GPL v2

Post by 3Di » Sun Nov 04, 2018 8:59 pm

kasimi wrote:
Sun Nov 04, 2018 12:01 pm
You can check the latest queue statistics here: https://www.phpbb.com/customise/db/queu ... /extension
queue5.png
queue5.png (2.57 KiB) Viewed 222 times
I feel it's my duty to provide you with some work. :) :P
:game_die: The new Dice Roller extension for phpBB 3.2 is out! :game_die:

Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
Extensions, Scripts, MOD porting, Update/Upgrades
My development's activity º PhpStorm's proud user

Post Reply

Return to “Extension Writers Discussion”

Who is online

Users browsing this forum: No registered users and 16 guests