Page 2 of 2

Re: Enable Debug, SQL Explain and Load time

Posted: Tue Dec 24, 2019 10:22 am
by Erpenator
Thanks for unlocking the topic. I've updated our the board to 3.3.0-RC1 on our development server and we will have the same issue as described above. I've tested the config.yml with the tool mentioned above and it seems to be a valid config.yml file. The other config settings do work, so I am confident the problem is not in the config.yml file.

Re: Enable Debug, SQL Explain and Load time

Posted: Tue Dec 24, 2019 5:37 pm
by 3Di
Erpenator wrote: Thu Dec 19, 2019 8:21 am If you want I can install a fresh version of the forum software to see if the problem still exists.
Yes.

Re: Enable Debug, SQL Explain and Load time

Posted: Thu Jan 09, 2020 5:21 am
by 3Di
Erpenator wrote: Wed Dec 18, 2019 7:35 pm I had another look why the sql_explain wasn't working once I enabled it and I think I found the problem. The error that is generated is :
PHP Fatal error: Uncaught Error: Call to undefined method Symfony\\Component\\HttpFoundation\\Request::variable() in /phpbb/db/driver/driver.php:1042
See if this fixes your issue: https://github.com/phpbb/phpbb/pull/5822/files

Re: Enable Debug, SQL Explain and Load time

Posted: Fri Jan 10, 2020 1:02 pm
by Erpenator
3Di wrote: Thu Jan 09, 2020 5:21 am See if this fixes your issue: https://github.com/phpbb/phpbb/pull/5822/files
Yes, it does fix the issue.

Re: Enable Debug, SQL Explain and Load time

Posted: Fri Jan 10, 2020 10:33 pm
by 3Di
Solved then :)

Re: Enable Debug, SQL Explain and Load time

Posted: Sat Jan 11, 2020 8:21 am
by Erpenator
Yes, and I think we can conclude there was something wrong in the code that caused it?

Re: Enable Debug, SQL Explain and Load time

Posted: Sat Jan 11, 2020 8:56 am
by 3Di
Erpenator wrote: Sat Jan 11, 2020 8:21 am Yes, and I think we can conclude there was something wrong in the code that caused it?
Very old code not removed during the new implementation, the same request is already checked in phpbb_check_and_display_sql_report().