[Info] Using Github Actions to Test Extensions

Discussion forum for Extension Writers regarding Extension Development.
User avatar
3Di
I've Been Banned!
Posts: 17538
Joined: Mon Apr 04, 2005 11:09 pm
Location: I'm with Ukraine 🇺🇦
Name: Marco
Contact:

Re: [Info] Using Github Actions to Test Extensions

Post by 3Di »

Disable your tests for php 8.1 for now, like phpBB does here
https://github.com/phpbb/phpbb/blob/46d ... #L126-L127
🆓 Free support for our extensions also provided here: phpBB Studio
🚀 Looking for a specific feature or alternative option? We will rock you!
Please PM me only to request paid works. Thx. Buy me a coffee -> Image
My development's activity º PhpStorm's proud user º Extensions, Scripts, MOD porting, Update/Upgrades
martec
Registered User
Posts: 324
Joined: Sat Sep 19, 2009 2:15 pm

Re: [Info] Using Github Actions to Test Extensions

Post by martec »

3Di wrote: Wed Mar 24, 2021 5:17 am Disable your tests for php 8.1 for now, like phpBB does here
https://github.com/phpbb/phpbb/blob/46d ... #L126-L127
@3Di very thanks for information!
so because of this https://tracker.phpbb.com/browse/PHPBB3-16707 and https://github.com/phpbb/phpbb/pull/6162

I thought I was doing something wrong. thanks again for the info.
User avatar
Crizzo
Translations & International Support Teams Manager
Translations & International Support Teams Manager
Posts: 1653
Joined: Thu Apr 23, 2009 1:20 pm
Location: Stuttgart, Germany
Name: Christian
Contact:

Re: [Info] Using Github Actions to Test Extensions

Post by Crizzo »

I have this error
71 | ERROR | Either use statement or full name must be used.
| | (..phpbb_Sniffs_Namespaces_UnusedUse.FullName
This is pointing on my constructor or its doc block.

Edit: Solution: viewtopic.php?f=461&t=2579596
My extensions for phpBB: CDB
German phpBB Support at www.phpbb.de
User avatar
LukeWCS
Registered User
Posts: 245
Joined: Mon Dec 08, 2014 12:32 pm
Location: Germany

Re: [Info] Using Github Actions to Test Extensions

Post by LukeWCS »

I tested Github Actions today. Since I haven't used Travis in a long time, I was curious about GA. I noticed that not all tests are run in certain situations.

In particular, it concerns the tests that are carried out according to CS, i.e. ICC, EXE and EPV. I deliberately uploaded a prepared Ext, which definitely triggers errors in CS and EPV, so I always test my phpBB Ext Check. CS was always executed, but the subsequent tests never. After many attempts, I found that the tests below would not run if CS found errors.

For testing purposes, I uploaded a version of the Ext in the repo that does not trigger any errors in CS and EPV. This is where the following tests are carried out. Then I replaced a tab in a PHP file with 4 spaces and updated the repo again. Now CS reports an error and the following tests are no longer carried out, see picture.

PicPick_2021-04-23_12-39-42.png
May the backup be with you. Always.
User avatar
Prosk8er
Registered User
Posts: 1744
Joined: Sun Mar 12, 2006 3:30 am
Location: Rochester, NY
Name: Tyler
Contact:

Re: [Info] Using Github Actions to Test Extensions

Post by Prosk8er »

i got rid of travis for my snowstorm lights extension https://github.com/Prosk8er/Snowstorm-Lights and i have one error is it fixable or forget about it?
Attachments
Screenshot 2021-05-28 193540.png
User avatar
Prosk8er
Registered User
Posts: 1744
Joined: Sun Mar 12, 2006 3:30 am
Location: Rochester, NY
Name: Tyler
Contact:

Re: [Info] Using Github Actions to Test Extensions

Post by Prosk8er »

for now i just did IMAGE_ICC: 0
but would still like to know if there is a fix for above error
User avatar
MattF
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 5859
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman

Re: [Info] Using Github Actions to Test Extensions

Post by MattF »

You need to strip the ICC profile from the image. Google it.
Formerly known as VSEMy ExtensionsPlease do not PM me for support.
User avatar
Prosk8er
Registered User
Posts: 1744
Joined: Sun Mar 12, 2006 3:30 am
Location: Rochester, NY
Name: Tyler
Contact:

Re: [Info] Using Github Actions to Test Extensions

Post by Prosk8er »

got it thank you matt
in adobe cc i did edit/assign profile and clicked don't color manage this document
User avatar
Toxyy
Registered User
Posts: 942
Joined: Mon Oct 24, 2016 3:22 pm
Location: Namek
Contact:

Re: [Info] Using Github Actions to Test Extensions

Post by Toxyy »

Toxyy wrote: Fri Apr 23, 2021 11:18 pm Getting this error on the PHP 8.0 - mysql:5.7 test in github actions:

Code: Select all

Test directory "phpBB/ext/toxyy/anonymousposts/.github/../tests" not found
Error: Process completed with exit code 2.
This part passes in all of the other tests, I'm not sure what's wrong with the php 8 one.
Still experiencing this error:
https://github.com/toxyy/anonymousposts ... step:10:16
I am a web developer/administrator, specializing in forums. If you have work you need done or are too lazy to do, pm me!

Some of my extensions:
[3.3][BETA] Post Form Templates || [3.3][BETA] Anonymous Posts || [3.2][3.3][BETA] ACP Merge Child Forums || [3.2][BETA] Sticky Ad || [3.2][DEV] User Delete Topics || [3.3][DEV] Moderate While Searching || [3.3][RC] Short Number Twig Extension
Paul
Infrastructure Team Leader
Infrastructure Team Leader
Posts: 28619
Joined: Sat Dec 04, 2004 3:44 pm
Location: The netherlands.
Name: Paul Sohier
Contact:

Re: [Info] Using Github Actions to Test Extensions

Post by Paul »

Did you trying creating the tests/ directory, and putting tests in there?
User avatar
Toxyy
Registered User
Posts: 942
Joined: Mon Oct 24, 2016 3:22 pm
Location: Namek
Contact:

Re: [Info] Using Github Actions to Test Extensions

Post by Toxyy »

Paul wrote: Sun Apr 10, 2022 11:16 am Did you trying creating the tests/ directory, and putting tests in there?
That was my next step, I was just unaware of if it was a bug since all tests in other php versions run fine without it, as my other extension shows:
https://github.com/toxyy/acpmergechildf ... 2101076289
I am a web developer/administrator, specializing in forums. If you have work you need done or are too lazy to do, pm me!

Some of my extensions:
[3.3][BETA] Post Form Templates || [3.3][BETA] Anonymous Posts || [3.2][3.3][BETA] ACP Merge Child Forums || [3.2][BETA] Sticky Ad || [3.2][DEV] User Delete Topics || [3.3][DEV] Moderate While Searching || [3.3][RC] Short Number Twig Extension
User avatar
MattF
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 5859
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman

Re: [Info] Using Github Actions to Test Extensions

Post by MattF »

Toxyy wrote: Sun Apr 10, 2022 11:10 am
Toxyy wrote: Fri Apr 23, 2021 11:18 pm Getting this error on the PHP 8.0 - mysql:5.7 test in github actions:

Code: Select all

Test directory "phpBB/ext/toxyy/anonymousposts/.github/../tests" not found
Error: Process completed with exit code 2.
This part passes in all of the other tests, I'm not sure what's wrong with the php 8 one.
Still experiencing this error:
https://github.com/toxyy/anonymousposts ... step:10:16
viewtopic.php?p=15647011#p15647011
Formerly known as VSEMy ExtensionsPlease do not PM me for support.
Post Reply

Return to “Extension Writers Discussion”