Code sniffer changes

[david63]

OK - who's been tampering?

I am suddenly getting errors that were not there before

Code: Select all

Either use statement or full name must be used.
(..phpbb_Sniffs_Namespaces_UnusedUse.FullName)

Files containing these errors have not been changed and this is happening with all files that contain use statements.

[RMcGirr83]

It's because of lines such as these

Code: Select all

	/** @var \phpbb\config\config */

which is commented so not sure why it would even matter.
changing it to

Code: Select all

	/** @var config */

fixes the supposed error but that's a lot of work (many of my extensions are like the first) for zero gain.

[david63]

Yup that is it

fixes the supposed error but that's a lot of work (many of my extensions are like the first) for zero gain.

Same here

Any idea when this changed and where it was documented?

Ah well only about 200 files to manually edit - should give me something to do during lockdown. Trouble is life is too short for all this nonsense!

[RMcGirr83]

No clue

[warmweer]

Trouble is life is too short for all this nonsense!

You should create an extension to life (but I'll leave it to others to test that - I'm not risking any fatal errors )

[MattF]

Yup that is it

fixes the supposed error but that's a lot of work (many of my extensions are like the first) for zero gain.

Same here

Any idea when this changed and where it was documented?

Ah well only about 200 files to manually edit - should give me something to do during lockdown. Trouble is life is too short for all this nonsense!

Use of a behemoth IDE like PHPStorm should prevent these issues in the first place

The code sniffer rules were made more strict on checking how Namespaces are used.

If you have a USE satatement, like

Code: Select all

use \phpbb\user\user

Then anytime you reference it in a comment or code you must use the alias/shortened form of it, like:

Code: Select all

/** @var user $user */
__construct(user $user)

[david63]

Use of a behemoth IDE like PHPStorm should prevent these issues in the first place

Only if you happen to have deep pockets

[MattF]

Use of a behemoth IDE like PHPStorm should prevent these issues in the first place

Only if you happen to have deep pockets

It's $0.55 a day. Pocket change!

[RMcGirr83]

$200.75/year. Costs more than hulu

[Marc]

PhpStorm does cost $89 for an individual license for the first year and a reduced rate in consecutive years:

[david63]

I am well aware of the costs but I object to their pricing policy.

I have no problem with paying for any application if I deem it to be a requirement. I have no problem with paying for an upgrade, again if I deem it necessary. But I do object to being held to ransom at having to pay an annual fee to use an application.

My view is that their fees are too high and if they were half the price then they would be more acceptable. It's fine for business users who get it paid. It's fine for OS teams who get it free but, in my opinion, it is too expensive for the individual user.

I think that the point is being missed here. The discussion is not about what IDE to use but the lack of communication when changes are made and the amount of work required for what is basically cosmetic purposes.

If the aim is to deter Extension Developers from maintaining their extensions or creating new ones then this is the right way to be going about it.

[3Di]

And again, as I have already explained, PhpStorm is free for Open Source projects.
https://www.jetbrains.com/community/opensource/#support
this problem can be solved simply by adopting the most modern development methods via IDEs.
I don't understand where you are getting stuck, honestly. If you consider yourself a developer you can't refrain from progressing and keeping up with the progress. It is free! After reading your repositories I realise that you have not written any tests, so I wonder what you do with Travis or Github Actions workflows? You don't need them.

[david63]

as I have already explained, PhpStorm is free for Open Source projects.

Perhaps this part got lost in translation

Licenses are provided only to project leads and core project committers.

After reading your repositories I realise that you have not written any tests, so I wonder what you do with Travis or Github Actions workflows? You don't need them.

What I choose to do is only my concern - there are comments I could make about your extensions but I don't as it is none of my business.

Anyway all of this is moving seriously off topic.

[3Di]

Perhaps this part got lost in translation

Licenses are provided only to project leads and core project committers.

No, as I said on Discord we got the free licence for the first year, then we evolved into selling software on demand and so our free licence was removed, from then on we are paying and after several years now the annual licence costs about 15 €uro cents a day, I don't think you are so poor that you can't afford it.

What I choose to do is only my concern

Sure it is.

There are comments I could make about your extensions but I don't as it is none of my business.

Feel free to object and propose solutions, our code is accessible on GitHub.
It will be my pleasure to respond to any objections and suggestions, thank you.

[KaileyT]

OK everyone, we are seriously steering off-topic. Please let's get back to discussion of the code-sniffer changes. IDE discussion can be taken to General Discussion if so desired.