Code sniffer changes

Discussion forum for Extension Writers regarding Extension Development.
User avatar
david63
Registered User
Posts: 19030
Joined: Thu Dec 19, 2002 8:08 am
Location: Lancashire, UK
Contact:

Code sniffer changes

Post by david63 »

OK - who's been tampering?

I am suddenly getting errors that were not there before

Code: Select all

Either use statement or full name must be used.
(..phpbb_Sniffs_Namespaces_UnusedUse.FullName)
Files containing these errors have not been changed and this is happening with all files that contain use statements.
David
Remember: You only know what you know and - you don't know what you don't know!
My CDB Contributions | How to install an extension
I will not be accepting translations for any of my extensions in Github - please post any translations in the appropriate topic.
No support requests via PM or email as they will be ignored
User avatar
RMcGirr83
Former Team Member
Posts: 21902
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: [Info] Using Github Actions to Test Extensions

Post by RMcGirr83 »

It's because of lines such as these

Code: Select all

	/** @var \phpbb\config\config */
which is commented so not sure why it would even matter.
changing it to

Code: Select all

	/** @var config */
fixes the supposed error but that's a lot of work (many of my extensions are like the first) for zero gain.
Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
Appreciate the extensions/mods/support then buy me a beerImage
User avatar
david63
Registered User
Posts: 19030
Joined: Thu Dec 19, 2002 8:08 am
Location: Lancashire, UK
Contact:

Re: [Info] Using Github Actions to Test Extensions

Post by david63 »

Yup that is it :evil:
RMcGirr83 wrote:
Mon Jan 04, 2021 11:48 am
fixes the supposed error but that's a lot of work (many of my extensions are like the first) for zero gain.
Same here :twisted: :twisted:

Any idea when this changed and where it was documented?

Ah well only about 200 files to manually edit - should give me something to do during lockdown. Trouble is life is too short for all this nonsense!
Last edited by david63 on Mon Jan 04, 2021 1:07 pm, edited 1 time in total.
David
Remember: You only know what you know and - you don't know what you don't know!
My CDB Contributions | How to install an extension
I will not be accepting translations for any of my extensions in Github - please post any translations in the appropriate topic.
No support requests via PM or email as they will be ignored
User avatar
RMcGirr83
Former Team Member
Posts: 21902
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: [Info] Using Github Actions to Test Extensions

Post by RMcGirr83 »

No clue
Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
Appreciate the extensions/mods/support then buy me a beerImage
User avatar
warmweer
Jr. Extension Validator
Posts: 6487
Joined: Fri Jul 04, 2003 6:34 am
Location: Van Allen Bel ... gium

Re: [Info] Using Github Actions to Test Extensions

Post by warmweer »

david63 wrote:
Mon Jan 04, 2021 12:47 pm
Trouble is life is too short for all this nonsense!
You should create an extension to life 8-) (but I'll leave it to others to test that - I'm not risking any fatal errors ;) )
Spelling is freeware, which means you can use it for free.
On the other hand, it is not open source, which means you cannot change it or publish it in a modified form.
User avatar
MattF
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 5351
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman
Contact:

Re: [Info] Using Github Actions to Test Extensions

Post by MattF »

david63 wrote:
Mon Jan 04, 2021 12:47 pm
Yup that is it :evil:
RMcGirr83 wrote:
Mon Jan 04, 2021 11:48 am
fixes the supposed error but that's a lot of work (many of my extensions are like the first) for zero gain.
Same here :twisted: :twisted:

Any idea when this changed and where it was documented?

Ah well only about 200 files to manually edit - should give me something to do during lockdown. Trouble is life is too short for all this nonsense!
Use of a behemoth IDE like PHPStorm should prevent these issues in the first place ;)

The code sniffer rules were made more strict on checking how Namespaces are used.

If you have a USE satatement, like

Code: Select all

use \phpbb\user\user
Then anytime you reference it in a comment or code you must use the alias/shortened form of it, like:

Code: Select all

/** @var user $user */
__construct(user $user)
Formerly known as VSEMy ExtensionsPlease do not PM me for support.
User avatar
david63
Registered User
Posts: 19030
Joined: Thu Dec 19, 2002 8:08 am
Location: Lancashire, UK
Contact:

Re: [Info] Using Github Actions to Test Extensions

Post by david63 »

MattF wrote:
Mon Jan 04, 2021 5:37 pm
Use of a behemoth IDE like PHPStorm should prevent these issues in the first place
Only if you happen to have deep pockets :shock:
David
Remember: You only know what you know and - you don't know what you don't know!
My CDB Contributions | How to install an extension
I will not be accepting translations for any of my extensions in Github - please post any translations in the appropriate topic.
No support requests via PM or email as they will be ignored
User avatar
MattF
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 5351
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman
Contact:

Re: [Info] Using Github Actions to Test Extensions

Post by MattF »

david63 wrote:
Mon Jan 04, 2021 6:37 pm
MattF wrote:
Mon Jan 04, 2021 5:37 pm
Use of a behemoth IDE like PHPStorm should prevent these issues in the first place
Only if you happen to have deep pockets :shock:
It's $0.55 a day. Pocket change!
Formerly known as VSEMy ExtensionsPlease do not PM me for support.
User avatar
RMcGirr83
Former Team Member
Posts: 21902
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: [Info] Using Github Actions to Test Extensions

Post by RMcGirr83 »

$200.75/year. Costs more than hulu :P
Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
Appreciate the extensions/mods/support then buy me a beerImage
User avatar
Marc
Development Team Leader
Development Team Leader
Posts: 5489
Joined: Tue Oct 30, 2007 10:57 pm
Location: Munich, Germany
Name: Marc
Contact:

Re: [Info] Using Github Actions to Test Extensions

Post by Marc »

PhpStorm does cost $89 for an individual license for the first year and a reduced rate in consecutive years:
phpstorm_cost.png
User avatar
david63
Registered User
Posts: 19030
Joined: Thu Dec 19, 2002 8:08 am
Location: Lancashire, UK
Contact:

Re: [Info] Using Github Actions to Test Extensions

Post by david63 »

I am well aware of the costs but I object to their pricing policy.

I have no problem with paying for any application if I deem it to be a requirement. I have no problem with paying for an upgrade, again if I deem it necessary. But I do object to being held to ransom at having to pay an annual fee to use an application.

My view is that their fees are too high and if they were half the price then they would be more acceptable. It's fine for business users who get it paid. It's fine for OS teams who get it free but, in my opinion, it is too expensive for the individual user.

I think that the point is being missed here. The discussion is not about what IDE to use but the lack of communication when changes are made and the amount of work required for what is basically cosmetic purposes.

If the aim is to deter Extension Developers from maintaining their extensions or creating new ones then this is the right way to be going about it.
David
Remember: You only know what you know and - you don't know what you don't know!
My CDB Contributions | How to install an extension
I will not be accepting translations for any of my extensions in Github - please post any translations in the appropriate topic.
No support requests via PM or email as they will be ignored
User avatar
3Di
Former Team Member
Posts: 16149
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milano 🇮🇹 Frankfurt 🇩🇪
Name: Marco
Contact:

Re: Code sniffer changes

Post by 3Di »

And again, as I have already explained, PhpStorm is free for Open Source projects.
https://www.jetbrains.com/community/opensource/#support
this problem can be solved simply by adopting the most modern development methods via IDEs.
I don't understand where you are getting stuck, honestly. If you consider yourself a developer you can't refrain from progressing and keeping up with the progress. It is free! After reading your repositories I realise that you have not written any tests, so I wonder what you do with Travis or Github Actions workflows? You don't need them.
🆓 Free support for our extensions also provided here: phpBB Studio
🚀 Looking for a specific feature or alternative option? We will rock you!
Please PM me only to request paid works. Thx. Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user º Extensions, Scripts, MOD porting, Update/Upgrades
User avatar
david63
Registered User
Posts: 19030
Joined: Thu Dec 19, 2002 8:08 am
Location: Lancashire, UK
Contact:

Re: Code sniffer changes

Post by david63 »

3Di wrote:
Tue Jan 05, 2021 9:53 am
as I have already explained, PhpStorm is free for Open Source projects.
Perhaps this part got lost in translation
Licenses are provided only to project leads and core project committers.
3Di wrote:
Tue Jan 05, 2021 9:53 am
After reading your repositories I realise that you have not written any tests, so I wonder what you do with Travis or Github Actions workflows? You don't need them.
What I choose to do is only my concern - there are comments I could make about your extensions but I don't as it is none of my business.

Anyway all of this is moving seriously off topic.
David
Remember: You only know what you know and - you don't know what you don't know!
My CDB Contributions | How to install an extension
I will not be accepting translations for any of my extensions in Github - please post any translations in the appropriate topic.
No support requests via PM or email as they will be ignored
User avatar
3Di
Former Team Member
Posts: 16149
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milano 🇮🇹 Frankfurt 🇩🇪
Name: Marco
Contact:

Re: Code sniffer changes

Post by 3Di »

david63 wrote:
Tue Jan 05, 2021 10:19 am
Perhaps this part got lost in translation
Licenses are provided only to project leads and core project committers.
No, as I said on Discord we got the free licence for the first year, then we evolved into selling software on demand and so our free licence was removed, from then on we are paying and after several years now the annual licence costs about 15 €uro cents a day, I don't think you are so poor that you can't afford it. :P
david63 wrote:
Tue Jan 05, 2021 10:19 am
What I choose to do is only my concern
Sure it is.
david63 wrote:
Tue Jan 05, 2021 10:19 am
There are comments I could make about your extensions but I don't as it is none of my business.
Feel free to object and propose solutions, our code is accessible on GitHub.
It will be my pleasure to respond to any objections and suggestions, thank you. :)
🆓 Free support for our extensions also provided here: phpBB Studio
🚀 Looking for a specific feature or alternative option? We will rock you!
Please PM me only to request paid works. Thx. Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user º Extensions, Scripts, MOD porting, Update/Upgrades
User avatar
KaileyT
Community Team Member
Community Team Member
Posts: 2933
Joined: Mon Sep 01, 2014 1:00 am
Location: sudo rm -rf /
Name: Kailey Truscott
Contact:

Re: Code sniffer changes

Post by KaileyT »

OK everyone, we are seriously steering off-topic. Please let's get back to discussion of the code-sniffer changes. IDE discussion can be taken to General Discussion if so desired. :wink:
Kailey Truscott - Community Team
Post Reply

Return to “Extension Writers Discussion”