Problems with updating

Get help with installation and running phpBB 3.1.x here. Please do not post bug reports, feature requests, or extension related questions here.
Scam Warning
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

NOTE: phpBB 3.1.x is at its End of Life stage and support will NOT be provided after July 1st, 2018.
User avatar
david63
Registered User
Posts: 18605
Joined: Thu Dec 19, 2002 8:08 am
Location: Lancashire, UK
Contact:

Re: Problems with updating

Post by david63 »

And has this been posted in the bug tracker with a PR?
David
Remember: You only know what you know and - you don't know what you don't know!
My CDB Contributions | How to install an extension
I will not be accepting translations for any of my extensions in Github - please post any translations in the appropriate topic.
No support requests via PM or email as they will be ignored
User avatar
Oyabun1
Former Team Member
Posts: 23162
Joined: Sun May 17, 2009 1:05 pm
Location: Australia
Name: Bill

Re: Problems with updating

Post by Oyabun1 »

Det. Lawliet wrote:Line 391: phpBB/includes/functions_mcp.php

Code: Select all

$sql .= 'AND topic_visibility = ' . ITEM_APPROVED;
Line 407: #

Code: Select all

$sql .= 'AND post_visibility = ' . ITEM_APPROVED;
Fix 391;

Code: Select all

$sql .= ' AND topic_visibility = ' . ITEM_APPROVED;
 			}
 			break;
Fix 407;

Code: Select all

$sql .= 'AND post_visibility = ' . ITEM_APPROVED;
 			}
 			break;
Thosee "fixes" aren't necessary for standard phpBB because that has always been in the code for 3.1.x.
                      Support Request Template
3.0.x: Knowledge Base Styles Support MOD Requests
3.1.x: Knowledge BaseStyles SupportExtension Requests
User avatar
Brf
Support Team Member
Support Team Member
Posts: 52171
Joined: Tue May 10, 2005 7:47 pm
Location: {postrow.POSTER_FROM}
Contact:

Re: Problems with updating

Post by Brf »

The fix is the space before the AND.

Code: Select all

$sql .= 'AND topic_visibility = ' . ITEM_APPROVED;
is replaced by

Code: Select all

$sql .= ' AND topic_visibility = ' . ITEM_APPROVED;
If the Moderator does not have m_approve, the "AND" is concatenated to the value on the previous line.
User avatar
Oyabun1
Former Team Member
Posts: 23162
Joined: Sun May 17, 2009 1:05 pm
Location: Australia
Name: Bill

Re: Problems with updating

Post by Oyabun1 »

OK, so it was just the instructions to add

Code: Select all

          }
          break;
a second time which were incorrect.
                      Support Request Template
3.0.x: Knowledge Base Styles Support MOD Requests
3.1.x: Knowledge BaseStyles SupportExtension Requests
Locked

Return to “[3.1.x] Support Forum”