Plupload: bad image for dark background-colour

For support and discussion related to templates, themes, and imagesets in phpBB 3.1.
Anti-Spam Guide
Locked
nachtelb
Registered User
Posts: 158
Joined: Sun Feb 19, 2006 2:00 pm
Location: Germany
Name: Bernhard
Contact:

Plupload: bad image for dark background-colour

Post by nachtelb »

The two gifs from plupload (/assets/plupload/img/) look bad on dark backgrounds with white pixels around them. Could someone of the developers please replace them with a better version? Perhaps my attachment will do it.

The third image-file from plupload - a animated gif - is ok.

Alternative: [RFC]
Shouldn't those images go their way into the theme?
Attachments
done.gif
done.gif (999 Bytes) Viewed 1573 times
error.gif
error.gif (977 Bytes) Viewed 1573 times
plupload-baeh.jpg
plupload-baeh.jpg (6.43 KiB) Viewed 1544 times
User avatar
nextgen
Registered User
Posts: 2377
Joined: Mon Jul 26, 2010 10:58 pm
Location: Guatemala
Name: Melvin García
Contact:

Re: Plupload: bad image for dark background-colour

Post by nextgen »

The default style is white and blue, change the icons already depends on each designer.
メルビン・ガルシア • phpBB Development StylesphpBB Argentina - Soporte en español 🇦🇷

Please do NOT contact for support via PM or email.
nachtelb
Registered User
Posts: 158
Joined: Sun Feb 19, 2006 2:00 pm
Location: Germany
Name: Bernhard
Contact:

Re: Plupload: bad image for dark background-colour

Post by nachtelb »

Ok, so tell me please, where do i have to change this icons in my theme path. Iam not allowed to change things outside my style-path to validate.
User avatar
_Vinny_
Style Customisations
Style Customisations
Posts: 8898
Joined: Tue Aug 11, 2009 12:45 am
Location: Brazil
Name: Marcus Vinicius
Contact:

Re: Plupload: bad image for dark background-colour

Post by _Vinny_ »

Could you report it in the tracker?

Plupload isn't "integrated" with style-path.
nachtelb
Registered User
Posts: 158
Joined: Sun Feb 19, 2006 2:00 pm
Location: Germany
Name: Bernhard
Contact:

Re: Plupload: bad image for dark background-colour

Post by nachtelb »

User avatar
PayBas
Former Team Member
Posts: 930
Joined: Thu May 25, 2006 12:37 am

Re: Plupload: bad image for dark background-colour

Post by PayBas »

You could just upload a replacement icon to your style/theme/images and edit plupload.css?:

Code: Select all

.file-status.file-working {
	background: url('../../../assets/plupload/img/throbber.gif');
}

.file-status.file-uploaded {
	background: url('../../../assets/plupload/img/done.gif');
}

.file-status.file-error {
	background: url('../../../assets/plupload/img/error.gif');
}
to

Code: Select all

.file-status.file-working {
	background: url('./images/throbber.gif');
}

.file-status.file-uploaded {
	background: url('./images/done.gif');
}

.file-status.file-error {
	background: url('./images/error.gif');
}
nachtelb
Registered User
Posts: 158
Joined: Sun Feb 19, 2006 2:00 pm
Location: Germany
Name: Bernhard
Contact:

Re: Plupload: bad image for dark background-colour

Post by nachtelb »

Ahh, Thank you, Paybas. You rock! :)
User avatar
RMcGirr83
Former Team Member
Posts: 21956
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: Plupload: bad image for dark background-colour

Post by RMcGirr83 »

PayBas wrote:You could just upload a replacement icon to your style/theme/images and edit plupload.css?:
I thought we were moving away from editing core files?
Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
Appreciate the extensions/mods/support then buy me a beerImage
User avatar
PayBas
Former Team Member
Posts: 930
Joined: Thu May 25, 2006 12:37 am

Re: Plupload: bad image for dark background-colour

Post by PayBas »

RMcGirr83 wrote:
PayBas wrote:You could just upload a replacement icon to your style/theme/images and edit plupload.css?:
I thought we were moving away from editing core files?
plupload.css isn't a core file. It's in the styles dir ;).
User avatar
RMcGirr83
Former Team Member
Posts: 21956
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: Plupload: bad image for dark background-colour

Post by RMcGirr83 »

Uhmm, no it's in the assets directory. Not within prosilver that I can see.
Noname.jpg
Noname.jpg (15.86 KiB) Viewed 1389 times
Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
Appreciate the extensions/mods/support then buy me a beerImage
Paul
Infrastructure Team Leader
Infrastructure Team Leader
Posts: 27451
Joined: Sat Dec 04, 2004 3:44 pm
Location: The netherlands.
Name: Paul Sohier
Contact:

Re: Plupload: bad image for dark background-colour

Post by Paul »

That are the images, not the css? :)
User avatar
PayBas
Former Team Member
Posts: 930
Joined: Thu May 25, 2006 12:37 am

Re: Plupload: bad image for dark background-colour

Post by PayBas »

RMcGirr83 wrote:Uhmm, no it's in the assets directory. Not within prosilver that I can see.
Yeah but you don't need to touch them. You can just use your own images, and edit the .css.

But I think this is a pretty weird way of working. So I'll see if there are any objections to simply moving/copying them to the prosilver dir.
User avatar
RMcGirr83
Former Team Member
Posts: 21956
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: Plupload: bad image for dark background-colour

Post by RMcGirr83 »

Fair enough :)
Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
Appreciate the extensions/mods/support then buy me a beerImage
Locked

Return to “[3.1.x] Styles Support & Discussion”