Quoted image as thumbnail

Looking for an Extension? Have an Extension request? Post your request here for help. (Note: This forum is community supported; while there is an Extensions Development Team, said team does not dedicate itself to handling requests in this forum)
Anti-Spam Guide
User avatar
Dragosvr92
Registered User
Posts: 1450
Joined: Sat Sep 12, 2009 7:27 am
Location: Romania
Name: Dragos Valentin Rădulescu
Contact:

Re: Quoted image as thumbnail

Post by Dragosvr92 »

Holger wrote:Woah! Thanks a lot!
Did you test if it actually works? The CSS code is wrong.
Formerly known as TheKiller
3.0| Avatar on Memberlist 1.0.3

User avatar
uruguayito
Registered User
Posts: 266
Joined: Mon Dec 13, 2010 2:46 pm
Location: Montevideo - Uruguay

Re: Quoted image as thumbnail

Post by uruguayito »

works perfect ...

tk VSE
I speak spanish
Sorry for my bad english

Holger
Registered User
Posts: 1779
Joined: Tue Mar 12, 2002 3:54 pm
Location: Hannover

Re: Quoted image as thumbnail

Post by Holger »

@Dragosvr92: Discovered that some seconds ago!

The image does not show, only the filename.

Solution? :)

User avatar
uruguayito
Registered User
Posts: 266
Joined: Mon Dec 13, 2010 2:46 pm
Location: Montevideo - Uruguay

Re: Quoted image as thumbnail

Post by uruguayito »

I repeat: the VSE ext works OK viewtopic.php?p=13896501#p13896501
I speak spanish
Sorry for my bad english

Holger
Registered User
Posts: 1779
Joined: Tue Mar 12, 2002 3:54 pm
Location: Hannover

Re: Quoted image as thumbnail

Post by Holger »

For me it does not work. It does not show the image, it only shows the filename. Or is that a setting somewhere?

The CSS-code does differ from the one that Wolfsblvt posted.

User avatar
uruguayito
Registered User
Posts: 266
Joined: Mon Dec 13, 2010 2:46 pm
Location: Montevideo - Uruguay

Re: Quoted image as thumbnail

Post by uruguayito »

no settings needed
I speak spanish
Sorry for my bad english

Holger
Registered User
Posts: 1779
Joined: Tue Mar 12, 2002 3:54 pm
Location: Hannover

Re: Quoted image as thumbnail

Post by Holger »

No, i dont mean a setting in "Quoted image as thumbnail"-ext, I mean a board setting that disables images in quotes!

User avatar
VSE
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 5106
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman
Contact:

Re: Quoted image as thumbnail

Post by VSE »

Dragosvr92 wrote:
Holger wrote:Woah! Thanks a lot!
Did you test if it actually works? The CSS code is wrong.
The CSS code is correct.

CSS is read from right to left. Using "img" as mentioned in previous posts here is wrong, because that means the CSS will look for every single image on the page first - every button, avatar, etc. Then filter those down to blockquote elements. That's highly inefficient. It's also the reason we added the "postimage" class to every posted image. The correct CSS will only look for the posted images and then filter those down to the blockquote images (for Prosilver styles) or the "quotecontent" class (for subsilver2 styles).
🧩 My Extensions 🧩 ✨ YES...they ALL work with phpBB 3.3!! ✨
Please do not PM me for support.

User avatar
VSE
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 5106
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman
Contact:

Re: Quoted image as thumbnail

Post by VSE »

By the way I updated the attachment with a slight tweak.
posting.php?mode=reply&f=496&t=2282591#pr13896501

If anyone wants to take over this extension and make it "theirs" feel free.
🧩 My Extensions 🧩 ✨ YES...they ALL work with phpBB 3.3!! ✨
Please do not PM me for support.

User avatar
Dragosvr92
Registered User
Posts: 1450
Joined: Sat Sep 12, 2009 7:27 am
Location: Romania
Name: Dragos Valentin Rădulescu
Contact:

Re: Quoted image as thumbnail

Post by Dragosvr92 »

I previously tried to use blockquote .postimage and it did not work for me, so i had to use blockquote img.postimage and that worked. Now it does seem to work. Maybe i did something different when i tried that. But the max-width really isnt helpful. The property simply gets ignored. But wouldnt it be better to define the style this way? <style type="text/css"> ? Using an extension for one line of css seems a little much to me still...
Formerly known as TheKiller
3.0| Avatar on Memberlist 1.0.3

User avatar
VSE
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 5106
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman
Contact:

Re: Quoted image as thumbnail

Post by VSE »

Dragosvr92 wrote:I previously tried to use blockquote .postimage and it did not work for me, so i had to use blockquote img.postimage and that worked. Now it does seem to work. Maybe i did something different when i tried that. But the max-width really isnt helpful. The property simply gets ignored. But wouldnt it be better to define the style this way? <style type="text/css"> ? Using an extension for one line of css seems a little much to me still...
style tags do not need type=text/css in HTML5.

max-width is helpful for dealing with wide images (it only gets ignored if the image is taller than wide, and vice versa for max-height with wide images). But you are right, it's being cancelled out by an overqualified style attribute in the core, so it actually should be .postbody blockquote .postimage

I updated the download again to make up for this oversight.
🧩 My Extensions 🧩 ✨ YES...they ALL work with phpBB 3.3!! ✨
Please do not PM me for support.

Holger
Registered User
Posts: 1779
Joined: Tue Mar 12, 2002 3:54 pm
Location: Hannover

Re: Quoted image as thumbnail

Post by Holger »

Hm, what am I doing wrong?
In the quote the attached image is only shown as a filename.

User avatar
VSE
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 5106
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman
Contact:

Re: Quoted image as thumbnail

Post by VSE »

Holger wrote:Hm, what am I doing wrong?
In the quote the attached image is only shown as a filename.
This is for img tags. Not attachments.
🧩 My Extensions 🧩 ✨ YES...they ALL work with phpBB 3.3!! ✨
Please do not PM me for support.

Holger
Registered User
Posts: 1779
Joined: Tue Mar 12, 2002 3:54 pm
Location: Hannover

Re: Quoted image as thumbnail

Post by Holger »

Ooopps! :oops:
:lol:

User avatar
Mess
Registered User
Posts: 985
Joined: Wed Jul 01, 2009 6:37 am
Name: Kim

Re: Quoted image as thumbnail

Post by Mess »

Thanks VSE! :)

Post Reply

Return to “Extension Requests”