[ABD] Reputation System

Any abandoned Extensions will be moved to this forum.

WARNING: Extensions in this forum are not currently being supported or maintained by the original Extension author. Proceed at your own risk.
Forum rules
IMPORTANT: Extension Development Forum rules

WARNING: Extensions in this forum are not currently being supported nor updated by the original Extension author. Proceed at your own risk.
User avatar
Pico88
Registered User
Posts: 878
Joined: Sat Mar 07, 2009 10:24 pm
Location: Poland
Name: Lukasz

Re: [DEV] Reputation System

Post by Pico88 » Thu Jul 24, 2014 4:21 am

spello wrote:That table from user profile page is not responsive-friendly. When screen is getting smaller, right table should be moved under left one. It'll look nicer. ;)

Also, I think that "Statistics" could be removed. That's nothing important or interesting and probably not good for server. I don't like them.
It would be better to have overall statistics ranking all users (page listing who has the biggest reputation).

Generally, your extension is awesome ;)
https://github.com/Pico/phpBB-Reputatio ... to-do-list
Please do not PM me for support.

User avatar
wintstar
Registered User
Posts: 280
Joined: Sat Mar 07, 2009 12:39 pm

Re: [DEV] Reputation System

Post by wintstar » Sat Jul 26, 2014 11:49 am

phpBB Build: #1654
Reputation System Version 1.0.0-dev

Get in activated debug detector when creating a new forum following notice:
[phpBB Debug] PHP Notice: in file [ROOT]/ext/pico/reputation/event/listener.php on line 166: Undefined index: reputation_enabled
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions_acp.php on line 111: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3798)
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions_acp.php on line 113: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3798)
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions_acp.php on line 114: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3798)
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions_acp.php on line 115: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3798)

User avatar
Pico88
Registered User
Posts: 878
Joined: Sat Mar 07, 2009 10:24 pm
Location: Poland
Name: Lukasz

Re: [DEV] Reputation System

Post by Pico88 » Sat Jul 26, 2014 12:13 pm

I will check it.

EDIT:
Fixed - link.
Please do not PM me for support.

User avatar
wintstar
Registered User
Posts: 280
Joined: Sat Mar 07, 2009 12:39 pm

Re: [DEV] Reputation System

Post by wintstar » Sat Jul 26, 2014 2:18 pm

Works. Thanks :)

kowal
Registered User
Posts: 6
Joined: Wed May 01, 2013 6:43 am

Re: [DEV] Reputation System

Post by kowal » Sun Jul 27, 2014 9:23 am

Hi Pico88!
Thanks for your great Reputation System!
I tried to use it as an extension. I successfully installed 3.1.0-RC2 vesion of phpbb and your extension. I enabled Reputation System and enabled post rating in all forums, but there are some problems.
It seems everything works well, I see reputation icons. But when I want to rate post - nothing happens.
Image
I click "Rate" button and absolutely nothing happens. No points. I can click "Cancel" button to close window, but "Rate" button does nothing.
What could be the problem :?: :?: :?:
Please advice.
My rating is 0, as you can see on attached picture.
Have a nice day, greetings from Warsaw :)

User avatar
Pico88
Registered User
Posts: 878
Joined: Sat Mar 07, 2009 10:24 pm
Location: Poland
Name: Lukasz

Re: [DEV] Reputation System

Post by Pico88 » Sun Jul 27, 2014 10:06 am

It doesn't work on localhost.

The problem is with symfony_request which checks headers that are required by AJAX request to generate proper links. I don't know why it doesn't work on localhost.


You can modify path_helper.php and use request instead of symfony_request.
Here is my file:

Code: Select all

<?php
/**
*
* This file is part of the phpBB Forum Software package.
*
* @copyright (c) phpBB Limited <https://www.phpbb.com>
* @license GNU General Public License, version 2 (GPL-2.0)
*
* For full copyright and license information, please see
* the docs/CREDITS.txt file.
*
*/

namespace phpbb;

/**
* A class with various functions that are related to paths, files and the filesystem
*/
class path_helper
{
	/** @var \phpbb\symfony_request */
	protected $symfony_request;

	/** @var \phpbb\filesystem */
	protected $filesystem;

	/** @var \phpbb\request\request_interface */
	protected $request;

	/** @var string */
	protected $phpbb_root_path;

	/** @var string */
	protected $adm_relative_path;

	/** @var string */
	protected $php_ext;

	/** @var string */
	protected $web_root_path;

	/**
	* Constructor
	*
	* @param \phpbb\symfony_request $symfony_request
	* @param \phpbb\filesystem $filesystem
	* @param \phpbb\request\request_interface $request
	* @param string $phpbb_root_path Relative path to phpBB root
	* @param string $php_ext PHP extension (php)
	* @param mixed $adm_relative_path Relative path admin path to adm/ root
	*/
	public function __construct(\phpbb\symfony_request $symfony_request, \phpbb\filesystem $filesystem, \phpbb\request\request_interface $request, $phpbb_root_path, $php_ext, $adm_relative_path = null)
	{
		$this->symfony_request = $symfony_request;
		$this->filesystem = $filesystem;
		$this->request = $request;
		$this->phpbb_root_path = $phpbb_root_path;
		$this->php_ext = $php_ext;
		$this->adm_relative_path = $adm_relative_path;
	}

	/**
	* Get the phpBB root path
	*
	* @return string
	*/
	public function get_phpbb_root_path()
	{
		return $this->phpbb_root_path;
	}

	/**
	* Get the adm root path
	*
	* @return string
	*/
	public function get_adm_relative_path()
	{
		return $this->adm_relative_path;
	}

	/**
	* Get the php extension
	*
	* @return string
	*/
	public function get_php_ext()
	{
		return $this->php_ext;
	}

	/**
	* Update a web path to the correct relative root path
	*
	* This replaces $phpbb_root_path . some_url with
	*	get_web_root_path() . some_url
	*
	* @param string $path The path to be updated
	* @return string
	*/
	public function update_web_root_path($path)
	{
		if (strpos($path, $this->phpbb_root_path) === 0)
		{
			$path = substr($path, strlen($this->phpbb_root_path));

			$web_root_path = $this->get_web_root_path();
			if (substr($web_root_path, -8) === 'app.php/' && substr($path, 0, 7) === 'app.php')
			{
				$path = substr($path, 8);
			}

			return $this->filesystem->clean_path($web_root_path . $path);
		}

		return $path;
	}

	/**
	* Strips away the web root path and prepends the normal root path
	*
	* This replaces get_web_root_path() . some_url with
	*	$phpbb_root_path . some_url
	*
	* @param string $path The path to be updated
	* @return string
	*/
	public function remove_web_root_path($path)
	{
		if (strpos($path, $this->get_web_root_path()) === 0)
		{
			$path = substr($path, strlen($this->get_web_root_path()));

			return $this->phpbb_root_path . $path;
		}

		return $path;
	}

	/**
	* Get a relative root path from the current URL
	*
	* @return string
	*/
	public function get_web_root_path()
	{
		if ($this->symfony_request === null)
		{
			return $this->phpbb_root_path;
		}

		if (null !== $this->web_root_path)
		{
			return $this->web_root_path;
		}

		// Path info (e.g. /foo/bar)
		$path_info = $this->filesystem->clean_path($this->symfony_request->getPathInfo());

		// Full request URI (e.g. phpBB/app.php/foo/bar)
		$request_uri = $this->symfony_request->getRequestUri();

		// Script name URI (e.g. phpBB/app.php)
		$script_name = $this->symfony_request->getScriptName();

		/*
		* If the path info is empty but we're using app.php, then we
		*	might be using an empty route like app.php/ which is
		*	supported by symfony's routing
		*/
		if ($path_info === '/' && preg_match('/app\.' . $this->php_ext . '\/$/', $request_uri))
		{
			return $this->web_root_path = $this->filesystem->clean_path('./../' . $this->phpbb_root_path);
		}

		/*
		* If the path info is empty (single /), then we're not using
		*	a route like app.php/foo/bar
		*/
		if ($path_info === '/')
		{
			return $this->web_root_path = $this->phpbb_root_path;
		}

		/*
		* Check AJAX request:
		* If the current request is a AJAX we need to fix the paths.
		* We need to get the root path based on the Referer, so we can use
		* the generated URLs in the template of the Referer. If we do not
		* generate the relative path based on the Referer, but based on the
		* currently requested URL, the generated URLs will not point to the
		* intended locations:
		*	Referer				desired URL			desired relative root path
		*	memberlist.php		faq.php				./
		*	memberlist.php		app.php/foo/bar		./
		*	app.php/foo			memberlist.php		../
		*	app.php/foo			app.php/fox			../
		*	app.php/foo/bar		memberlist.php		../../
		*	../page.php			memberlist.php		./phpBB/
		*	../sub/page.php		memberlist.php		./../phpBB/
		*
		* The referer must be specified as a parameter in the query.
		*/
		if ($this->request->is_ajax() && $this->request->header('Referer'))
		{
			$referer_web_root_path = $this->get_web_root_path_from_ajax_referer(
				$this->request->header('Referer'),
				$this->symfony_request->getSchemeAndHttpHost() . $this->symfony_request->getBasePath()
			);
			return $this->web_root_path = $this->phpbb_root_path . $referer_web_root_path;
		}

		// How many corrections might we need?
		$corrections = substr_count($path_info, '/');

		/*
		* If the script name (e.g. phpBB/app.php) does not exists in the
		* requestUri (e.g. phpBB/app.php/foo/template), then we are rewriting
		* the URL. So we must reduce the slash count by 1.
		*/
		if (strpos($request_uri, $script_name) !== 0)
		{
			$corrections--;
		}

		// Prepend ../ to the phpbb_root_path as many times as / exists in path_info
		$this->web_root_path = $this->filesystem->clean_path(
			'./' . str_repeat('../', $corrections) . $this->phpbb_root_path
		);
		return $this->web_root_path;
	}

	/**
	* Get the web root path of the referer form an ajax request
	*
	* @param string $absolute_referer_url
	* @param string $absolute_board_url
	* @return string
	*/
	public function get_web_root_path_from_ajax_referer($absolute_referer_url, $absolute_board_url)
	{
		// If the board URL is in the beginning of the referer, this means
		// we the referer is in the board URL or a subdirectory of it.
		// So we just need to count the / (slashes) in the left over part of
		// the referer and prepend ../ the the current root_path, to get the
		// web root path of the referer.
		if (strpos($absolute_referer_url, $absolute_board_url) === 0)
		{
			$relative_referer_path = substr($absolute_referer_url, strlen($absolute_board_url));
			$has_params = strpos($relative_referer_path, '?');
			if ($has_params !== false)
			{
				$relative_referer_path = substr($relative_referer_path, 0, $has_params);
			}
			$corrections = substr_count($relative_referer_path, '/');
			return $this->phpbb_root_path . str_repeat('../', $corrections - 1);
		}

		// If not, it's a bit more complicated. We go to the parent directory
		// of the referer until we find the remaining referer in the board URL.
		// Foreach directory we need to add a ../ to the fixed root_path.
		// When we finally found it, we need to remove the remaining referer
		// from the board URL, to get the boards root path.
		// If the then append these two strings, we get our fixed web root path.
		$fixed_root_path = '';
		$referer_dir = $absolute_referer_url;
		$has_params = strpos($referer_dir, '?');
		if ($has_params !== false)
		{
			$referer_dir = substr($referer_dir, 0, $has_params);
		}

		// If we do not find a slash at the end of the referer, we come
		// from a file. So the first dirname() does not need a traversal
		// path correction.
		if (substr($referer_dir, -1) !== '/')
		{
			$referer_dir = dirname($referer_dir);
		}

		while (strpos($absolute_board_url, $referer_dir) !== 0)
		{
			$fixed_root_path .= '../';
			$referer_dir = dirname($referer_dir);
		}

		$fixed_root_path .= substr($absolute_board_url, strlen($referer_dir) + 1);
		// Add trailing slash
		return $this->phpbb_root_path . $fixed_root_path . '/';
	}

	/**
	* Eliminates useless . and .. components from specified URL
	*
	* @param string $url URL to clean
	*
	* @return string Cleaned URL
	*/
	public function clean_url($url)
	{
		$delimiter_position = strpos($url, '://');
		// URL should contain :// but it shouldn't start with it.
		// Do not clean URLs that do not fit these constraints.
		if (empty($delimiter_position))
		{
			return $url;
		}
		$scheme = substr($url, 0, $delimiter_position) . '://';
		// Add length of URL delimiter to position
		$path = substr($url, $delimiter_position + 3);

		return $scheme . $this->filesystem->clean_path($path);
	}

	/**
	* Glue URL parameters together
	*
	* @param array $params URL parameters in the form of array(name => value)
	* @return string Returns the glued string, e.g. name1=value1&name2=value2
	*/
	public function glue_url_params($params)
	{
		$_params = array();

		foreach ($params as $key => $value)
		{
			$_params[] = $key . '=' . $value;
		}
		return implode('&', $_params);
	}

	/**
	* Get the base and parameters of a URL
	*
	* @param string $url URL to break apart
	* @param bool $is_amp Is the parameter separator &. Defaults to true.
	* @return array Returns the base and parameters in the form of array('base' => string, 'params' => array(name => value))
	*/
	public function get_url_parts($url, $is_amp = true)
	{
		$separator = ($is_amp) ? '&' : '&';
		$params = array();

		if (strpos($url, '?') !== false)
		{
			$base = substr($url, 0, strpos($url, '?'));
			$args = substr($url, strlen($base) + 1);
			$args = ($args) ? explode($separator, $args) : array();

			foreach ($args as $argument)
			{
				if (empty($argument))
				{
					continue;
				}
				list($key, $value) = explode('=', $argument, 2);

				if ($key === '')
				{
					continue;
				}

				$params[$key] = $value;
			}
		}
		else
		{
			$base = $url;
		}

		return array(
			'base'		=> $base,
			'params'	=> $params,
		);
	}

	/**
	* Strip parameters from an already built URL.
	*
	* @param string $url URL to strip parameters from
	* @param array|string $strip Parameters to strip.
	* @param bool $is_amp Is the parameter separator &. Defaults to true.
	* @return string Returns the new URL.
	*/
	public function strip_url_params($url, $strip, $is_amp = true)
	{
		$url_parts = $this->get_url_parts($url, $is_amp);
		$params = $url_parts['params'];

		if (!is_array($strip))
		{
			$strip = array($strip);
		}

		if (!empty($params))
		{
			// Strip the parameters off
			foreach ($strip as $param)
			{
				unset($params[$param]);
			}
		}

		return $url_parts['base'] . (($params) ? '?' . $this->glue_url_params($params) : '');
	}

	/**
	* Append parameters to an already built URL.
	*
	* @param string $url URL to append parameters to
	* @param array $new_params Parameters to add in the form of array(name => value)
	* @param bool $is_amp Is the parameter separator &. Defaults to true.
	* @return string Returns the new URL.
	*/
	public function append_url_params($url, $new_params, $is_amp = true)
	{
		$url_parts = $this->get_url_parts($url, $is_amp);
		$params = array_merge($url_parts['params'], $new_params);

		// Move the sid to the end if it's set
		if (isset($params['sid']))
		{
			$sid = $params['sid'];
			unset($params['sid']);
			$params['sid'] = $sid;
		}

		return $url_parts['base'] . (($params) ? '?' . $this->glue_url_params($params) : '');
	}
}
Please do not PM me for support.

nicofuma
3.2 Release Manager
3.2 Release Manager
Posts: 546
Joined: Sun Apr 13, 2014 1:47 am
Location: Grenoble - France

Re: [DEV] Reputation System

Post by nicofuma » Sun Jul 27, 2014 10:35 am

The problem is in the ajax call, you need to add the _referer parameter (https://github.com/phpbb/phpbb/pull/2676 and https://github.com/Nicofuma/phpbb-ext-w ... r.php#L128)
Member of phpBB Development-Team
No Support via PM

kowal
Registered User
Posts: 6
Joined: Wed May 01, 2013 6:43 am

Re: [DEV] Reputation System

Post by kowal » Sun Jul 27, 2014 10:40 am

Pico88 wrote:It doesn't work on localhost.
Thanks for reply.

My installation is on external server, in U.S. for that matter. So the reason must be different.
I wonder if I made some stupid error. I granted all permissions, but maybe I missed something in config.
I'm stack.

Oh, new response, super, I will try now to fix this ajax call, thanks nicofuma

kowal
Registered User
Posts: 6
Joined: Wed May 01, 2013 6:43 am

Re: [DEV] Reputation System

Post by kowal » Sun Jul 27, 2014 1:27 pm

nicofuma wrote:The problem is in the ajax call, you need to add the _referer parameter (https://github.com/phpbb/phpbb/pull/2676 and https://github.com/Nicofuma/phpbb-ext-w ... r.php#L128)
I have installed Nicofuma/webprofiler with _referer parameter in debug_toolbar_listener.php but it changed nothing :cry:
This extension was not present in "original" installation.
I guess I will have to wait for stable version.

nicofuma
3.2 Release Manager
3.2 Release Manager
Posts: 546
Joined: Sun Apr 13, 2014 1:47 am
Location: Grenoble - France

Re: [DEV] Reputation System

Post by nicofuma » Sun Jul 27, 2014 1:39 pm

It's an example to show how to use _referer :p
Member of phpBB Development-Team
No Support via PM

User avatar
Pico88
Registered User
Posts: 878
Joined: Sat Mar 07, 2009 10:24 pm
Location: Poland
Name: Lukasz

Re: [DEV] Reputation System

Post by Pico88 » Sun Jul 27, 2014 2:23 pm

I missed that _referer should be add to url. I don't think it is best solution for that.
Please do not PM me for support.

nicofuma
3.2 Release Manager
3.2 Release Manager
Posts: 546
Joined: Sun Apr 13, 2014 1:47 am
Location: Grenoble - France

Re: [DEV] Reputation System

Post by nicofuma » Sun Jul 27, 2014 3:31 pm

Pico88 wrote:I missed that _referer should be add to url. I don't think it is best solution for that.
It is the best and the only one solution. You need to generate a correct url for the action of the form.
Member of phpBB Development-Team
No Support via PM

User avatar
Pico88
Registered User
Posts: 878
Joined: Sat Mar 07, 2009 10:24 pm
Location: Poland
Name: Lukasz

Re: [DEV] Reputation System

Post by Pico88 » Sun Jul 27, 2014 4:18 pm

Yes, I know. But the url with _referer look awful ;)
Please do not PM me for support.

nicofuma
3.2 Release Manager
3.2 Release Manager
Posts: 546
Joined: Sun Apr 13, 2014 1:47 am
Location: Grenoble - France

Re: [DEV] Reputation System

Post by nicofuma » Sun Jul 27, 2014 4:36 pm

But you don't care.... the user will never see this url, it's used only with ajax.
Member of phpBB Development-Team
No Support via PM

User avatar
Pico88
Registered User
Posts: 878
Joined: Sat Mar 07, 2009 10:24 pm
Location: Poland
Name: Lukasz

Re: [DEV] Reputation System

Post by Pico88 » Sun Jul 27, 2014 4:46 pm

I can be see when JS is disabled ;)
Please do not PM me for support.

Locked

Return to “Abandoned Extensions”