[ABD] Trader extension

[cools]

Done, that was an absolute pig to do all things considered.

I said I'd take a look at the shmk feedback porting code and it looks to be straightforward. I've no idea how to put it into php though, once I'm done with it I'll hand the SQL over.

[Galixte de EzCom]

Hi rfdy,

I have submit three PR on GitHub for you:

https://github.com/rfdy/trader/pull/9 - files changed: https://github.com/rfdy/trader/pull/9/files
https://github.com/rfdy/trader/pull/10 - files changed: https://github.com/rfdy/trader/pull/10/files
https://github.com/rfdy/trader/pull/11 - files changed: https://github.com/rfdy/trader/pull/11/files

[huddy]

I followed your instruction, but when I copy the trader.git file to the ext/rfd, the extension is not shown in the extension manager in admin control panel. What am I doing wrong here ?

I get the same issue..

Any news on this?

[Mattix]

You should download the actual extension files, not the trader.git

https://github.com/rfdy/trader

[FoFa]

Hello,

Is it easy adding new items ?

We have BUYING --- SELLING --- TRADING

My idea is to add something like "Change". Do I understand how adding new item would allow me adding later more item.

Thanks

[zpintar]

Hello rfdy,

Very nice extension, but I found a bug when showing Latin2 characters like čćšđž. Instead of them I've got only question marks.

In a near future I'm planning to translate your extension in Croatian

[rfdy]

We are preparing to make the first stable release with the languages on github.

Any language additions must be submitted via a github pull request.

Thanks!

[zpintar]

We are preparing to make the first stable release with the languages on github.

Any language additions must be submitted via a github pull request.

Thanks!

OK, and what with latin2 characters bug?

[zpintar]

We are preparing to make the first stable release with the languages on github.

Any language additions must be submitted via a github pull request.

Thanks!

OK, and what with latin2 characters bug?

Forget it. Now I see that Galixte de EzCo resolved this on Github pull request.

[Galixte de EzCom]

Hi,

yeah and all my PRs on Github have been merged except those: https://github.com/rfdy/trader/pull/11# ... t-92956831 and i would to know why ?

Also, there are still missing four language keys: https://github.com/rfdy/trader/issues/12

[zpintar]

Hi,

yeah and all my PRs on Github have been merged except those: https://github.com/rfdy/trader/pull/11# ... t-92956831 and i would to know why ?

Also, there are still missing four language keys: https://github.com/rfdy/trader/issues/12

Hmmm, and why they didn't??

[Galixte de EzCom]

It's to rfdy or Dhruvit Gandhi (author of the merging on GitHub) to respond to this question.

[rfdy]

Galixte de EzCom,

We're looking into your concerns right now.

If you have some time to test, you might be able to give us an idea if you believe we should tag it as an RC release.

Thanks for your patients!

[Galixte de EzCom]

I have tested your extension during the past two months and all I found was submitted to you, unless three last problems that I have to submit to you on GitHub.

For the status of your development it's not to me to say if is an RC or Beta it's for you to say.

EDIT :

1. New recommendation added here: https://github.com/rfdy/trader/pull/11# ... t-93425192
2. Previous PR is not totally merged, see that: https://github.com/rfdy/trader/pull/11# ... t-92956831 => FIXED here & here
3. New PR added here:
   • https://github.com/rfdy/trader/pull/19 => REPLACED WITH: https://github.com/rfdy/trader/pull/30,
   • https://github.com/rfdy/trader/pull/22 => REPLACED WITH: https://github.com/rfdy/trader/pull/30,
4. Previous issue without fix : https://github.com/rfdy/trader/issues/12 => IN PART FIXED here & here => FULLY FIXED: https://github.com/rfdy/trader/pull/30.
5. New issues added here:
   1. https://github.com/rfdy/trader/issues/14 => NO PROBLEM,
   2. https://github.com/rfdy/trader/issues/16,
   3. https://github.com/rfdy/trader/issues/17,
   4. https://github.com/rfdy/trader/issues/18,
   5. https://github.com/rfdy/trader/issues/20 => REPLACED WITH: https://github.com/rfdy/trader/pull/30,
   6. https://github.com/rfdy/trader/issues/23 => NO PROBLEM.

If i could to say, but i'm not a developer it's in "-dev" status not Beta or RC ... but i'm not a developer.

------------

Follow to the next issues here: viewtopic.php?f=456&t=2250501&p=14109416#p14109416.

[leschek]

Nice improvement over last few months. I tested it and found some issues:

1. After sending a feedback I can see message:
   

   Code: Select all

   [phpBB Debug] PHP Notice: in file [ROOT]/ext/rfd/trader/Controller/Trader.php on line 154: Undefined index: short
   [phpBB Debug] PHP Notice: in file [ROOT]/ext/rfd/trader/Controller/Trader.php on line 154: Undefined index: long

2. If in feedback are some non English characters, they are shown as question marks in feedback - I think this was reported before.
3. In miniprofile (in topic) when I hover over "Trader Score" link it shows counts of positive/neutral/negative feedback. Neutral feedback is 0 even if user has a few neutral feedbacks.
4. Language file:
   1. 'PAST' => 'Past',
      '6_MONTHS' => '6 Months',
      '12_MONTHS' => '12 Months',
      In some languages can form of word before number depend on number after it. For example we say: Poslední měsíc (past month) and posledních 6 měsíců (past 6 months).
   2. From in feedback table (column name) - it seems it is word from core phpBB. In my language the word From could be translated as a few diferent words, so it would be better to add it to extension's language file and not use core language variable.
   3. Date in feedback table (column name) - Word Date is missing in language file
   4. 'X_FEEDBACK' => 'feedback',
'X_FEEDBACKS' => 'feedbacks',
      I believe those should be written as array plural.