[ABD] Trader extension

Any abandoned Extensions will be moved to this forum.

WARNING: Extensions in this forum are not currently being supported or maintained by the original Extension author. Proceed at your own risk.
Forum rules
IMPORTANT: Extension Development Forum rules

WARNING: Extensions in this forum are not currently being supported nor updated by the original Extension author. Proceed at your own risk.
Locked
cools
Registered User
Posts: 20
Joined: Wed Dec 24, 2008 6:20 pm

Re: [BETA] Trader extension

Post by cools » Fri Mar 06, 2015 3:22 pm

Done, that was an absolute pig to do all things considered.

I said I'd take a look at the shmk feedback porting code and it looks to be straightforward. I've no idea how to put it into php though, once I'm done with it I'll hand the SQL over.

User avatar
Galixte de EzCom
Registered User
Posts: 1041
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: [BETA] Trader extension

Post by Galixte de EzCom » Mon Mar 09, 2015 6:44 am

Communau EzCom
📖 « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
📋 Lists of all extensions identified for phpBB 3.1.x & 3.2.x.
📋 Lists of all styles identified for phpBB 3.1.x & 3.2.x.
Image Tu as un forum et tu veux aussi un site web ? Regarde par ici.

huddy
Registered User
Posts: 163
Joined: Fri Feb 21, 2014 12:21 pm
Location: Chelmsford UK
Contact:

Re: [BETA] Trader extension

Post by huddy » Wed Mar 11, 2015 9:40 am

pattex007 wrote:I followed your instruction, but when I copy the trader.git file to the ext/rfd, the extension is not shown in the extension manager in admin control panel. What am I doing wrong here ?

I get the same issue..

Any news on this?

Mattix
Registered User
Posts: 25
Joined: Sat Oct 25, 2014 7:00 pm

Re: [BETA] Trader extension

Post by Mattix » Wed Mar 11, 2015 5:18 pm

You should download the actual extension files, not the trader.git

https://github.com/rfdy/trader

:)

User avatar
FoFa
Registered User
Posts: 200
Joined: Wed Dec 03, 2008 9:21 am
Name: Daniel L.
Contact:

Re: [BETA] Trader extension

Post by FoFa » Wed Mar 11, 2015 10:57 pm

Hello,

Is it easy adding new items ?

We have BUYING --- SELLING --- TRADING

My idea is to add something like "Change". Do I understand how adding new item would allow me adding later more item.

Thanks
Formly ForumsFaciles :wink:

User avatar
zpintar
Registered User
Posts: 30
Joined: Fri Jan 18, 2013 8:51 am
Location: Croatia
Name: Žarko Pintar
Contact:

Re: [BETA] Trader extension

Post by zpintar » Mon Apr 13, 2015 6:45 am

Hello rfdy,

Very nice extension, but I found a bug when showing Latin2 characters like čćšđž. Instead of them I've got only question marks.

In a near future I'm planning to translate your extension in Croatian ;)

User avatar
rfdy
Registered User
Posts: 55
Joined: Wed Apr 16, 2014 1:37 pm

Re: [BETA] Trader extension

Post by rfdy » Tue Apr 14, 2015 1:34 pm

We are preparing to make the first stable release with the languages on github.

Any language additions must be submitted via a github pull request.

Thanks!

User avatar
zpintar
Registered User
Posts: 30
Joined: Fri Jan 18, 2013 8:51 am
Location: Croatia
Name: Žarko Pintar
Contact:

Re: [BETA] Trader extension

Post by zpintar » Wed Apr 15, 2015 7:01 am

rfdy wrote:We are preparing to make the first stable release with the languages on github.

Any language additions must be submitted via a github pull request.

Thanks!
OK, and what with latin2 characters bug?

User avatar
zpintar
Registered User
Posts: 30
Joined: Fri Jan 18, 2013 8:51 am
Location: Croatia
Name: Žarko Pintar
Contact:

Re: [BETA] Trader extension

Post by zpintar » Wed Apr 15, 2015 8:49 am

zpintar wrote:
rfdy wrote:We are preparing to make the first stable release with the languages on github.

Any language additions must be submitted via a github pull request.

Thanks!
OK, and what with latin2 characters bug?
Forget it. Now I see that Galixte de EzCo resolved this on Github pull request. :)

User avatar
Galixte de EzCom
Registered User
Posts: 1041
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: [BETA] Trader extension

Post by Galixte de EzCom » Wed Apr 15, 2015 10:08 am

Hi,

yeah and all my PRs on Github have been merged except those: https://github.com/rfdy/trader/pull/11# ... t-92956831 and i would to know why ?

Also, there are still missing four language keys: https://github.com/rfdy/trader/issues/12
Communau EzCom
📖 « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
📋 Lists of all extensions identified for phpBB 3.1.x & 3.2.x.
📋 Lists of all styles identified for phpBB 3.1.x & 3.2.x.
Image Tu as un forum et tu veux aussi un site web ? Regarde par ici.

User avatar
zpintar
Registered User
Posts: 30
Joined: Fri Jan 18, 2013 8:51 am
Location: Croatia
Name: Žarko Pintar
Contact:

Re: [BETA] Trader extension

Post by zpintar » Wed Apr 15, 2015 10:13 am

Galixte de EzCom wrote:Hi,

yeah and all my PRs on Github have been merged except those: https://github.com/rfdy/trader/pull/11# ... t-92956831 and i would to know why ?

Also, there are still missing four language keys: https://github.com/rfdy/trader/issues/12

Hmmm, and why they didn't??

User avatar
Galixte de EzCom
Registered User
Posts: 1041
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: [BETA] Trader extension

Post by Galixte de EzCom » Wed Apr 15, 2015 11:41 am

It's to rfdy or Dhruvit Gandhi (author of the merging on GitHub) to respond to this question.
Communau EzCom
📖 « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
📋 Lists of all extensions identified for phpBB 3.1.x & 3.2.x.
📋 Lists of all styles identified for phpBB 3.1.x & 3.2.x.
Image Tu as un forum et tu veux aussi un site web ? Regarde par ici.

User avatar
rfdy
Registered User
Posts: 55
Joined: Wed Apr 16, 2014 1:37 pm

Re: [BETA] Trader extension

Post by rfdy » Wed Apr 15, 2015 1:37 pm

Galixte de EzCom,

We're looking into your concerns right now.

If you have some time to test, you might be able to give us an idea if you believe we should tag it as an RC release.

Thanks for your patients! :)

User avatar
Galixte de EzCom
Registered User
Posts: 1041
Joined: Mon Oct 04, 2004 11:14 pm
Location: France
Name: Raphaël M.
Contact:

Re: [BETA] Trader extension

Post by Galixte de EzCom » Wed Apr 15, 2015 2:17 pm

I have tested your extension during the past two months and all I found was submitted to you, unless three last problems that I have to submit to you on GitHub.

For the status of your development it's not to me to say if is an RC or Beta it's for you to say.

EDIT :
  1. New recommendation added here: https://github.com/rfdy/trader/pull/11# ... t-93425192
  2. Previous PR is not totally merged, see that: https://github.com/rfdy/trader/pull/11# ... t-92956831 => FIXED here & here
  3. New PR added here:
  4. Previous issue without fix : https://github.com/rfdy/trader/issues/12 => IN PART FIXED here & here => FULLY FIXED: https://github.com/rfdy/trader/pull/30.
  5. New issues added here:
    1. https://github.com/rfdy/trader/issues/14 => NO PROBLEM,
    2. https://github.com/rfdy/trader/issues/16,
    3. https://github.com/rfdy/trader/issues/17,
    4. https://github.com/rfdy/trader/issues/18,
    5. https://github.com/rfdy/trader/issues/20 => REPLACED WITH: https://github.com/rfdy/trader/pull/30,
    6. https://github.com/rfdy/trader/issues/23 => NO PROBLEM.
If i could to say, but i'm not a developer it's in "-dev" status not Beta or RC ... but i'm not a developer.

------------

Follow to the next issues here: viewtopic.php?f=456&t=2250501&p=14109416#p14109416.
Last edited by Galixte de EzCom on Sat Sep 05, 2015 3:10 pm, edited 17 times in total.
Communau EzCom
📖 « Traductions d’extensions & styles pour phpBB 3.1.x & 3.2.x ».
📋 Lists of all extensions identified for phpBB 3.1.x & 3.2.x.
📋 Lists of all styles identified for phpBB 3.1.x & 3.2.x.
Image Tu as un forum et tu veux aussi un site web ? Regarde par ici.

leschek
Registered User
Posts: 789
Joined: Tue Jul 18, 2006 12:49 pm
Contact:

Re: [BETA] Trader extension

Post by leschek » Wed Apr 15, 2015 2:41 pm

Nice improvement over last few months. I tested it and found some issues:
  1. After sending a feedback I can see message:

    Code: Select all

    [phpBB Debug] PHP Notice: in file [ROOT]/ext/rfd/trader/Controller/Trader.php on line 154: Undefined index: short
    [phpBB Debug] PHP Notice: in file [ROOT]/ext/rfd/trader/Controller/Trader.php on line 154: Undefined index: long
  2. If in feedback are some non English characters, they are shown as question marks in feedback - I think this was reported before.
  3. In miniprofile (in topic) when I hover over "Trader Score" link it shows counts of positive/neutral/negative feedback. Neutral feedback is 0 even if user has a few neutral feedbacks.
  4. Language file:
    1. 'PAST' => 'Past',
      '6_MONTHS' => '6 Months',
      '12_MONTHS' => '12 Months',
      In some languages can form of word before number depend on number after it. For example we say: Poslední měsíc (past month) and posledních 6 měsíců (past 6 months).
    2. From in feedback table (column name) - it seems it is word from core phpBB. In my language the word From could be translated as a few diferent words, so it would be better to add it to extension's language file and not use core language variable.
    3. Date in feedback table (column name) - Word Date is missing in language file
    4. 'X_FEEDBACK' => 'feedback',
      'X_FEEDBACKS' => 'feedbacks',

      I believe those should be written as array plural.

Locked

Return to “Abandoned Extensions”