[ABD] Upload Style

Any abandoned Extensions will be moved to this forum.

WARNING: Extensions in this forum are not currently being supported or maintained by the original Extension author. Proceed at your own risk.
Forum rules
IMPORTANT: Extension Development Forum rules

WARNING: Extensions in this forum are not currently being supported nor updated by the original Extension author. Proceed at your own risk.
User avatar
John P
Registered User
Posts: 1237
Joined: Mon Jan 21, 2008 3:55 pm
Location: Netherlands
Name: John
Contact:

[ABD] Upload Style

Post by John P » Thu Oct 09, 2014 7:30 pm

Description: Upload Styles enables you to upload styles' zip files or delete styles' folders from the server.
With this extension you can install/update/delete styles without using FTP. If the uploaded style already exists, it will be updated with the uploaded files. Zip files are unpacked and placed in the styles folder.

Requirements:
  • phpBB 3.1-dev or higher
  • PHP 5.3.3 or higher
Repository: https://github.com/ForumHulp/uploadstyle
Installation:
  • Copy the entire contents of the repository to ext/forumhulp/uploadstyle/
  • Navigate in ACP to Customize -> Extension Management -> Extensions.
  • Click Enable.
Picture:
upload_styles.jpg
Extension Upload Style
upload_styles.jpg (77.93 KiB) Viewed 2056 times
Last edited by John P on Fri Oct 10, 2014 8:20 pm, edited 1 time in total.
Image
Webhosting, Custom MODs, Technical management, MOD installation and Webdesign

User avatar
PayBas
Former Team Member
Posts: 930
Joined: Thu May 25, 2006 12:37 am

Re: [DEV] Upload Style

Post by PayBas » Thu Oct 09, 2014 8:22 pm

Very nice ;).

Keep in mind that in the future, there will be styles with multiple related styles (variants).

So one zip/gzip/7z might include 5 styles (default, red version, blue version, green version, etc.)

User avatar
John P
Registered User
Posts: 1237
Joined: Mon Jan 21, 2008 3:55 pm
Location: Netherlands
Name: John
Contact:

Re: [DEV] Upload Style

Post by John P » Thu Oct 09, 2014 9:53 pm

Thanks Paybas,

I'm wondering if phpBB will unpack gzip, never tried.
Image
Webhosting, Custom MODs, Technical management, MOD installation and Webdesign

User avatar
PayBas
Former Team Member
Posts: 930
Joined: Thu May 25, 2006 12:37 am

Re: [DEV] Upload Style

Post by PayBas » Thu Oct 09, 2014 10:43 pm

While we're at it.

If you really want to make this extension awesome, you could try to detect if a style inherits from another style, and throw a warning if that style hasn't been uploaded yet ;). Although the ACP won't allow you to install it anyway. Just an idea.

Too bad we didn't get around to https://tracker.phpbb.com/browse/PHPBB3-10824 before 3.1

User avatar
John P
Registered User
Posts: 1237
Joined: Mon Jan 21, 2008 3:55 pm
Location: Netherlands
Name: John
Contact:

Re: [DEV] Upload Style

Post by John P » Fri Oct 10, 2014 5:13 am

It knows if the style inherits, and colors red in the list. It also knows the phpbb version and won't let you upload the new style if they don't match.
Image
Webhosting, Custom MODs, Technical management, MOD installation and Webdesign

User avatar
PayBas
Former Team Member
Posts: 930
Joined: Thu May 25, 2006 12:37 am

Re: [DEV] Upload Style

Post by PayBas » Fri Oct 10, 2014 8:24 am

John P wrote:It knows if the style inherits, and colors red in the list. It also knows the phpbb version and won't let you upload the new style if they don't match.
Very nice. Hadn't actually tried it yet ;).

User avatar
John P
Registered User
Posts: 1237
Joined: Mon Jan 21, 2008 3:55 pm
Location: Netherlands
Name: John
Contact:

Re: [DEV] Upload Style

Post by John P » Fri Oct 10, 2014 8:40 pm

You couldn't, just put the files on GIT :D
Image
Webhosting, Custom MODs, Technical management, MOD installation and Webdesign

Skhilled44
Registered User
Posts: 21
Joined: Wed Mar 26, 2014 12:29 pm

Re: [DEV] Upload Style

Post by Skhilled44 » Sat Oct 11, 2014 1:02 pm

Been waiting for this! Thanks! :D

User avatar
Mauron
Registered User
Posts: 342
Joined: Wed Jul 16, 2014 11:25 am

EXT_UPLOAD_ERROR

Post by Mauron » Fri Oct 24, 2014 1:54 pm

Hi,
I tried to upload the theme Prosilver SE (already installed) to update it and I got the following error:

Code: Select all

[phpBB Debug] PHP Warning: in file [ROOT]/ext/forumhulp/uploadstyle/acp/uploadstyle_module.php on line 603: Missing argument 2 for forumhulp/uploadstyle/acp/uploadstyle_module::trigger_error(), called in [ROOT]/ext/forumhulp/uploadstyle/acp/uploadstyle_module.php on line 130 and defined
Moreover, EXT_UPLOAD_ERROR appeared in a red square in the page.

User avatar
John P
Registered User
Posts: 1237
Joined: Mon Jan 21, 2008 3:55 pm
Location: Netherlands
Name: John
Contact:

Re: [DEV] Upload Style

Post by John P » Fri Oct 24, 2014 5:23 pm

Thanks Mauron for debugging.

Should be solved in a minute
Image
Webhosting, Custom MODs, Technical management, MOD installation and Webdesign

leschek
Registered User
Posts: 789
Joined: Tue Jul 18, 2006 12:49 pm
Contact:

Re: [DEV] Upload Style

Post by leschek » Tue Oct 28, 2014 11:06 am

Useful extension.
It seems that in language file upload.php is maybe redundant line:

Code: Select all

	'STYLE_UPLOAD_ERROR'				=> 'The style wasn\'t uploaded. Please confirm that you upload the true style zip file and try again.',
	'EXT_UPLOAD_ERROR'					=> 'The style wasn\'t uploaded. Please confirm that you upload the true style zip file and try again.',

User avatar
John P
Registered User
Posts: 1237
Joined: Mon Jan 21, 2008 3:55 pm
Location: Netherlands
Name: John
Contact:

Re: [DEV] Upload Style

Post by John P » Tue Oct 28, 2014 11:14 am

You are right, copy & paste problem.

So we have to solve it, thanks for reporting
Image
Webhosting, Custom MODs, Technical management, MOD installation and Webdesign

leschek
Registered User
Posts: 789
Joined: Tue Jul 18, 2006 12:49 pm
Contact:

Re: [DEV] Upload Style

Post by leschek » Tue Oct 28, 2014 1:20 pm

I found another small things, sorry. In adm/style/acp_upload.html are some hard coded language lines:

Code: Select all

<!-- IF .authors -->
		<br />Authors:
		<!-- BEGIN authors -->
This one ↑ is also in "Upload extension" extension

Default style

Code: Select all

<tr onmouseover="this.className='ruleractueel';" onmouseout="this.className='column';" class="column"<!-- IF styles_list.COMMENT --> style="color:red;" title="{styles_list.COMMENT}"<!-- ENDIF --><!-- IF styles_list.DEFAULT -->title="Default style"<!-- ENDIF -->>
Sellect all

Code: Select all

<div id="filecontent"><div class="filename">{FILENAME} <a href="#" onclick="selectCode(this); return false;" style="float:right;font-size:8px;margin: 5px 15px 1px 0;">Select all</a></div><div class="filecontent">{CONTENT}</div></div>

User avatar
John P
Registered User
Posts: 1237
Joined: Mon Jan 21, 2008 3:55 pm
Location: Netherlands
Name: John
Contact:

Re: [DEV] Upload Style

Post by John P » Tue Oct 28, 2014 2:07 pm

You are a real debugger, please continue :)
Image
Webhosting, Custom MODs, Technical management, MOD installation and Webdesign

User avatar
draky
Registered User
Posts: 247
Joined: Tue Dec 10, 2002 2:04 pm
Location: France
Name: Gilles W.
Contact:

Re: [DEV] Upload Style

Post by draky » Wed Oct 29, 2014 8:53 am

Is it the same "base code" than your Ext Upload ?
Because it stats here :
NOTE: Some servers (for example, github.com) don't support remote uploads.
Because in your other great extension, GitHub is working :)

So... are GitHub links for styles working ?

Locked

Return to “Abandoned Extensions”