[ABD] s9e/mediaembed - Embed videos and third-party content without a single BBCode

JoshyPHP · Post by **JoshyPHP** » Fri Oct 23, 2015 7:57 pm

poenn wrote:Is it possible to disable some of its supported sites?

It's not possible, sorry. If you want to post a link without it being transformed you can use the URL BBCode and it shouldn't be replaced with an embedded product.

poenn · Post by **poenn** » Fri Oct 23, 2015 8:01 pm

Thanks, I could do that, but it’s next to impossible to educate all users to not just paste the link into the post like they’re used to. There were already a few occurrences with threads of confused users which were unaware that their adblockers prevented them to see the links, be it from other users or even from themselves.

I wouldn’t have a problem with editing a config file and even doing it again with every update would be ok. Would this be possible or is it completely hardcoded?

JoshyPHP · Post by **JoshyPHP** » Fri Oct 23, 2015 8:58 pm

Then you can edit listener.php, look around line 88 and insert the following before $xml = MediaPack::parse($m[1]);

Code: Select all

if (!isset(MediaPack::$parser))
{
    MediaPack::$parser = MediaPack::getParser();
}
MediaPack::$parser->disableTag('AMAZON');

poenn · Post by **poenn** » Fri Oct 23, 2015 9:00 pm

Thanks, you are great! Will do so tomorrow morning and let you know.

2600 · Post by **2600** » Sat Oct 24, 2015 10:27 am

In the bundle.php Amazon is listed there, but I'm not sure how to modify with breaking the code.

JoshyPHP · Post by **JoshyPHP** » Sat Oct 24, 2015 11:20 am

I've just uploaded an update: https://github.com/s9e/phpbb-ext-mediae ... 151024.zip

In this version, if you want to disable a site by editing the source, you'll have to replace line 88 with the following:

Code: Select all

MediaPack::getCachedParser()->disableTag('AMAZON');
$xml = MediaPack::parse($m[1]);

With that said, this is not a method that I can support.

John connor wrote:In the bundle.php Amazon is listed there, but I'm not sure how to modify with breaking the code.

As I posted above, it's possible to edit listener.php (not bundle.php) but you should not edit any file if you're not sure.

poenn · Post by **poenn** » Sat Oct 24, 2015 1:14 pm

Thanks a lot for your support, JoshyPHP,

I tried with the updated version from github right from the start, but it does not work. Amazon URLs are still shown with images and buy buttons and therefore blocked if AdBlock is enabled.

Here’s an excerpt from listener.php, lines 84 to 94, with the changes not indented:

Code: Select all

		return preg_replace_callback(
			'(<!-- m -->.*?href="([^"]+).*?<!-- m -->)',
			function ($m)
			{
MediaPack::getCachedParser()->disableTag('AMAZON');
$xml = MediaPack::parse($m[1]); 
				return ($xml[1] === 'r')
					? '<!-- s9e:mediaembed:' . base64_encode($xml) . ' -->' . $m[0]
					: $m[0];
			},
			$text

Did I mess up somewhere? I double-checked the changes, emptied the phphBB cache and even disabled/enabled the extension, just to make sure.

JoshyPHP · Post by **JoshyPHP** » Sat Oct 24, 2015 1:24 pm

I should mention this does not apply retroactively. You'd have to edit/reparse old posts for that.

poenn · Post by **poenn** » Sat Oct 24, 2015 1:31 pm

Ah, thanks. Got it! I was under the impression that it was retroactive. Thanks again for your outstanding support!

Difadon · Post by **Difadon** » Fri Nov 06, 2015 3:33 pm

Hello,

Maybe is greaf if you add acp control (for allow/disable websites).

You can add support for some czech webpage?

http://aukro.cz
http://stream.cz

Next page for support:
https://www.facebook.com/groups/1646523375626923/
https://www.facebook.com/Difadon

Swen · Post by **Swen** » Fri Nov 06, 2015 5:47 pm

Amazing. Thanks for that. Go ahead with development!

Pond Life · Post by **Pond Life** » Sat Nov 07, 2015 2:52 am

JoshyPHP wrote:I've just uploaded an update: https://github.com/s9e/phpbb-ext-mediae ... 151024.zip

In this version, if you want to disable a site by editing the source, you'll have to replace line 88 with the following:
Code: Select all
MediaPack::getCachedParser()->disableTag('AMAZON');
$xml = MediaPack::parse($m[1]); 

What would the correct syntax be for disabling more than one site? For example, if I wanted to disable amazon, facebook and foxnews?

JoshyPHP · Post by **JoshyPHP** » Sat Nov 07, 2015 8:55 am

Difadon wrote:Maybe is greaf if you add acp control (for allow/disable websites).

That would require more work than I can provide at the moment. To be honest, unless someone wants to sponsor its development I don't think I'll ever have time to create a UI for this extension.

Difadon wrote:You can add support for some czech webpage?

Sorry, I have to focus only on the most popular sites at the moment.

Pond Life wrote:What would the correct syntax be for disabling more than one site? For example, if I wanted to disable amazon, facebook and foxnews?

Just repeat the first line for each site.

Code: Select all

MediaPack::getCachedParser()->disableTag('FACEBOOK');
MediaPack::getCachedParser()->disableTag('FOXNEWS');

Pond Life · Post by **Pond Life** » Sat Nov 07, 2015 3:17 pm

JoshyPHP wrote:Just repeat the first line for each site.
Code: Select all
MediaPack::getCachedParser()->disableTag('FACEBOOK');
MediaPack::getCachedParser()->disableTag('FOXNEWS');

Thank you.

Spaldo · Post by **Spaldo** » Fri Nov 13, 2015 2:03 am

Hi, I have updated from phpbb 3.0 to 3.1

In doing so, I have switched over to this new extension and it is great.

However, I was wondering if anyone has suggestions for how I can deal with all the old threads with the [video] phpbb code?

I would like these videos to be displayed with the old code, but, it isn't working at the moment with the code wrapped around the link.

Thanks

advertisements