[RC] Hide BBcode

Any abandoned Extensions will be moved to this forum.

WARNING: Extensions in this forum are not currently being supported or maintained by the original Extension author. Proceed at your own risk.
Forum rules
IMPORTANT: Extension Development Forum rules

WARNING: Extensions in this forum are not currently being supported nor updated by the original Extension author. Proceed at your own risk.
marcovo
Registered User
Posts: 239
Joined: Fri Nov 16, 2012 12:19 pm
Location: The Netherlands
Name: Marco

Re: [DEV] Hide BBcode

Post by marcovo » Wed Jun 24, 2015 6:43 am

I'm sorry; my study does not go as well as planned. I imagined that during my last project I could also test the last things for this extension but sadly this is not the case. The deadline is July 1st so I really hope to finish this next week.
Surely there should not be any obstacles any more, since we indeed already arrived at 3.1.5 .
Arabic translation merged :) .

infinitiv
Registered User
Posts: 166
Joined: Sat Nov 15, 2014 3:47 pm
Location: PL
Name: Ficjusz

Re: [DEV] Hide BBcode

Post by infinitiv » Thu Jun 25, 2015 10:39 pm

So does 3.1.5 adds necessary events?

marcovo
Registered User
Posts: 239
Joined: Fri Nov 16, 2012 12:19 pm
Location: The Netherlands
Name: Marco

Re: [DEV] Hide BBcode

Post by marcovo » Fri Jun 26, 2015 7:35 am

I guess 3.1.4 added the necessary event.

FomenkoAndrey
Registered User
Posts: 367
Joined: Thu Aug 19, 2010 10:44 am

Re: [DEV] Hide BBcode

Post by FomenkoAndrey » Fri Jun 26, 2015 8:46 am

and?... any progress?

Miri4ever
Registered User
Posts: 409
Joined: Sat Mar 07, 2015 11:18 am

Re: [DEV] Hide BBcode

Post by Miri4ever » Fri Jun 26, 2015 9:41 am

I've added mine since 3.1.3 and still working great.
Homepage: Terra Oceanica

infinitiv
Registered User
Posts: 166
Joined: Sat Nov 15, 2014 3:47 pm
Location: PL
Name: Ficjusz

Re: [DEV] Hide BBcode

Post by infinitiv » Fri Jun 26, 2015 10:06 am

marcovo wrote:I guess 3.1.4 added the necessary event.
So it means that core edits won't be mandatory. I'm looking forward for the new version even harder.

And, bro...
FomenkoAndrey wrote:and?... any progress?
marcovo wrote:The deadline is July 1st (...).
Be patient.

marcovo
Registered User
Posts: 239
Joined: Fri Nov 16, 2012 12:19 pm
Location: The Netherlands
Name: Marco

Re: [DEV] Hide BBcode

Post by marcovo » Fri Jun 26, 2015 6:02 pm

I found some time this evening, I replaced the old temporary event by the official phpBB event. See also the latest commit on the github page.

Unfortunately I forgot that also 'draft_id', was added as temporary variable in the phpBB files, which has not been added yet to the official phpBB. Anyways, for now that one line is the only edit thats needed. Without it, your drafts will be censored if you load them back into your posting-page. The extra variable makes sure that your draft will be shown exactly as you saved it.

Also see the first post.

Miri4ever
Registered User
Posts: 409
Joined: Sat Mar 07, 2015 11:18 am

Re: [DEV] Hide BBcode

Post by Miri4ever » Fri Jun 26, 2015 10:56 pm

Updated and saved my german translation for this ext:

Code: Select all

	'HIDEBB_HIDDEN_MESSAGE'	=>	'Diese Nachricht wurde versteckt',
	'HIDEBB_MESSAGE_UNHIDE'	=>	'Versteckte Nachricht: Aus',
	'HIDEBB_MESSAGE_HIDDEN'	=>	'Versteckte Nachricht: An',
	'HIDEBB_MESSAGE_HIDDEN_DESCRIPTION'	=>	'Sie müssen auf diesen Beitrag antworten um die versteckte Nachricht lesen zu können.',
Homepage: Terra Oceanica

marcovo
Registered User
Posts: 239
Joined: Fri Nov 16, 2012 12:19 pm
Location: The Netherlands
Name: Marco

Re: [DEV] Hide BBcode

Post by marcovo » Sat Jun 27, 2015 7:46 am

German language is now included, thanks :) .

infinitiv
Registered User
Posts: 166
Joined: Sat Nov 15, 2014 3:47 pm
Location: PL
Name: Ficjusz

Re: [DEV] Hide BBcode

Post by infinitiv » Sat Jun 27, 2015 9:53 am

Here goes basic Polish (pl) translation. Haven't been testing this ext in 3.1.5, so expect some tweaks, but as for now:

Code: Select all

	'HIDEBB_HIDDEN_MESSAGE'	=>	'Treść została ukryta',
	'HIDEBB_MESSAGE_UNHIDE'	=>	'Ukrywanie treści: wyłączone',
	'HIDEBB_MESSAGE_HIDDEN'	=>	'Ukrywanie treści: włączone',
	'HIDEBB_MESSAGE_HIDDEN_DESCRIPTION'	=>	'Aby zobaczyć ukrytą treść, musisz odpisać w tym temacie.',
UTF-8 is highly recommended.

marcovo
Registered User
Posts: 239
Joined: Fri Nov 16, 2012 12:19 pm
Location: The Netherlands
Name: Marco

Re: [DEV] Hide BBcode

Post by marcovo » Sat Jun 27, 2015 10:50 am

Thanks infinitiv, I will include it later. (EDIT 29-06 12:22 : Polish translation has been added)

For now, I've just made a pull request to phpBB to include the draft_id into the main code:
https://github.com/phpbb/phpbb/pull/3731
If this is merged, the extension may be 100% extension-ish when phpBB 3.1.6 comes out.

marcovo
Registered User
Posts: 239
Joined: Fri Nov 16, 2012 12:19 pm
Location: The Netherlands
Name: Marco

Re: [BETA] Hide BBcode

Post by marcovo » Tue Jun 30, 2015 12:07 pm

I made a change to the code that allows you to use the extension without any core modifications. This fix does break however, if another extension modifies the $draft_id on posting.php, but I guess not many extensions will do so. Anyways, if the pull request is accepted into phpBB 3.1.6, this break will be fixed.

I will now be doing some final tests, after which I will look into submitting the extension into the customisation database. For now, the extension has been promoted to Beta stage :) .

Do note that today I've changed the extension-name from hide_bbcode to hideBBcode, in compliance with the coding guidelines.

FomenkoAndrey
Registered User
Posts: 367
Joined: Thu Aug 19, 2010 10:44 am

Re: [BETA] Hide BBcode

Post by FomenkoAndrey » Tue Jun 30, 2015 1:51 pm

set extension, I try it. works, thanks.
but there are a few comments:
1 - "You must be logged in to see the hidden text" - it is correct for the guests, but not right for users who are logged in, but had not yet replied to the topic.
2 - how to display the contents of bbcode when it is open, without the background and the inscription OPEN. if the user can view the content, then display it as a normal message.

marcovo
Registered User
Posts: 239
Joined: Fri Nov 16, 2012 12:19 pm
Location: The Netherlands
Name: Marco

Re: [BETA] Hide BBcode

Post by marcovo » Tue Jun 30, 2015 2:46 pm

FomenkoAndrey:

1 - This extension is meant to just exactly do that: Hide the content from anyone who has not yet posted in the topic. If you are searching for an extension that hides the content from anyone who is not logged in, this extension is not what you're looking for.
2 - Modify ext/marcovo/hideBBcode/styles/all/template/hide_bbcode.html. To remove the box when the content is to be shown, replace the first two lines with this:

Code: Select all

<!-- BEGIN unhide_open --><!-- END unhide_open -->
<!-- BEGIN unhide_close --><!-- END unhide_close -->

FomenkoAndrey
Registered User
Posts: 367
Joined: Thu Aug 19, 2010 10:44 am

Re: [BETA] Hide BBcode

Post by FomenkoAndrey » Tue Jun 30, 2015 4:22 pm

This extension is meant to just exactly do that:
I understand well.

Now your extension says (Google translation from Russian):
"You must be logged in to see the hidden text"
you say:
Hide the content from anyone who has not yet posted in the topic
there is a difference?
or Russian translation of this block of text is not completely correct.
Modify
Thanks, what I need.

Locked

Return to “Abandoned Extensions”