[ABD] Advanced Polls

FomenkoAndrey · Post by **FomenkoAndrey** » Sun Mar 22, 2015 8:30 pm

Эта опция работает только тогда, если в этом голосовании установлена дата окончания опроса

Code: Select all

Эта опция работает только тогда, когда в этом голосовании установлена дата окончания опроса

Code: Select all

Обратите внимание, что это остаётся скрытым, если голосования должны быть скрыты

dont understand what is it "это" option? or user?

Code: Select all

Если эта опция включена, только те пользователи смогут голосовать, которые уже ответили в этой теме

Code: Select all

Если эта опция включена, голосовать смогут только те пользователи, которые уже ответили в этой теме

in general translation is understandable, but some places are not quite correct, some - can and should be improved.
the literal translation of the Russian language does not work.

tamarin · Post by **tamarin** » Sun Mar 22, 2015 8:56 pm

FomenkoAndrey wrote:

Code: Select all

Эта опция работает только тогда, если в этом голосовании установлена дата окончания опроса

Code: Select all

Эта опция работает только тогда, когда в этом голосовании установлена дата окончания опроса

Code: Select all

Обратите внимание, что это остаётся скрытым, если голосования должны быть скрыты

dont understand what is it "это" option? or user?

Code: Select all

Если эта опция включена, только те пользователи смогут голосовать, которые уже ответили в этой теме

Code: Select all

Если эта опция включена, голосовать смогут только те пользователи, которые уже ответили в этой теме

in general translation is understandable, but some places are not quite correct, some - can and should be improved.
the literal translation of the Russian language does not work.

Sorry, but I translated from the original language of this extension.

The original in this case is German.

If you don´t like it, put your translation please.
No one opposed.
Thank you.

FomenkoAndrey · Post by **FomenkoAndrey** » Sun Mar 22, 2015 9:04 pm

i dont know German, i look at russhian and found problems.

tamarin · Post by **tamarin** » Sun Mar 22, 2015 9:09 pm

FomenkoAndrey wrote:i dont know German, i look at russhian and found problems.

The author of the extension is a German.

Give us your translation here please.

Wolfsblvt · Post by **Wolfsblvt** » Sun Mar 22, 2015 10:15 pm

Yeah, all fine, we can solve that

And yes, I am German, that's true, but I do extensions in english first, cause I know this is the most important language. So translating from english seems to be the best way.

If you have github accounts, you can just suggest other translations via pull requests, or discuss something via line comments.
Otherwise you can discuss here too, of course

The point is, I can just include one translation in the official file of this extension. So if you can work out the "best" translation that would be really cool

javiexin · Post by **javiexin** » Thu Apr 02, 2015 1:02 pm

Hello,

A small request/addition, if possible, to this great ext

I would like to have some way to have a topic CLOSED (ie, does not allow posting replies) but still, allow for VOTING on the corresponding poll. It would be a new "mode" for the topic (open to votes, closed to reply) or something like that...

Any chance this could be included in the ext?

Thanks a lot!
-javiexin

PS: I am working in some other additions to this ext, as you know

Wolfsblvt · Post by **Wolfsblvt** » Thu Apr 02, 2015 1:15 pm

This is not possible at the moment.

Code: Select all

    // Can not vote at all if no vote permission
    $s_can_vote = ($auth->acl_get('f_vote', $forum_id) &&
        (($topic_data['poll_length'] != 0 && $topic_data['poll_start'] + $topic_data['poll_length'] > time()) || $topic_data['poll_length'] == 0) &&
        $topic_data['topic_status'] != ITEM_LOCKED &&
        $topic_data['forum_status'] != ITEM_LOCKED &&
        (!sizeof($cur_voted_id) ||
        ($auth->acl_get('f_votechg', $forum_id) && $topic_data['poll_vote_change']))) ? true : false;

This code in viewtopic.php directly checks the permissions and topic state without any chance of changing that.

Of course you could change the topic_data in an event before, but that could get messy with topic is considered as open even if it is locked.

Wolfsblvt · Post by **Wolfsblvt** » Sun Apr 05, 2015 1:24 am

Version: 1.1.0-b1
Extension Download: wolfsblvt.advancedpolls.zip

Changelog:

Code: Select all

-- Version 1.1.0-b1 --------------
	• Included dutch, russion and italian translation
	• Reduced required PHP version to 5.3.3
	• Added travis testing for repository
	• Fix settings lost on preview
	• Implemented "Don't want to vote" option
	• Implemented default option for phpBB core options for polls

New Features:
-- Version 1.1.0-b1 --------------

Ability to mark a poll as "I don't want to vote" so you can directly see the results
Choose default options for poll creation

I appreciate any reviews or news if this version works or if your problems/bugs have been fixed (:

Wolfsblvt · Post by **Wolfsblvt** » Sun Apr 05, 2015 1:29 am

For all Translators of this extension, I need your help.
There are two new language strings in two different files.

info_acp_advancedpolls.php

Code: Select all

    'AP_DEFAULT_VOTES_CHANGE'        => 'Selected default for change vote',

advancedpolls.php

Code: Select all

    'AP_POLL_DONT_VOTE_SHOW_RESULTS'        => 'Don\'t vote, view results',

I need you to translate this lines in your language. I have added them to the language files already, but just added the key as translation.

Easiest way is if you start a pull request on GitHub. To do that, you only need a GitHub account.
Otherwise you can post your strings here and I will add them manually.

Thanks to all translators for your help, that's really appreciated (:

koraldon · Post by **koraldon** » Sun Apr 05, 2015 9:49 pm

Installed, everything seems to work fine. However, I didn't get a notice that a new version is available on the version check.
Sent you Hebrew translation in email.

Wolfsblvt · Post by **Wolfsblvt** » Sun Apr 05, 2015 11:58 pm

koraldon wrote:Installed, everything seems to work fine. However, I didn't get a notice that a new version is available on the version check.

I am not sure how the version check is working. But is on my list, I have some problems and difficulties with that.
But I would say there is an option to also accecpt unstable versions as new version in your ACP list there.

Cause this version - wich is a beta version - is considered (by the rules) as an unstable version. Wich will not show up as a stable update on all (live) forums.

Holger · Post by **Holger** » Tue Apr 07, 2015 9:58 am

Swedish translation:

info_acp_advancedpolls.php

Code: Select all

    'AP_DEFAULT_VOTES_CHANGE'        => 'Välj grundinställning för ändring av röstning',

advancedpolls.php

Code: Select all

    'AP_POLL_DONT_VOTE_SHOW_RESULTS'        => 'Rösta ej, visa resultat',

Wolfsblvt · Post by **Wolfsblvt** » Tue Apr 07, 2015 10:52 am

Holger wrote:Swedish translation:

Thanks. https://github.com/Wolfsblvt/advancedpolls/pull/20

As I've seen it now, swedish is still missing some lines in ACP

Code: Select all

    'AP_DEFAULT_VOTES_CHANGE'        => 'Välj grundinställning för ändring av röstning',
    'AP_DEFAULT_VOTES_HIDE'            => 'Standardmäßig ausgewählter Wer für "Verbergen der Abstimmungen"',
    'AP_DEFAULT_VOTERS_SHOW'        => 'Standardmäßig ausgewählter Wer für "Anzeigen von Benutzern, die abgestimmt haben"',
    'AP_DEFAULT_VOTERS_LIMIT'        => 'Standardmäßig ausgewählter Wer für "Einschränkung der Abstimmung"',

Holger · Post by **Holger** » Tue Apr 07, 2015 11:35 am

Uuuups!

Code: Select all

    'AP_DEFAULT_VOTES_CHANGE'        => 'Välj grundinställning för ändring av röstning',
    'AP_DEFAULT_VOTES_HIDE'            => 'Välj grundinställning för "Dölja omröstning"',
    'AP_DEFAULT_VOTERS_SHOW'        => 'Välj grundinställning för "Visning av medlemmar som har röstat"',
    'AP_DEFAULT_VOTERS_LIMIT'        => 'Välj grundinställning för "Inskränkning av omröstning"',

Wolfsblvt · Post by **Wolfsblvt** » Tue Apr 07, 2015 12:40 pm

Holger wrote:Uuuups!

Updated the pull request.