[ABD] @Mention System

Any abandoned Extensions will be moved to this forum.

WARNING: Extensions in this forum are not currently being supported or maintained by the original Extension author. Proceed at your own risk.
Forum rules
IMPORTANT: Extension Development Forum rules

WARNING: Extensions in this forum are not currently being supported nor updated by the original Extension author. Proceed at your own risk.
User avatar
adsol93
Registered User
Posts: 31
Joined: Tue May 26, 2015 2:14 am

Re: [DEV] @Mention System

Post by adsol93 » Tue Jun 02, 2015 12:02 am

I know, that's why I said that there's no option for this.

CorporateGoth
Registered User
Posts: 10
Joined: Tue Nov 13, 2007 1:39 pm

Re: [DEV] @Mention System

Post by CorporateGoth » Sat Jun 06, 2015 3:05 pm

So the original author wanted feedback on if this slows down a large forum.

I can confirm, it does.

My phpBB runs on HHVM, on very high end hardware. I have a bunch of exts, but without @Mention enabled, pages load between 0.170ms to 0.250ms on average.
With @Mention enabled, the BEST I have seen is 1.4s, and often over 3s load times for a page.

@Mention slows down my board a LOT. I've not tried debugging why yet.

My board has over 10k users, 5k topics and 200k posts.

I also think it introduces a memory leak (which is not a problem if you are using a form of PHP that runs once and dies, aka. pre-fork mode, but is a huge problem for persistent caching PHP servers, like hhvm). In under 24 hours the memory usage with this mod enabled can grow over 4gb. And that's with light traffic.

The performance and memory issues might be linked, but this definitely needs to be investigated before releasing. I like the mod otherwise. I manually hacked into my version a solution to the broken image problem in the drop down.

Vattenpistol
Registered User
Posts: 101
Joined: Thu Dec 30, 2010 5:44 pm

Re: [DEV] @Mention System

Post by Vattenpistol » Sun Jun 14, 2015 11:26 am

Hi!

Can this MOD be used for my 3.0.12 forum? If not, is there an alternative?

Kind regards

User avatar
SalazarAG
Registered User
Posts: 668
Joined: Mon Mar 30, 2015 10:48 am

Re: [DEV] @Mention System

Post by SalazarAG » Sun Jun 14, 2015 9:05 pm

Vattenpistol wrote:Hi!

Can this MOD be used for my 3.0.12 forum? If not, is there an alternative?

Kind regards
PhpBB 3.1 extensions do not work on lower versions.

See this MOD similar to 3.0.12 https://www.phpbb.com/customise/db/mod/ ... ntion_mod/
I'm sorry for my English. Google Translator does a bad job. :D

User avatar
Volksdevil
Registered User
Posts: 2414
Joined: Sun Oct 03, 2010 2:03 pm
Location: Lancashire, UK
Name: Neil
Contact:

Re: [DEV] @Mention System

Post by Volksdevil » Tue Jun 16, 2015 6:32 pm

Any progress on this one? :)
My phpBB Extensions
Finally found great Website Hosting from Image KUALO!
Do NOT use 123-reg.co.uk - Incapable of running phpBB!
:ugeek: TekNeil - Streamer on Mixer | My Volkswagen Corrado G60

User avatar
cYbercOsmOnauT
Registered User
Posts: 362
Joined: Wed Jun 16, 2004 8:22 am
Location: Goettingen, Germany
Name: Tekin Birdüzen

Re: [DEV] @Mention System

Post by cYbercOsmOnauT » Wed Jun 17, 2015 11:53 am

CorporateGoth wrote:@Mention slows down my board a LOT. I've not tried debugging why yet.
The best guess what slows it down is the get_userlist method inside the mentions class.
phpBB-installation and reparation. Prof. PHP coding with function guarantee. Just contact me at: t.birduezen@web-coding.eu.
Ex-German Support Team Member | phpBB Development Environment

onlyproevo
Registered User
Posts: 110
Joined: Tue Jun 21, 2011 8:13 pm

Re: [DEV] @Mention System

Post by onlyproevo » Fri Jun 19, 2015 2:13 pm

Sounds like a fantastic. Hopefully I can use it on my 3.1.5 board soon.

Keep up the great work! :)

infinitiv
Registered User
Posts: 166
Joined: Sat Nov 15, 2014 3:47 pm
Location: PL
Name: Ficjusz

Re: [DEV] @Mention System

Post by infinitiv » Mon Jun 22, 2015 9:00 pm

For some reasson dropdown list doesn't appear for me. I'm using phpBB 3.1.5.

infinitiv
Registered User
Posts: 166
Joined: Sat Nov 15, 2014 3:47 pm
Location: PL
Name: Ficjusz

Re: [DEV] @Mention System

Post by infinitiv » Tue Jun 23, 2015 10:05 pm

NVM, just jQuery fooled with me. I have two notes tho:

1. Ext doesn't work when used in quick-reply window.

2. Ext doesn't work when @ is placed inside custom BBCode.

3. Ext have some issues working with mChat by dmzx - default mChat @ overwrites it.

infinitiv
Registered User
Posts: 166
Joined: Sat Nov 15, 2014 3:47 pm
Location: PL
Name: Ficjusz

Re: [DEV] @Mention System

Post by infinitiv » Wed Jun 24, 2015 1:46 pm

infinitiv wrote:NVM, just jQuery fooled with me. I have two notes tho:

1. Ext doesn't work when used in quick-reply window.

2. Ext doesn't work when @ is placed inside custom BBCode.

3. Ext have some issues working with mChat by dmzx - default mChat @ overwrites it.
Witch quick-reply window i meant dropdown lists and with mChat i meant the same + when you add anything after an username (like a colon, which mChat does), ext stops working. I think that ignoring colons, dots and such would be nice in this ext. IDK how it behaves with usernames containting spaces, but I'd look into it if I were you.

ntvy95
Registered User
Posts: 69
Joined: Wed Jun 10, 2015 12:58 pm

Re: [DEV] @Mention System

Post by ntvy95 » Fri Jun 26, 2015 5:07 am

I do not know who I should report with but it looks like your extension is not compatible with Games Collection Extension so the result is the Warning on this page.

Still, thank you very much for your great work!

infinitiv
Registered User
Posts: 166
Joined: Sat Nov 15, 2014 3:47 pm
Location: PL
Name: Ficjusz

Re: [DEV] @Mention System

Post by infinitiv » Fri Jun 26, 2015 10:04 am

I found another issues:

1. EXT doesn't work in preview (only after sending a message), so judging by this users could think that it's not working.
2. mention= is hella buggy, but fortunately there's easy fix:


In mentions/styles/all/template/js/onload.js

Find in-line (around 85):

Code: Select all

insertTpl: 'mention="${name}',
Change to:

Code: Select all

insertTpl: '[mention="${name}"',

infinitiv
Registered User
Posts: 166
Joined: Sat Nov 15, 2014 3:47 pm
Location: PL
Name: Ficjusz

Re: [DEV] @Mention System

Post by infinitiv » Sun Jun 28, 2015 9:21 am

Here goes another one:
When an user changes username, all previously posted mentions broke.

User avatar
cYbercOsmOnauT
Registered User
Posts: 362
Joined: Wed Jun 16, 2004 8:22 am
Location: Goettingen, Germany
Name: Tekin Birdüzen

Re: [DEV] @Mention System

Post by cYbercOsmOnauT » Sun Jun 28, 2015 2:29 pm

This is hard to solve because you would have to change the way the mention bbcode works. It would have to be saved in the database with userid but shown on the textfield as username. Again when submitting the username would have to be changed to the userid. This would be a solution.
phpBB-installation and reparation. Prof. PHP coding with function guarantee. Just contact me at: t.birduezen@web-coding.eu.
Ex-German Support Team Member | phpBB Development Environment

Yros
Registered User
Posts: 19
Joined: Mon Oct 17, 2011 1:22 am

Re: [DEV] @Mention System

Post by Yros » Mon Jun 29, 2015 6:31 am

~ Despite deactivating the display of user's avatar in the post, the avatar is still displayed in the autocompletion list.
~ The extension has issues with members not having avatars (displays either a random pic or "User avatar" text).
~ The notification counter doesn't seem to change when you mention yourself, even though you receive a notification correctly.
~ The '@' should be colored & link to the username. Actually it is displayed as plain text which is odd. Basically, instead of having :

Code: Select all

@<a href="{USER_PROFILE}" class="{USER_RANK}">{USERNAME}</a>
You should have:

Code: Select all

<a href="{USER_PROFILE}" class="{USER_RANK}">@{USERNAME}</a>
Or not displaying the '@' at all.

Thanks for the mod though.

Locked

Return to “Abandoned Extensions”