Page 3 of 18

Re: [BETA] Advanced Polls 1.2.1

Posted: Fri Jul 17, 2015 2:40 pm
by Galixte de EzCom
phpBB 3.1.5 without modification.

Re: [BETA] Advanced Polls 1.2.1

Posted: Mon Jul 20, 2015 3:10 pm
by sp3ctre
I am testing this extension and it works well apart from one issue. My timezone is set to UTC+1. When I make a poll and tell it to run until 4pm it tells me it is running til 5pm.

Re: [BETA] Advanced Polls 1.2.1

Posted: Mon Jul 20, 2015 3:18 pm
by javiexin
What is your TZ vs the board's TZ?

Re: [BETA] Advanced Polls 1.2.1

Posted: Tue Jul 21, 2015 3:17 pm
by javiexin
sp3ctre wrote:I am testing this extension and it works well apart from one issue. My timezone is set to UTC+1. When I make a poll and tell it to run until 4pm it tells me it is running til 5pm.
Confirmed, there is an issue when the PHP.ini timezone is different from the user's timezone.
Working on a fix for this. Stay tuned.
Galixte de EzCom wrote:if i edit the poll, some options of the poll are reseted:
- Maximum votes:
- Total votes:
- Hide votes:
- Limit votes:
- Show poll voters:
- Show results ordered:
Any additional information you may give? Or was it fixed?

-javiexin

Re: [BETA] Advanced Polls 1.2.1

Posted: Tue Jul 21, 2015 7:42 pm
by sp3ctre
javiexin wrote:
sp3ctre wrote:I am testing this extension and it works well apart from one issue. My timezone is set to UTC+1. When I make a poll and tell it to run until 4pm it tells me it is running til 5pm.
Confirmed, there is an issue when the PHP.ini timezone is different from the user's timezone.
Working on a fix for this. Stay tuned.
Excellent, glad it wasn't just me :)

Thanks

Re: [BETA] Advanced Polls 1.2.1

Posted: Tue Jul 21, 2015 7:48 pm
by javiexin
The issue with timezone conversion is now fixed. Re-download the extension and replace existing files with the new ones.

I did not update the version for such a minor change (only one file changed, core/advancedpolls.php).

Regards,
-javiexin

Re: [BETA] Advanced Polls 1.2.1

Posted: Sat Jul 25, 2015 3:01 pm
by leschek
javiexin wrote:If you have further suggestions for new functionality, please, mention them here, and we will evaluate them, and potentially include them (no commitments!).
Just an idea - what do you think about limiting the number of vote changes. If option "Allow re-voting" is allowed, users would be able to change their vote only 2-3 times (or whatever number a poll creator sets) and not as many times as they want.

Re: [BETA] Advanced Polls 1.2.1

Posted: Sat Jul 25, 2015 3:34 pm
by javiexin
Thanks for the suggestion leschek. I will take it into consideration.

However, some issues I see upfront with such a limitation: how would you count changes? "Incremental" votes would be counted as changes, or not? In case of multi-valued or scoring polls, how would you count changes, by the number of "submits", or by the number of actual changes (in number of points assigned or options selected)? Also, it would make it more cumbersome for the poll creator, another option to select, with no clear benefit, because how many people really change votes so frequently in a poll?

Anyhow, I will include this is the list of things to evaluate for future versions.
Thanks again!
-javiexin

Re: [BETA] Advanced Polls 1.2.1

Posted: Sat Jul 25, 2015 5:15 pm
by leschek
I would say 1 submit = 1 change, but you are right here:
javiexin wrote:it would make it more cumbersome for the poll creator, another option to select, with no clear benefit, because how many people really change votes so frequently in a poll?

Re: [BETA] Advanced Polls 1.2.1

Posted: Sat Jul 25, 2015 6:32 pm
by Yros
Hi,

Nice mod. I have a suggestion : possibility to create "event" polls. It's quite simple : the author of the poll could define the groups/options, then people could choose which one to choose (ex: team red, yellow, green) (another exemple : meeting here : I'll be here, I don't know, I won't be there). The users voting would be directly listed under each category.

Re: [BETA] Advanced Polls 1.2.1

Posted: Sun Jul 26, 2015 12:14 am
by javiexin
Yros wrote:Hi,

Nice mod. I have a suggestion : possibility to create "event" polls. It's quite simple : the author of the poll could define the groups/options, then people could choose which one to choose (ex: team red, yellow, green) (another exemple : meeting here : I'll be here, I don't know, I won't be there). The users voting would be directly listed under each category.
Already available with current version: just mark the options to see poll voters and allow vote changes, done.

Re: [BETA] Advanced Polls 1.2.1

Posted: Sun Jul 26, 2015 11:39 pm
by SalazarAG
Hello! I liked both the extension, installed in localhost and even translate. Ready to use it, when I created a poll and sent, returned me this error:

Code: Select all

SQL ERROR [ mysqli ]

Out of range value for column 'poll_start' at row 1 [1264]

SQL

INSERT INTO phpbb_topics (topic_poster, topic_time, topic_last_view_time, forum_id, icon_id, topic_posts_approved, topic_posts_softdeleted, topic_posts_unapproved, topic_visibility, topic_delete_user, topic_title, topic_first_poster_name, topic_first_poster_colour, topic_type, topic_time_limit, topic_attachment, poll_title, poll_start, poll_max_options, poll_length, poll_vote_change, wolfsblvt_poll_votes_hide, wolfsblvt_poll_voters_show, wolfsblvt_poll_voters_limit, wolfsblvt_poll_show_ordered, wolfsblvt_poll_max_value, wolfsblvt_poll_total_value) VALUES (2, 1437953483, 1437953483, 23, 0, 1, 0, 0, 1, 0, 'Fórum está legal', '008000', 0, 0, 0, 'Sua nota para a atual situaçao do fórum', -86400, 1, 86400, 1, 0, 1, 0, 1, 1, 1)

BACKTRACE

FILE: (not given by php)
LINE: (not given by php)
CALL: msg_handler()

FILE: [ROOT]/phpbb/db/driver/driver.php
LINE: 855
CALL: trigger_error()

FILE: [ROOT]/phpbb/db/driver/mysqli.php
LINE: 193
CALL: phpbb\db\driver\driver->sql_error()

FILE: [ROOT]/phpbb/db/driver/factory.php
LINE: 329
CALL: phpbb\db\driver\mysqli->sql_query()

FILE: [ROOT]/includes/functions_posting.php
LINE: 1874
CALL: phpbb\db\driver\factory->sql_query()

FILE: [ROOT]/posting.php
LINE: 1400
CALL: submit_post()
How do I fix?

Re: [BETA] Advanced Polls 1.2.1

Posted: Sun Jul 26, 2015 11:47 pm
by javiexin
What version of phpbb do you have, 3.1.5 I hope.

Could you please tell how were you configuring the poll?Options selected and, the most important given the error, poll end and poll length specified.

Re: [BETA] Advanced Polls 1.2.1

Posted: Mon Jul 27, 2015 12:00 am
by SalazarAG
javiexin wrote:What version of phpbb do you have, 3.1.5 I hope.

Could you please tell how were you configuring the poll?Options selected and, the most important given the error, poll end and poll length specified.
First, sorry for my English haha

Well, my phpBB version is 3.1.5. The PHP version is 5.4x

I redid the poll as the first time and printei (is below).

Image

I put the same options

Did not specify a date (YYYY-MM-DD) to the end of the poll.

And the following error :(

I thought it might be a mistake in the language as did the translation for pt_br (my standard language), but deleted it and the error persists.

Re: [BETA] Advanced Polls 1.2.1

Posted: Mon Jul 27, 2015 12:10 am
by javiexin
Try specifying the poll end explicitly, and it should work fine. Also, try specifying a different length.
In the meantime, I will see if I find the issue.
Thanks for testing and reporting this!