Page 1 of 5

[ABD] Prime Post Revision

Posted: Mon Jan 18, 2016 10:50 am
by Bruninoit
Description: it saves all version of edited posts and users with permission can see them and restore.

TOPIC INFO
Image

Features:
  • OK save edited posts
  • OK view edit history
  • OK restore old versions
  • OK delete old versions

Re: [DEV] Prime Post Revision

Posted: Mon Jan 18, 2016 9:52 pm
by David B
Bruninoit wrote:Description: it saves all version of edited posts and users with permission can see them and restore.

Download: soon
Great! I've been looking for someone to do this. I wanted to do it myself, but I do not understand the new extensions API.

Re: [DEV] Prime Post Revision

Posted: Mon Jan 18, 2016 10:25 pm
by Nadleeh
Can't wait!

Re: [BETA] Prime Post Revision

Posted: Tue Jan 19, 2016 8:31 am
by Bruninoit
First BETA version with 2/4 of features.

Re: [BETA] Prime Post Revision

Posted: Tue Jan 19, 2016 5:44 pm
by Nadleeh
Tested the beta and get this error when editing a post and pressing submit.

Code: Select all

phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 2416: Cannot modify header information - headers already sent by (output started at [ROOT]/ext/bruninoit/ppr/event/main_listener.php:186)
The edited post is saved, but viewing the edits result in an empty screen.

Screenshot

Re: [BETA] Prime Post Revision

Posted: Tue Jan 19, 2016 7:10 pm
by Bruninoit
Oh thanks... My error... I've updated the package
To simple update:
Open file event/main_listener.php
Search and remove all lines

Code: Select all

var_dump($event['data']);

Re: [BETA] Prime Post Revision

Posted: Tue Jan 19, 2016 7:54 pm
by Nadleeh
Works like a charm now, thanks.

The page to view the edits is not implemented I guess? Just wondering :).

If you need a Dutch translation, let me now.

Edit: tested on 3.1.6 and 3.1.7-pl1 btw.

Re: [BETA] Prime Post Revision

Posted: Tue Jan 19, 2016 8:16 pm
by Bruninoit
The page to view old version is enable... Don't you see it? There is a Button on every post that has been modified.

Thanks for all tests.

Re: [BETA] Prime Post Revision

Posted: Tue Jan 19, 2016 8:20 pm
by Nadleeh
I saw the new button indeed. Clicking it gives no errors, but it shows nothing, except who made the extension :). See the screenshot below.

Image

Re: [BETA] Prime Post Revision

Posted: Tue Jan 19, 2016 8:46 pm
by Bruninoit
Umh, can you see with phpmyadmin, table phpbb_ppr which is the situation?

Re: [BETA] Prime Post Revision

Posted: Tue Jan 19, 2016 8:58 pm
by Nadleeh
Ofcourse.

Image

Image

Don't mind the garbage, just smashed on my keyboard for some random text.

Re: [BETA] Prime Post Revision

Posted: Tue Jan 19, 2016 9:27 pm
by Bruninoit
Which is the link that appear when you click the button on revision?

Re: [BETA] Prime Post Revision

Posted: Tue Jan 19, 2016 9:34 pm
by Nadleeh
http://localhost/forum_test/app.php/ppr/view/883727

Re: [BETA] Prime Post Revision

Posted: Wed Jan 20, 2016 2:23 am
by David B
I've got the same issue. The edits are being saved to the database, but the page to view the changes is just displaying blank page.

Re: [BETA] Prime Post Revision

Posted: Wed Jan 20, 2016 7:25 am
by Bruninoit
Nadleeh wrote:http://localhost/forum_test/app.php/ppr/view/883727
Try this: http://localhost/forum_test/app.php/ppr/view/860013

Please, verify also if the post you have edited has id 860013 or 883727