[ABD] Show Title From External Links

[Mickroz]

Show Title From External Links

Author: Mickroz

Extension Version: 1.0.2 (unstable)

Description:
This extension will allow the display of the links page title on your forum when a link is posted

Precaution:
As the ext is still in development, major changes still can be applied which could require full extension purging and reinstallation, so use it on your own risk. DO NOT install it on production boards. For testing purposes only.

Requirements:

• PHP >= 5.3.3
• phpBB >= 3.1.0

3.0 MOD Authors:
This is a extension based on the Show Title From External Links MOD, written by: RMcGirr83

Installation:

1. Download the latest release
2. Create a new folder in the /ext/ directory, named: mickroz (If it doesn't exist already)
3. Create a new folder in /ext/mickroz/ named linktitles
4. Copy the contents from the linktitles-master folder from your download into
   /ext/mickroz/linktitles/
5. The main extension class should now be at: root/ext/mickroz/linktitles/composer.json
6. Nagivate in the Administration Control Panel (ACP) to Customise -> Manage Extensions
7. Look for Show Title From External Links in the Disabled Extensions list and click Enable!

Download:
Download

Screenshots:
none yet

[3Di]

Since you are using cURL you should provide the code that checks if it is present or not, because not all server configurations (hosters) give it available somehow. If not present then there are different alternatives:

1 - simply stating you need cURL isn't enough (and you didn't), people tend to install extensions and then blame you in case of errors related.. and you didn't code an error check too.

2 - provide an ext.php file that will block the installation if the required stuff isn't present, coding there the above cited check-in.

3 - Provide a fallback, an alternative if cURL isn't present (seems to me the best option).

If you are interested you can have a look at some thing I coded for an ext of mine, the following highlighted lines show you a simple function you could use for this approach, the whole file/ext could also be of interest for this case since I am using file_get_contents as a fallback.

https://github.com/3D-I/IP-Country-Flag ... hp#L73-L82

[Mickroz]

Thats why its still in dev 3Di
I never really thought that curl wasn't a default thing on a server.
I had trouble with file_get_contents() (as the original mod used) and therefor fallback to curl.

It makes sense what you are saying, initially I had an error check for curl, but I removed it for testing, and not placed it back.
I will check your code to see what you mean, thanks for reporting.

[3Di]

I am just encouraging your dev, trying to be constructive. I know what a DEV prefix stands for.
If you are not finding an anternative fallback to cURL though, the option 2 should cover it.
Regards.

[Mickroz]

I know, I was just kidding, and im thankful for you comment.
I think I will go like you have done it, seems doable.
Thanks.

[koraldon]

Hi,
sounds great - does it work with ELONW ?
Any option to maybe combine the two extensions?

[RMcGirr83]

It should work with ELONW version that is sitting in the queue. Concerning the code

Code: Select all

    public function get_url($url)
    {
        $ch = curl_init();
        curl_setopt($ch, CURLOPT_URL, $url);
        curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
        curl_setopt($ch, CURLOPT_USERAGENT, 'LinkTitles');
        $data = curl_exec($ch);
        curl_close($ch);
        
        return $data;
    }

you should ensure that something is returned (server not down), eg.

Code: Select all

    public function get_url($url)
    {
        $ch = curl_init();
        curl_setopt($ch, CURLOPT_URL, $url);
        curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
        curl_setopt($ch, CURLOPT_USERAGENT, 'LinkTitles');
        curl_setopt($ch, CURLOPT_TIMEOUT, 5);
        curl_setopt($ch, CURLOPT_CONNECTTIMEOUT, 5);
        $httpcode = curl_getinfo($ch, CURLINFO_HTTP_CODE);
        $data = curl_exec($ch);
        curl_close($ch);
        // if nothing is returned (server is down)
        if ($httpcode != 200)
        {
            return false;
        }
        return $data;
    }

[Mickroz]

yes it should work with ELONW, i have it running side by side here.
thanks Rich, i had this:

Code: Select all

$httpcode = curl_getinfo($ch, CURLINFO_HTTP_CODE);
	curl_close($ch);
	return ($httpcode>=200 && $httpcode<300) ? $data : false;

will add the other two lines

Code: Select all

curl_setopt($ch, CURLOPT_TIMEOUT, 5);
        curl_setopt($ch, CURLOPT_CONNECTTIMEOUT, 5);

aswell.

EDIT: updated code with suggestions made by 3Di and RMcGirr83.

[Volksdevil]

Seem to have a small issue with thi when links are wrapped around images. Such as photobucket, example below:

Code: Select all

[url=http://s1239.photobucket.com/user/xbox360guru/media/AEB%20%20Build/20161105_210812.jpg.html][img]http://i1239.photobucket.com/albums/ff512/xbox360guru/AEB%20%20Build/20161105_210812.jpg[/img][/url]

A link/image like that doesn't show anything in the post.

[Mickroz]

hmm yeah, for some reason it skips the check and therefore returns no text, will check this further.

EDIT: i changed it so that only link texts starting with http get overwritten, else the old text is used, this should fix the images too.

[kim902]

How many links can one post before the page posts slow ?

[Mickroz]

don't know,haven't done any calculations, depends on too much factors to be honest.

[koraldon]

Installed on my live site, seems to be working great - thanks
No conflict with ELONW 1.0.4.

[Mickroz]

great, let me know if you ran into problems

[koraldon]

No problem atm.
Not sure if this is the right place, but currently using 3 extensions to manage links: This one, ELONW and Local URL To Text
Would be great to somehow combine them into a single extension with ACP to enable/disable features, will simplify the overhead.