[DEV] Topic/Post Reactions(like, happy, thanks, angry)

A place for Extension Authors to post and receive feedback on Extensions still in development. No Extensions within this forum should be used within a live environment!
Anti-Spam Guide
Forum rules
READ: phpBB.com Board-Wide Rules and Regulations

IMPORTANT: Extensions Development rules

IMPORTANT FOR NEEDED EVENTS!!!
If you need an event for your extension please read this for the steps to follow to request the event(s)
Post Reply
M4rc0
Registered User
Posts: 22
Joined: Wed May 17, 2017 11:37 am

Re: [DEV][3.2] Topic/Post Reactions(like, happy, thanks, angry)

Post by M4rc0 »

I don't know what premium style means, but here is where I bought it: https://themeforest.net/item/milk-multi ... e/16119149

I hope that posting this link is not against the forum rules. If so, i'll remove it

M4rc0
Registered User
Posts: 22
Joined: Wed May 17, 2017 11:37 am

Re: [DEV][3.2] Topic/Post Reactions(like, happy, thanks, angry)

Post by M4rc0 »

I found this on the documentation:
Milk inherits any missing template files (eg: For extensions) from prosilver.
Is that helpful?

User avatar
Steve
Registered User
Posts: 1052
Joined: Tue Apr 07, 2009 7:48 pm
Location: UK ,up north!!
Name: Steven Clark
Contact:

Re: [DEV][3.2] Topic/Post Reactions(like, happy, thanks, angry)

Post by Steve »

Link to your forum please.

User avatar
Hartenheer
Registered User
Posts: 780
Joined: Fri Jan 23, 2015 12:23 pm
Location: The Netherlands
Name: Willem Hartman
Contact:

Re: [DEV][3.2] Topic/Post Reactions(like, happy, thanks, angry)

Post by Hartenheer »

Sorry my english is very bad.

Do you mean that the entire old program must be removed, and then reinstalled again.

And then reset everything on the forum?
Sorry English is not my native language :oops:
regards: Willem

https://bierfijnproevers.nl/bierforum

M4rc0
Registered User
Posts: 22
Joined: Wed May 17, 2017 11:37 am

Re: [DEV][3.2] Topic/Post Reactions(like, happy, thanks, angry)

Post by M4rc0 »

Steve wrote: ↑
Wed May 17, 2017 1:22 pm
Link to your forum please.
https://www.mmamania.it/forum/

User avatar
Steve
Registered User
Posts: 1052
Joined: Tue Apr 07, 2009 7:48 pm
Location: UK ,up north!!
Name: Steven Clark
Contact:

Re: [DEV][3.2] Topic/Post Reactions(like, happy, thanks, angry)

Post by Steve »

Hartenheer wrote: ↑
Wed May 17, 2017 1:32 pm
Sorry my english is very bad.

Do you mean that the entire old program must be removed, and then reinstalled again.

And then reset everything on the forum?
Yes.

User avatar
Hartenheer
Registered User
Posts: 780
Joined: Fri Jan 23, 2015 12:23 pm
Location: The Netherlands
Name: Willem Hartman
Contact:

Re: [DEV][3.2] Topic/Post Reactions(like, happy, thanks, angry)

Post by Hartenheer »

Steve wrote: ↑
Wed May 17, 2017 2:04 pm
Hartenheer wrote: ↑
Wed May 17, 2017 1:32 pm
Sorry my english is very bad.

Do you mean that the entire old program must be removed, and then reinstalled again.

And then reset everything on the forum?
Yes.
Thanks
Sorry English is not my native language :oops:
regards: Willem

https://bierfijnproevers.nl/bierforum

User avatar
Steve
Registered User
Posts: 1052
Joined: Tue Apr 07, 2009 7:48 pm
Location: UK ,up north!!
Name: Steven Clark
Contact:

Re: [DEV][3.2] Topic/Post Reactions(like, happy, thanks, angry)

Post by Steve »

M4rc0 wrote: ↑
Wed May 17, 2017 1:36 pm
Steve wrote: ↑
Wed May 17, 2017 1:22 pm
Link to your forum please.
https://www.mmamania.it/forum/
Can you set these permissions for guests to yes.

=> 'Can view Reactions',
=> 'Can view Reactions Page',
=> 'Can view Post Reactions Page',


and Can you go to admin and preview prosilver style and tell me if its working then?

M4rc0
Registered User
Posts: 22
Joined: Wed May 17, 2017 11:37 am

Re: [DEV][3.2] Topic/Post Reactions(like, happy, thanks, angry)

Post by M4rc0 »

Done it. And yes, on the Prosilver preview it's working

User avatar
Steve
Registered User
Posts: 1052
Joined: Tue Apr 07, 2009 7:48 pm
Location: UK ,up north!!
Name: Steven Clark
Contact:

Re: [DEV][3.2] Topic/Post Reactions(like, happy, thanks, angry)

Post by Steve »

Ok well all I can suggest is creating a directory called Milk_v2 and copying the template and theme folder over from ext/steve/postreactions/styles/prosilver to Milk_v2

M4rc0
Registered User
Posts: 22
Joined: Wed May 17, 2017 11:37 am

Re: [DEV][3.2] Topic/Post Reactions(like, happy, thanks, angry)

Post by M4rc0 »

Great! It's working!
The only bug is that if you click the reaction image to open the post reactions page, on the little window that is opening, you'll see the exact same page you're in and not the post reactions

UPDATE
Even if I set "Enable View Post Reactions Page" to "No", i can click on the reaction and open the little window that is not working correctly

UPDATE 2
If I open a topic with unread messages, I see the reactions button on all the post except the ones I haven't read. Even if I exit the topic and enter it again, there is no reactions button
Look: same topic, same user, one post has reactions, one not...
Image
If it's me to post it's ok. I posted on the same topic with the user of a friend of mine who gave me the pass and it's ok with his profile. I can't catch the logic behind this problem.

UPDATE 3
I set only "Can see reactions" to yes on guests permissions. They see correctly the post reactions, but they see also the reactions button (even if it's not working for them if you click on one reaction). Don't you think it would be better to hide that if they don't have the permissions to react?
Last edited by M4rc0 on Thu May 18, 2017 11:11 am, edited 1 time in total.

M4rc0
Registered User
Posts: 22
Joined: Wed May 17, 2017 11:37 am

Re: [DEV][3.2] Topic/Post Reactions(like, happy, thanks, angry)

Post by M4rc0 »

Just to said that I updated the last post with other info. Thank you

User avatar
Steve
Registered User
Posts: 1052
Joined: Tue Apr 07, 2009 7:48 pm
Location: UK ,up north!!
Name: Steven Clark
Contact:

Re: [DEV][3.2] Topic/Post Reactions(like, happy, thanks, angry)

Post by Steve »

ok, i will take a look.

User avatar
Steve
Registered User
Posts: 1052
Joined: Tue Apr 07, 2009 7:48 pm
Location: UK ,up north!!
Name: Steven Clark
Contact:

Re: [DEV][3.2] Topic/Post Reactions(like, happy, thanks, angry)

Post by Steve »

M4rc0 wrote: ↑
Wed May 17, 2017 7:43 pm
Great! It's working!
The only bug is that if you click the reaction image to open the post reactions page, on the little window that is opening, you'll see the exact same page you're in and not the post reactions
What's your php Version? on php version 5.4 there was a debug but that's fixed for next release.
Try enabling URL Rewriting, under Server settings > path settings in ACP.
UPDATE
Even if I set "Enable View Post Reactions Page" to "No", i can click on the reaction and open the little window that is not working correctly
fixed for next release.
UPDATE 2
If I open a topic with unread messages, I see the reactions button on all the post except the ones I haven't read. Even if I exit the topic and enter it again, there is no reactions button
Look: same topic, same user, one post has reactions, one not...
http://i68.tinypic.com/2ppn72d.png
If it's me to post it's ok. I posted on the same topic with the user of a friend of mine who gave me the pass and it's ok with his profile. I can't catch the logic behind this problem.
Uses quick reply > clicks [full editor & preview] > on the posting page, Enable Reactions to this Post not checked.
Only way i can reproduce this and its fixed for next release.
UPDATE 3
I set only "Can see reactions" to yes on guests permissions. They see correctly the post reactions, but they see also the reactions button (even if it's not working for them if you click on one reaction). Don't you think it would be better to hide that if they don't have the permissions to react?
fixed for next release.

M4rc0
Registered User
Posts: 22
Joined: Wed May 17, 2017 11:37 am

Re: [DEV][3.2] Topic/Post Reactions(like, happy, thanks, angry)

Post by M4rc0 »

Steve wrote: ↑
Fri May 19, 2017 8:39 am
What's your php Version? on php version 5.4 there was a debug but that's fixed for next release.
Try enabling URL Rewriting, under Server settings > path settings in ACP.
PhpBB version: 3.2.0
PHP version: 7.0.16

I enabled the URL Rewriting and emptied all the caches but nothing changed
Steve wrote: ↑
Fri May 19, 2017 8:39 am
Uses quick reply > clicks [full editor & preview] > on the posting page, Enable Reactions to this Post not checked.
Only way i can reproduce this and its fixed for next release.
You're right! It's working using the quick reply, but not with the full editor.
On my full editor page I don't have "Enable Reactions to this Post" at all

When do you think the next release will be released? This extension is amazing and I can't wait to have it full working on my forum :)

If I can give you a suggestion, now the button is ":) | arrow", I would make it ":)" only because of the few space of the mobile view, but obviously the decision is up to you. Thank you very much for your work!

Post Reply

Return to β€œExtensions in Development”