Disapearing attachments after update to 3.2.2

[Lucan]

/edit
done

[Forex Station]

^^ but's wrong ^^

See here https://github.com/phpbb/phpbb/pull/5082/files

Hey thanks for the link, do I just copy, paste and replace into my current functions_posting.php with the text from Github link over the old parts?

Code: Select all

 		// We display the posted attachments within the desired order.
 		($config['display_order']) ? krsort($attachment_data) : ksort($attachment_data);
 
+		$attachrow_template_vars = [];
+
 		foreach ($attachment_data as $count => $attach_row)
 		{
 			$hidden = '';
-			$attachrow_template_vars = array();
 			$attach_row['real_filename'] = utf8_basename($attach_row['real_filename']);
 
 			foreach ($attach_row as $key => $value)

[canonknipser]

The + in the first columns means "Add the Line", the - means "Remove the line",
so your code should look like:

Code: Select all

 		// We display the posted attachments within the desired order.
 		($config['display_order']) ? krsort($attachment_data) : ksort($attachment_data);
 
		$attachrow_template_vars = [];

 		foreach ($attachment_data as $count => $attach_row)
 		{
 			$hidden = '';

 			$attach_row['real_filename'] = utf8_basename($attach_row['real_filename']);
 
 			foreach ($attach_row as $key => $value)

[stevemaury]

phpBB should have released a 3.2.2-pl1 or something, containing the fixes for the three major bugs reported so far! Many won't know how to fix, and there is going to be months of questions all asking for help on the same issues.

Yeah, they in fact should have tested this them selves to see if there were any issues. I don't know what they do, but they should have a site dedicated for testing. Upload the new release and look for issues. Seems common sense to me.

Do you really think we don't test?

[Mick]

How many have updated without a problem?

[canonknipser]

And everybody is invited to help in testing new releases, patches etc.: https://wiki.phpbb.com/Get_Involved#Reproducing_Bugs - when more people help testing, the result will be much better

[Lumpy Burgertushie]

Keep in mind that the number of people that come here because they have a problem is very small compared to the number of people that install with no issues at all. We never hear from all those thousands and thousands of people.

rob ert

[Marc]

phpBB should have released a 3.2.2-pl1 or something, containing the fixes for the three major bugs reported so far! Many won't know how to fix, and there is going to be months of questions all asking for help on the same issues.

Yeah, they in fact should have tested this them selves to see if there were any issues. I don't know what they do, but they should have a site dedicated for testing. Upload the new release and look for issues. Seems common sense to me.

That's exactly what us and others did. Still, these issues were unfortunately missed.
In fact, I myself tested a fully functional version of 3.2.2 and these updates / upgrades before the 3.2.2 release:

• Update from 3.2.2-RC1 to 3.2.2
• Update from 3.2.1 to 3.2.2
• Update from 3.1.11 to 3.2.2
• Update from 3.1.12 to 3.2.2
• Upgrade from 3.0.14 to 3.2.2
• Upgrade from 3.0.0 to 3.2.2 (actually had to tweak 3.0.0 to run on PHP 5.6)
• Conversion from 2.0.23 to 3.2.2

Internally we also opted for releasing 3.2.3 soon instead of hastily putting out a 3.2.2-pl1 release. Issues like the disappearing attachments on preview only prove that this was a wise decision.

[canonknipser]

disappearing attachments on preview only

That is not correct - the attachments also disappear on post editing. And preview is on of the most useful function when creating a long post, esp. because there is no (builtin / working) WYSIWYG-Editor

[lopoto]

How many have updated without a problem?

me

[Forex Station]

The + in the first columns means "Add the Line", the - means "Remove the line",
so your code should look like:

Code: Select all

 		// We display the posted attachments within the desired order.
 		($config['display_order']) ? krsort($attachment_data) : ksort($attachment_data);
 
		$attachrow_template_vars = [];

 		foreach ($attachment_data as $count => $attach_row)
 		{
 			$hidden = '';

 			$attach_row['real_filename'] = utf8_basename($attach_row['real_filename']);
 
 			foreach ($attach_row as $key => $value)

Thank you so much for your instructions, I've done that and it works well! Cheers.

[mrix2000]

Worked for me and no more complaints from my members
Thanks
mrix

[Scanialady]

How many have updated without a problem?

All who have been waiting for a few days and/or read in the forum

[</Solidjeuh>]

How many have updated without a problem?

I updated the day of the release without any problems.

[paulie]

And it is for these very reasons that I'm still running 3.2.0 despite being reminded in the ACP on a daily basis that my "phpBB installation is not up to date". Why would I choose to introduce 'update issues' when everything is currently hunky dory?

My 3.2.0 works fine, I'll stay as I am thanks all the same.