Disapearing attachments after update to 3.2.2

Get help with installation and running phpBB 3.2.x here. Please do not post bug reports, feature requests, or extension related questions here.
Lucan
Registered User
Posts: 39
Joined: Fri Jun 13, 2008 10:24 pm

Re: Disapearing attachments after update to 3.2.2

Post by Lucan » Sat Jan 13, 2018 9:14 am

/edit
done

Jimmy_Jamblez
Registered User
Posts: 36
Joined: Thu Apr 06, 2017 2:26 pm

Re: Disapearing attachments after update to 3.2.2

Post by Jimmy_Jamblez » Sat Jan 13, 2018 11:39 am

3Di wrote:
Sat Jan 13, 2018 6:44 am
^^ but's wrong ^^ ;)

See here https://github.com/phpbb/phpbb/pull/5082/files
Hey thanks for the link, do I just copy, paste and replace into my current functions_posting.php with the text from Github link over the old parts?

Code: Select all

 		// We display the posted attachments within the desired order.
 		($config['display_order']) ? krsort($attachment_data) : ksort($attachment_data);
 
+		$attachrow_template_vars = [];
+
 		foreach ($attachment_data as $count => $attach_row)
 		{
 			$hidden = '';
-			$attachrow_template_vars = array();
 			$attach_row['real_filename'] = utf8_basename($attach_row['real_filename']);
 
 			foreach ($attach_row as $key => $value)

User avatar
canonknipser
Registered User
Posts: 1623
Joined: Thu Sep 08, 2011 4:16 am
Location: Germany
Name: Frank Jakobs
Contact:

Re: Disapearing attachments after update to 3.2.2

Post by canonknipser » Sat Jan 13, 2018 4:07 pm

The + in the first columns means "Add the Line", the - means "Remove the line",
so your code should look like:

Code: Select all

 		// We display the posted attachments within the desired order.
 		($config['display_order']) ? krsort($attachment_data) : ksort($attachment_data);
 
		$attachrow_template_vars = [];

 		foreach ($attachment_data as $count => $attach_row)
 		{
 			$hidden = '';

 			$attach_row['real_filename'] = utf8_basename($attach_row['real_filename']);
 
 			foreach ($attach_row as $key => $value)
Greetings, Frank
phpbb.de support team member
English is not my native language - no support via PM or mail
New arrival - Extensions and scripts for phpBB

User avatar
stevemaury
Support Team Member
Support Team Member
Posts: 49557
Joined: Thu Nov 02, 2006 12:21 am
Location: The U.P.
Name: Steve
Contact:

Re: Disapearing attachments after update to 3.2.2

Post by stevemaury » Sat Jan 13, 2018 6:28 pm

John connor wrote:
Fri Jan 12, 2018 11:53 pm
WelshPaul wrote:
Fri Jan 12, 2018 9:04 am
phpBB should have released a 3.2.2-pl1 or something, containing the fixes for the three major bugs reported so far! Many won't know how to fix, and there is going to be months of questions all asking for help on the same issues.


Yeah, they in fact should have tested this them selves to see if there were any issues. I don't know what they do, but they should have a site dedicated for testing. Upload the new release and look for issues. Seems common sense to me.
Do you really think we don't test?
For REALLY good and VERY inexpensive hosting CLICK HERE

I can stop all your spam. PM or email me.

All unsolicited PMs will be ignored.

User avatar
Mick
Support Team Member
Support Team Member
Posts: 20134
Joined: Fri Aug 29, 2008 9:49 am
Location: Cardiff

Re: Disapearing attachments after update to 3.2.2

Post by Mick » Sat Jan 13, 2018 6:31 pm

How many have updated without a problem?
"The more connected we get the more alone we become" - Kyle Broflovski

There are no ‘threads’ in phpBB, they are topics.

User avatar
canonknipser
Registered User
Posts: 1623
Joined: Thu Sep 08, 2011 4:16 am
Location: Germany
Name: Frank Jakobs
Contact:

Re: Disapearing attachments after update to 3.2.2

Post by canonknipser » Sat Jan 13, 2018 7:03 pm

And everybody is invited to help in testing new releases, patches etc.: https://wiki.phpbb.com/Get_Involved#Reproducing_Bugs - when more people help testing, the result will be much better
Greetings, Frank
phpbb.de support team member
English is not my native language - no support via PM or mail
New arrival - Extensions and scripts for phpBB

User avatar
Lumpy Burgertushie
Registered User
Posts: 65052
Joined: Mon May 02, 2005 3:11 am
Contact:

Re: Disapearing attachments after update to 3.2.2

Post by Lumpy Burgertushie » Sat Jan 13, 2018 9:07 pm

Keep in mind that the number of people that come here because they have a problem is very small compared to the number of people that install with no issues at all. We never hear from all those thousands and thousands of people.

rob ert
I am available for custom work on a donation basis. Please send me a PM with your needs.

Premium phpBB 3.2 Styles by PlanetStyles.net

OK, so what's the speed of dark?

User avatar
Marc
Development Team Leader
Development Team Leader
Posts: 5315
Joined: Tue Oct 30, 2007 10:57 pm
Location: Munich, Germany
Name: Marc
Contact:

Re: Disapearing attachments after update to 3.2.2

Post by Marc » Sun Jan 14, 2018 2:47 pm

John connor wrote:
Fri Jan 12, 2018 11:53 pm
WelshPaul wrote:
Fri Jan 12, 2018 9:04 am
phpBB should have released a 3.2.2-pl1 or something, containing the fixes for the three major bugs reported so far! Many won't know how to fix, and there is going to be months of questions all asking for help on the same issues.


Yeah, they in fact should have tested this them selves to see if there were any issues. I don't know what they do, but they should have a site dedicated for testing. Upload the new release and look for issues. Seems common sense to me.
That's exactly what us and others did. Still, these issues were unfortunately missed.
In fact, I myself tested a fully functional version of 3.2.2 and these updates / upgrades before the 3.2.2 release:
  • Update from 3.2.2-RC1 to 3.2.2
  • Update from 3.2.1 to 3.2.2
  • Update from 3.1.11 to 3.2.2
  • Update from 3.1.12 to 3.2.2
  • Upgrade from 3.0.14 to 3.2.2
  • Upgrade from 3.0.0 to 3.2.2 (actually had to tweak 3.0.0 to run on PHP 5.6)
  • Conversion from 2.0.23 to 3.2.2
Internally we also opted for releasing 3.2.3 soon instead of hastily putting out a 3.2.2-pl1 release. Issues like the disappearing attachments on preview only prove that this was a wise decision.

User avatar
canonknipser
Registered User
Posts: 1623
Joined: Thu Sep 08, 2011 4:16 am
Location: Germany
Name: Frank Jakobs
Contact:

Re: Disapearing attachments after update to 3.2.2

Post by canonknipser » Sun Jan 14, 2018 4:09 pm

Marc wrote:
Sun Jan 14, 2018 2:47 pm
disappearing attachments on preview only
That is not correct - the attachments also disappear on post editing. And preview is on of the most useful function when creating a long post, esp. because there is no (builtin / working) WYSIWYG-Editor
Greetings, Frank
phpbb.de support team member
English is not my native language - no support via PM or mail
New arrival - Extensions and scripts for phpBB

User avatar
lopoto
Registered User
Posts: 86
Joined: Thu Feb 12, 2015 3:13 pm

Re: Disapearing attachments after update to 3.2.2

Post by lopoto » Sun Jan 14, 2018 5:02 pm

Mick wrote:
Sat Jan 13, 2018 6:31 pm
How many have updated without a problem?
me :D

Jimmy_Jamblez
Registered User
Posts: 36
Joined: Thu Apr 06, 2017 2:26 pm

Re: Disapearing attachments after update to 3.2.2

Post by Jimmy_Jamblez » Mon Jan 15, 2018 10:53 am

canonknipser wrote:
Sat Jan 13, 2018 4:07 pm
The + in the first columns means "Add the Line", the - means "Remove the line",
so your code should look like:

Code: Select all

 		// We display the posted attachments within the desired order.
 		($config['display_order']) ? krsort($attachment_data) : ksort($attachment_data);
 
		$attachrow_template_vars = [];

 		foreach ($attachment_data as $count => $attach_row)
 		{
 			$hidden = '';

 			$attach_row['real_filename'] = utf8_basename($attach_row['real_filename']);
 
 			foreach ($attach_row as $key => $value)
Thank you so much for your instructions, I've done that and it works well! Cheers.

mrix2000
Registered User
Posts: 581
Joined: Sun Dec 03, 2006 2:23 pm

Re: Disapearing attachments after update to 3.2.2

Post by mrix2000 » Mon Jan 15, 2018 1:32 pm

Worked for me and no more complaints from my members :D 8-)
Thanks
mrix

User avatar
Scanialady
Registered User
Posts: 207
Joined: Thu Jan 17, 2013 7:09 pm
Location: Germany
Name: Annette
Contact:

Re: Disapearing attachments after update to 3.2.2

Post by Scanialady » Tue Jan 16, 2018 12:55 pm

Mick wrote:
Sat Jan 13, 2018 6:31 pm
How many have updated without a problem?
All who have been waiting for a few days and/or read in the forum :lol:
Webseite, Blog, Wiki
JV-Arcade / phpBB-Arcade / dmzx-Extensions Übersetzungsteam, andere deutsche Übersetzungen - german language files

User avatar
</Solidjeuh>
Registered User
Posts: 1021
Joined: Tue Mar 29, 2016 3:45 am
Location: Aalst (Belgium)
Name: Andy Dm
Contact:

Re: Disapearing attachments after update to 3.2.2

Post by </Solidjeuh> » Tue Jan 16, 2018 1:37 pm

Mick wrote:
Sat Jan 13, 2018 6:31 pm
How many have updated without a problem?
I updated the day of the release without any problems.
We offer fun HTML5 games for young and old.
Register a free account & enjoy all functions!
Save your score, challenge other members or play along with our tournaments.


~~~ https://www.solidjeuh.be ~~~

User avatar
paulie
Registered User
Posts: 74
Joined: Thu Mar 30, 2017 3:41 pm
Location: Hull, East Yorkshire.

Re: Disapearing attachments after update to 3.2.2

Post by paulie » Tue Jan 16, 2018 1:53 pm

And it is for these very reasons that I'm still running 3.2.0 despite being reminded in the ACP on a daily basis that my "phpBB installation is not up to date". Why would I choose to introduce 'update issues' when everything is currently hunky dory?

My 3.2.0 works fine, I'll stay as I am thanks all the same.
'Life in the Air Age isn't all the brochures say ...'

Post Reply

Return to “[3.2.x] Support Forum”

Who is online

Users browsing this forum: enter a valid email, pikachuturkey, WelshPaul and 70 guests