Word Censor needs an overhaul

mamba · Post by **mamba** » Fri Jul 13, 2018 2:17 am

The word censor unfortunately messes with things it should not, like links.

Example: you have a word censor that changes the word "crap" to "cr*p"

Then you discover the links to images that contain the string crap, like

Code: Select all

http:www.example.com/scrap.jpg

is now broken because it was altered to

Code: Select all

http:www.example.com/scr*p.jpg

Why is the word censor messing with URLs?

It should not be difficult to make it avoid protected content. BTW it also alters text inside BBcode html, and so on.

Needs to be fixed!

david63 · Post by **david63** » Fri Jul 13, 2018 5:17 am

Firstly there are some users who actually want that to happen and secondly if you believe that this is incorrect behaviour then create a bug report.

mamba · Post by **mamba** » Fri Jul 13, 2018 5:23 am

david63 wrote: ↑Fri Jul 13, 2018 5:17 am Firstly there are some users who actually want that to happen

Please explain. Why on earth would you want a word censor to alter html?

and secondly if you believe that this is incorrect behaviour then create a bug report.

I'm time poor

mamba · Post by **mamba** » Fri Jul 13, 2018 5:53 am

david63 wrote: ↑Fri Jul 13, 2018 5:17 am if you believe that this is incorrect behaviour then create a bug report.

LOL, it's been reported over and over and over .....

https://tracker.phpbb.com/browse/PHPBB3-9809 (Rejected by A_Jelly_Doughnut in 2010 with "Definitely working as intended. Censoring words in URLs is a common request")

I do see that some people are abusing the word censor to modify URLs deliberately, which IMO is not why it exists at all. There should be an option on the word censoring panel in ACP to disable parsing of URLs.

Other reports:
https://tracker.phpbb.com/browse/PHPBB3-7709 (rejected as "expected behaviour")
https://tracker.phpbb.com/browse/PHPBB3-7385 (closed for no good reason)
https://tracker.phpbb.com/browse/PHPBB3-7195 (closed for no good reason)

Post by **Mick** » Fri Jul 13, 2018 6:45 am

mamba wrote: ↑Fri Jul 13, 2018 5:23 amI'm time poor

Aren’t we all.

mamba wrote: ↑Fri Jul 13, 2018 5:53 amThere should be an option on the word censoring panel in ACP to disable parsing of URLs

Try a different approach, post an idea.

FWIW - I also believe it works as expected:

“Tracker” wrote:Some would consider it a feature, others a bug. But it will not change in 3.0.

and I wouldn’t expect it in 3.2 either.

mamba · Post by **mamba** » Fri Jul 13, 2018 7:02 am

Mick wrote: ↑Fri Jul 13, 2018 6:45 am Try a different approach, post an idea.

Done
viewtopic.php?f=436&t=2478776