Page 1 of 3

Known issues in 3.2.4

Posted: Sat Nov 17, 2018 10:35 pm
by Marc
After the release of phpBB 3.2.4 we've noticed an issue that can affect users with extensions that employ the generate_text_for_display() function.
A fix for this can be found on Github and will be included in the 3.2.5 release:
https://github.com/phpbb/phpbb/pull/5448/files

Re: Known issues in 3.2.4

Posted: Sat Nov 17, 2018 10:52 pm
by 3Di
Thumbs up. :)

Re: Known issues in 3.2.4

Posted: Sat Nov 17, 2018 11:01 pm
by </Solidjeuh>
Thank you for the fix :D

Re: Known issues in 3.2.4

Posted: Sun Nov 18, 2018 12:22 am
by P_I
Marc wrote:
Sat Nov 17, 2018 10:35 pm
After the release of phpBB 3.2.4 we've noticed an issue that can affect users with extensions that employ the generate_text_for_display() function.
A fix for this can be found on Github and will be included in the 3.2.5 release:
https://github.com/phpbb/phpbb/pull/5448
Thanks for the quick update and fix.

Has anyone started to compile a list of extensions that employ this call or is it up the end users to scan their ext directory for calls to the function before deciding to update their boards to 3.2.4.

Added: So far I've found that the Board Rules extension makes this call.

Re: Known issues in 3.2.4

Posted: Sun Nov 18, 2018 12:43 am
by 3Di
Almost all of my recent and large extensions make use of it.

Re: Known issues in 3.2.4

Posted: Sun Nov 18, 2018 8:27 am
by david63
My Privacy Policy and User Details extensions use this function.

Re: Known issues in 3.2.4

Posted: Sun Nov 18, 2018 9:31 am
by kasimi
It only affects extensions that render rich text in the old style format used in phpBB 3.1.x and earlier. In phpBB 3.2.x the content is saved in the database as XML. When calling generate_text_for_display() with XML content, the bugged code is not called. So this only affects extensions written before 3.2.x that haven't migrated to the new XML format yet. For example, mChat 2.1.x uses the new XML format exclusively and therefore is not affected, while mChat 2.0.x is.

Re: Known issues in 3.2.4

Posted: Sun Nov 18, 2018 11:46 am
by bubbathegimp
I downloaded the fix, but being a complete noob, I have no Idea of how to apply it...

Re: Known issues in 3.2.4

Posted: Sun Nov 18, 2018 12:40 pm
by P_I
kasimi wrote:
Sun Nov 18, 2018 9:31 am
It only affects extensions that render rich text in the old style format used in phpBB 3.1.x and earlier. In phpBB 3.2.x the content is saved in the database as XML. When calling generate_text_for_display() with XML content, the bugged code is not called. So this only affects extensions written before 3.2.x that haven't migrated to the new XML format yet. For example, mChat 2.1.x uses the new XML format exclusively and therefore is not affected, while mChat 2.0.x is.
Thanks for this additional information.

On the boards I'm involved with I've scanned for calls to generate_text_for_display() and so far only the Board Rules extension makes this call. Rather than dig further into the code and database, I've asked the extension developers if the extension is affected or not. Since there is a 3.2.x and 3.1.x version of the extension I'm guessing not but I'd rather have the developers confirm to be sure.

Re: Known issues in 3.2.4

Posted: Sun Nov 18, 2018 3:30 pm
by invenio
Marc wrote:
Sat Nov 17, 2018 10:35 pm
A fix for this can be found on Github and will be included in the 3.2.5 release:
Any estimate when we should see 3.2.5? If it's coming soon I would rather hold off on the update.

Re: Known issues in 3.2.4

Posted: Sun Nov 18, 2018 3:30 pm
by rxu
The issue also affects boards freshly converted from 2.0/3.0/3.1 to 3.2 (where text is not reparsed to XML yet).

Re: Known issues in 3.2.4

Posted: Sun Nov 18, 2018 3:45 pm
by Swanny
Can you update the 3.2.4 code package right now so people from now on doing the upgrade aren't affected? I haven't upgraded to 3.2.4 yet, I usually wait a few days after release in case there are known "bugs".

Re: Known issues in 3.2.4

Posted: Sun Nov 18, 2018 7:45 pm
by Forex Station
Swanny wrote:
Sun Nov 18, 2018 3:45 pm
Can you update the 3.2.4 code package right now so people from now on doing the upgrade aren't affected? I haven't upgraded to 3.2.4 yet, I usually wait a few days after release in case there are known "bugs".
Same here haha. I get a bit nervous now with the updates. Even though we don't run many extensions we've had a couple of issues in the past like that one update that made it unable to upload attachments. Everyone on our forum had a fit :shock:

Re: Known issues in 3.2.4

Posted: Sun Nov 18, 2018 7:55 pm
by Crizzo
Swanny wrote:
Sun Nov 18, 2018 3:45 pm
Can you update the 3.2.4 code package right now so people from now on doing the upgrade aren't affected? I haven't upgraded to 3.2.4 yet, I usually wait a few days after release in case there are known "bugs".
This would lead to two different versions with the same name/number and would lead to a mess.

Re: Known issues in 3.2.4

Posted: Sun Nov 18, 2018 8:11 pm
by janus_zonstraal
And offer a download with know errors will lead not to a mess?
Why not give it a other name as phpbb did in the past? phpbb3.2.4_fix