Page 2 of 4

Re: Not able to log in anymore after update to 3.2.6

Posted: Mon Apr 29, 2019 3:32 pm
by </Solidjeuh>
Hmz problem was solved here by adding those changes in index_body.html & login_body.html & in the quick login ext. Strange that it's not working on your new installed forum :o

Re: Not able to log in anymore after update to 3.2.6

Posted: Mon Apr 29, 2019 4:28 pm
by EA117
david63 wrote:
Mon Apr 29, 2019 3:20 pm
I am not convinced that this is a template issue.
Understandable. For what it's worth, what this brings to mind for me is that we've certainly seen "invalid form" reports here in the support forums before, with seemingly just some generic "we've seen that happen with Chrome" and "toss your cookies"-type suggestions to try and resolve it.

Without {S_FORM_TOKEN_LOGIN} in the template to include the output of add_form_key() in the HTML <form> fields, it's impossible for check_form_key() to succeed, and therefore impossible for the updated phpBB 3.2.6 login_box() function to avoid throwing INVALID_FORM. It's existence in the login form is entirely new to phpBB 3.2.6, and you won't succeed without it.

But that's separate and distinct from "this would be the only reason you'll ever see INVALID_FORM"; in any form, not just specifically the newly-updated login form. I'd suspect that in the clean install you're looking at, everything about the template and phpBB 3.2.6-specific changes actually are working exactly as you expect it should.

And the "invalid form" result you're seeing is being calculated because of something being wrong with the time value calculation, something wrong with add_form_key()'s ability to insert the form fields into the document, or whatever other nebulous causes of "invalid form" are at the root of why we see this reported in the forum from time to time.

For what it's worth, if that helps exploring what the actual root cause is.

Re: Not able to log in anymore after update to 3.2.6

Posted: Mon Apr 29, 2019 4:31 pm
by celticalliance
Forums updated to 3.2.6 and changes made to the two files EA117 mentioned. No issues whatsoever now :)

Re: Not able to log in anymore after update to 3.2.6

Posted: Mon Apr 29, 2019 4:44 pm
by EA117
EA117 wrote:
Mon Apr 29, 2019 4:28 pm
...or whatever other nebulous causes of "invalid form" are at the root of why we see this reported in the forum from time to time.
I could have said that with even more clarity: "...or whatever other nebulous causes of "invalid form" are at the root of why we see this reported in the forum from time to time even before phpBB 3.2.6."

Meaning whatever reasons we've seen "invalid form" occasionally occur prior to phpBB 3.2.6 (but never in the login form) now are possible to occur in an otherwise correctly-updated and correctly-supported phpBB 3.2.6 login form.

Re: Not able to log in anymore after update to 3.2.6

Posted: Tue Apr 30, 2019 4:37 pm
by Tastenplayer
If I remove the prosilver change in the index_body.html {S_FORM_TOKEN_LOGIN}, I can log in anywhere without any problems :lol:

Edit: It's quite annoying that in phpbb3.2.6, if I are working on the styles, after changing to another style you get logged out and have to log in again. In general you get logged out from time to time and have to log in again.
Especially if you want to test the responsive view in Firefox, this happens with every display size changing.
I haven`t mark remember me.
This can't be a server problem, because my board is local on the PC. Otherwise I have no internet connection problems. In other phpbb versions I do not have this problem.

Re: Not able to log in anymore after update to 3.2.6

Posted: Tue Apr 30, 2019 6:52 pm
by canonknipser
Tastenplayer wrote:
Tue Apr 30, 2019 4:37 pm
This can't be a server problem, because my board is local on the PC
In that case your local PC is the server ...

Re: Not able to log in anymore after update to 3.2.6

Posted: Tue Apr 30, 2019 6:54 pm
by Tastenplayer
I know :D that's why I wrote that this never happens to me with other phpbb version boards. They are all installed locally in Quickinstall.
In my new online Styleforum 3.2.5 with the same php version (7.1.28) this never happens to me either. Is still under construction but I'm working there permanently. :lol: https://www.phpbb-skins-by.koliofotis.ch/

Re: Not able to log in anymore after update to 3.2.6

Posted: Wed May 01, 2019 10:30 am
by thetgc
So I made the mistake of updating my forum to 3.2.6 this morning and although everything appeared to work fine it seems we now have the login issue.

It is quite a buys forum so I need to get it sorted asap.

If I want to roll back to 3.2.5 how would I do that? Simply replace most of the existing files with the ones from 3.2.5? Apart from config, ext and so on of course.

Or would Tastenplayer's fix by removing {S_FORM_TOKEN_LOGIN} from the index_body.html do the job without compromising anything?

Thanks in advance.

Re: Not able to log in anymore after update to 3.2.6

Posted: Wed May 01, 2019 11:54 am
by kinerity
Incorporate the fixes here. If you want to go back to 3.2.5, you will need to restore the 3.2.5 files as well as a backup of the database before you upgraded.

Re: Not able to log in anymore after update to 3.2.6

Posted: Wed May 01, 2019 12:58 pm
by thetgc
Thanks for the info. Tried the fixes but still not working :(

Re: Not able to log in anymore after update to 3.2.6

Posted: Wed May 01, 2019 1:00 pm
by EA117
kinerity wrote:
Wed May 01, 2019 11:54 am
Incorporate the fixes here. If you want to go back to 3.2.5, you will need to restore the 3.2.5 files as well as a backup of the database before you upgraded.
Note that "incorporate Pull 5578 changes" solves the problem only if the style in use is already 100% phpBB 3.2.6-compliant. i.e. Your style already had the index_body.html or login_body.html changes that shipped in phpBB 3.2.6 itself, and your board only needs the additional login_forum.html or viewforum_body.html fixes, which are broken even when using the phpBB 3.2.6-shipped proSilver.

Since "which style are they using" hasn't even been stated yet, the common issue here has been that they need to add phpBB 3.2.6 changes to the index_body.html or login_body.html of whichever non-proSilver style they're using (i.e. consume the changes which did ship in phpBB 3.2.6 proSilver), in addition to then also needing to make the Pull 5578 template and code changes in order to fix "everywhere else".

thetgc wrote:
Wed May 01, 2019 10:30 am
Or would Tastenplayer's fix by removing {S_FORM_TOKEN_LOGIN} from the index_body.html do the job without compromising anything?
If you are on phpBB 3.2.6, removing {S_FORM_TOKEN_LOGIN} from the index_body.html doesn't solve the problem. That even is the problem, when you're using a style which hasn't been updated for phpBB 3.2.6 yet -- the {S_FORM_TOKEN_LOGIN} is missing. The login_box() function in phpBB 3.2.6 now requires those fields to be part of the login form fields, and a template that doesn't include {S_FORM_TOKEN_LOGIN} won't have those fields.

So I can't say yet what has led to Tastenplayer's observation in that regard, but it doesn't jive with my current understanding or expectations of the problem.

Re: Not able to log in anymore after update to 3.2.6

Posted: Wed May 01, 2019 1:29 pm
by thetgc
Thanks again. I am using Prosilver and the fixes still don't work. No one can log into the forum :(

Problem is I can't even access the admin page now.

Would it not be a good idea for the PHPBB team to update the download with the fixes or have they already done so? Still, the fixes don't work for me so that is probably a moot point.

Rolling back to 3.2.5 is a last resort because we will lose a load of posts and new member sign ups.

Re: Not able to log in anymore after update to 3.2.6

Posted: Wed May 01, 2019 1:41 pm
by EA117
Hopefully this might be a useful summary of what is expected.

With the release of phpBB 3.2.6, performing a login now requires a "form token", and results in "the submitted form is invalid" when those form token fields don't exist. The primary login forms in the phpBB 3.2.6 proSilver style were updated to include these form tokens, but if you're using a non-proSilver style the login forms on your board may not attempt to include these form tokens in the login forms. Note this can happen even if your style is proSilver-based and inherits from proSilver, since your style may have overridden and replaced the templates that define the login forms. In addition to all that, there were also some login forms in phpBB 3.2.6 proSilver which mistakenly did not get updated, and those need to be fixed as well.

To fix the known login issues while keeping phpBB 3.2.6:
  1. If your currently selected style is anything other than proSilver, check the template directory of the selected style for the existence of a "index_body.html" template. If this file does not exist, there is no change needed. If this file does exist, add {S_FORM_TOKEN_LOGIN} to the index_body.html template of your style, as demonstrated here.
    • If your currently selected style is anything other than proSilver, check the template directory of the selected style for the existence of a "login_body.html" template. If this file does not exist, there is no change needed. If this file does exist, add {S_FORM_TOKEN_LOGIN} to the login_body.html template of your style, as demonstrated here.
      • For any style you are using, even if that style is the phpBB 3.2.6-delivered proSilver, add {S_FORM_TOKEN_LOGIN} to the "login_forum.html" template, as demonstrated here. If you have a proSilver-inheriting style, your selected style may not contain this template, and you need to make this change in proSilver instead of your selected style.
        • For any style you are using, even if that style is the phpBB 3.2.6-delivered proSilver, add {S_FORM_TOKEN_LOGIN} to the "viewforum_body.html" template, as demonstrated here. If you have a proSilver-inheriting style, your selected style may not contain this template, and you need to make this change in proSilver instead of your selected style.
          • Apply the fix to phpBB 3.2.6's "/includes/functions.php" after line 2666, as demonstrated here.
            • Apply the fix to phpBB 3.2.6's "/viewforum.php" after line 200, as demonstrated here.
              • Flush the phpBB cache so that the templates you've modified will be used immediately. If unable to login to ACP to flush the cache, manually delete the files and directories in the phpBB /cache directory except for index.html and .htaccess, using FTP access or your hosting control panel's file manager.

              Edit: Updated steps 3 and 4 to acknowledge you may need to edit proSilver templates instead of your selected style.
              Edit: Updated step 7 to confirm removing both files and directories.

              Re: Not able to log in anymore after update to 3.2.6

              Posted: Wed May 01, 2019 1:45 pm
              by EA117
              thetgc wrote:
              Wed May 01, 2019 1:29 pm
              Thanks again. I am using Prosilver and the fixes still don't work. No one can log into the forum :(
              I'm wondering if maybe step 7 in the list I just posted might be all that's missing in your case. i.e. The edits were done successfully, but the current cache still has forms built using the old templates. You may have already done that, but mentioning just in case.

              Re: Not able to log in anymore after update to 3.2.6

              Posted: Wed May 01, 2019 1:58 pm
              by thetgc
              Interesting thing about point 7 there. Can't access the admin panel but I can of course access the cache folder via FTP. However, I don't have anything in there except two other folders, installer and production. Something not right there?