Default theme problems with google

For support and discussion related to templates, themes, and imagesets in phpBB 3.2.
Post Reply
garfy
Registered User
Posts: 418
Joined: Sun Jul 25, 2004 8:37 am

Default theme problems with google

Post by garfy »

I just got notices from google that some elements are too close for good user experience.....

And also that the text is too small

Why is that not fixed? I am using default theme
Last edited by thecoalman on Tue Mar 19, 2019 10:28 pm, edited 1 time in total.
Reason: Moved to Styles Support
User avatar
</Solidjeuh>
Registered User
Posts: 1788
Joined: Tue Mar 29, 2016 3:45 am
Location: Aalst (Belgium)
Name: Andy Dm
Contact:

Re: Default theme problems with google

Post by </Solidjeuh> »

It could be some of your extensions. Or the banners/Subscribe at the bottom ..
User avatar
thecoalman
Community Team Member
Community Team Member
Posts: 5871
Joined: Wed Dec 22, 2004 3:52 am
Location: Pennsylvania, U.S.A.
Contact:

Re: Default theme problems with google

Post by thecoalman »

You can change the font size with one edit of CSS file. At the top of common.css find:

Code: Select all

body {
	font-family: Verdana, Helvetica, Arial, sans-serif;
	font-size: 10px;
Try :

Code: Select all

body {
	font-family: Verdana, Helvetica, Arial, sans-serif;
	font-size: 12px;
“Results! Why, man, I have gotten a lot of results! I have found several thousand things that won’t work.”

Attributed - Thomas Edison
garfy
Registered User
Posts: 418
Joined: Sun Jul 25, 2004 8:37 am

Re: Default theme problems with google

Post by garfy »

I just suggest these should be changed by default.....cause probably other peolple get it too
User avatar
Hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 1065
Joined: Wed Dec 30, 2009 8:14 am
Name: Michael Miday
Contact:

Re: Default theme problems with google

Post by Hanakin »

this is being worked. The next release will have a slightly bigger font size and in the new theme it will all be handled in a far cleaner way with a much more appropirate size font. The problem is the current default theme is very old and the code is very volitale. It was using em units which componed font-sizes resulting in very small font-sizes.

run the same test on https://area51.phpbb.com/phpBB to see the difference
User avatar
thecoalman
Community Team Member
Community Team Member
Posts: 5871
Joined: Wed Dec 22, 2004 3:52 am
Location: Pennsylvania, U.S.A.
Contact:

Re: Default theme problems with google

Post by thecoalman »

em is relative to base font size, yes? Isn't setting them to a static size going to be difficult if you wish to change the font size forum wide?
“Results! Why, man, I have gotten a lot of results! I have found several thousand things that won’t work.”

Attributed - Thomas Edison
User avatar
Hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 1065
Joined: Wed Dec 30, 2009 8:14 am
Name: Michael Miday
Contact:

Re: Default theme problems with google

Post by Hanakin »

First the spec has changed for px in all browsers IE 9 and up so that its scaleable.

no em is not relative to base font size that is rem. Em is a relative unit to the parent element based on the base font size. So if you set the body to 10px font size then set div.main to 1.6em its 16px but if you then set another div.section in div.main 1.2em would be (16*1.2) not (10 * 1.2) then set a button in that div to 1em in div.section its equal to (16 * 1).

Over years and a large spageti codebase this grows exponentially out of control...you end up with (10*1.6*0.5*2.1*0.9*0.8*0.7*1.2*1.*0.9...)

Also changing the font-size forum wide is a horible practice! just youe browser scale + -

In the new theme we are using px for development and then have a build step to convert it all to rems for production but we are also using standard componet sizing based on material design laguage font-sizes
garfy
Registered User
Posts: 418
Joined: Sun Jul 25, 2004 8:37 am

Re: Default theme problems with google

Post by garfy »

when will the new theme be ready?
User avatar
david63
Registered User
Posts: 20646
Joined: Thu Dec 19, 2002 8:08 am

Re: Default theme problems with google

Post by david63 »

garfy wrote: Wed Mar 20, 2019 7:53 am when will the new theme be ready?
Standard answer - it will be ready when it is ready.

My best guess would be not before the end of the year.
David
Remember: You only know what you know and - you don't know what you don't know!

I now no longer support any of my extensions but they will start to become available here
User avatar
Hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 1065
Joined: Wed Dec 30, 2009 8:14 am
Name: Michael Miday
Contact:

Re: Default theme problems with google

Post by Hanakin »

the new theme is far away unfortunately probably not this year but as I stated, I did introduce a fix to prosilver which may make it into 3.3 potentially which should get out this year.
Post Reply

Return to “[3.2.x] Styles Support & Discussion”