Page 2 of 2

Re: How to center logo in 3.2?

Posted: Wed Jan 11, 2017 3:59 pm
by Christian 2.0
david63 wrote:
Wed Jan 11, 2017 12:53 pm
On the other hand if I wanted to make several changes to the style that I used then I would, as should everyone else in my opinion, create a "child" style with those changes in it.
Exactly, that would be the better solution. But that's not an extension is it? ;)

Re: How to center logo in 3.2?

Posted: Wed Jan 11, 2017 4:18 pm
by david63
Christian 2.0 wrote:
Wed Jan 11, 2017 3:59 pm
But that's not an extension is it?
Agreed - but neither is it modifying core code

Re: How to center logo in 3.2?

Posted: Wed Jan 11, 2017 4:41 pm
by Lumpy Burgertushie
Volksdevil wrote:
Wed Jan 11, 2017 1:22 pm
It would be far less problematic if those who do modify were catered for... :roll:


you are catered to as you always have been, that is what the auto update is for. I would assume that anyone that is making core code changes would have enough knowledge to be able to use the auto update method properly. however, for most people, that method is just not needed for an update/upgrade.

as for styles; not every update requires changes to the style files. therefore, I think it is much easier to just create a child style that inherits from prosilver if you are going to make any changes to it at all.
that way, when you do an update, you just replace all old files with new and IF there are any needed style changes you do them only to the child style manually.


robert

Re: How to center logo in 3.2?

Posted: Wed Jan 11, 2017 6:50 pm
by Volksdevil
Lumpy Burgertushie wrote:
Wed Jan 11, 2017 4:41 pm
Volksdevil wrote:
Wed Jan 11, 2017 1:22 pm
It would be far less problematic if those who do modify were catered for... :roll:
you are catered to as you always have been, that is what the auto update is for. I would assume that anyone that is making core code changes would have enough knowledge to be able to use the auto update method properly. however, for most people, that method is just not needed for an update/upgrade.
robert
The problem is Robert...for how long? Especially as I constantly see moderators telling us we 'Shouldn't be modifying core code'. It's plain to see that phpBB is leaning towards being less and less customisable. As discussed in other topics, some changes are just too insignificant code wise to be achieved via the use of an extension.

Also this time, there are quite a few errors using the auto update. Even the link in the ACP is incorrect. (The devs know this at least).

Re: How to center logo in 3.2?

Posted: Thu Jan 12, 2017 12:56 am
by Maroon Caludin
Christian 2.0 wrote:
Wed Jan 11, 2017 10:26 am
Hello :)

Please disregard the advice above, you should not use extensions for making visual changes to your style.

I've checked your forum and it looks like your default style is prosilver. Based on your reply above it sounds like you were hoping to center the logo on a different style?

Should be a simple CSS edit if you can let me know which style you'd like to achieve this on :)
Just on my style I made based on pro silver.

I had done this in colors.css


From colors.css:

Code: Select all

.site_logo {

	background-image: url("./images/site_logo.gif");
background-size: 700px 300px;
padding-left: 590px;


	padding-top: 270px;
background-repeat: no-repeat;

}
But could not get it to center without the extension. I'd prefer to do it without it if there is a way.

Re: How to center logo in 3.2?

Posted: Thu Jan 12, 2017 1:22 am
by Lumpy Burgertushie
overall_header.html
find and remove or comment out or move to the navbar:

Code: Select all

<!-- IF S_DISPLAY_SEARCH and not S_IN_SEARCH -->
			<div id="search-box" class="search-box search-header" role="search">
				<form action="{U_SEARCH}" method="get" id="search">
				<fieldset>
					<input name="keywords" id="keywords" type="search" maxlength="128" title="{L_SEARCH_KEYWORDS}" class="inputbox search tiny" size="20" value="{SEARCH_WORDS}" placeholder="{L_SEARCH_MINI}" />
					<button class="button icon-button search-icon" type="submit" title="{L_SEARCH}">{L_SEARCH}</button>
					<a href="{U_SEARCH}" class="button icon-button search-adv-icon" title="{L_SEARCH_ADV}">{L_SEARCH_ADV}</a>
					{S_SEARCH_HIDDEN_FIELDS}
				</fieldset>
				</form>
			</div>
			<!-- ENDIF -->

open common.css

search:


Code: Select all

 .logo {
	float: left;
	width: auto;
	padding: 10px 13px 0 10px;
}


replace with:


Code: Select all

    #logo {
       float: left;
       width: 100%;
       padding: 10px 13px 0 10px;
       text-align: center;
    }

search:


Code: Select all

    #site-description {
       float: left;
       width: 65%;
    }

replace with:


Code: Select all

    #site-description {
       float: left;
       width: 100%;
    }
purge the cache, refresh your browser.

robert

Re: How to center logo in 3.2?

Posted: Thu Jan 12, 2017 1:41 am
by Maroon Caludin
That worked perfect! Thanks so much! *hug* Its been driving me nuts!

Re: How to center logo in 3.2?

Posted: Thu Jan 12, 2017 2:23 am
by Lumpy Burgertushie
great, glad to help.

now just remember that every time you have to update phpbb you will have to make these changes again unless you use a different style than prosilver.

robert