Page 1 of 2

How to center logo in 3.2?

Posted: Tue Jan 10, 2017 2:15 am
by Maroon Caludin
I was able to change my logo, but I can't figure out how to center it. The code I normally use is not working. x_x

Re: How to center logo in 3.2?

Posted: Tue Jan 10, 2017 7:36 am
by david63
This extension will that for you - viewtopic.php?f=456&t=2400186

Re: How to center logo in 3.2?

Posted: Tue Jan 10, 2017 7:17 pm
by Maroon Caludin
Is there a way to do it without an extension? Even with it I couldn't get it to center right.

Re: How to center logo in 3.2?

Posted: Tue Jan 10, 2017 7:49 pm
by Lumpy Burgertushie
it would help if we could see your board.

link please.

robert

Re: How to center logo in 3.2?

Posted: Tue Jan 10, 2017 7:57 pm
by Maroon Caludin

Re: How to center logo in 3.2?

Posted: Tue Jan 10, 2017 8:40 pm
by Lumpy Burgertushie
please turn on that logo extension and try to center it so we can see what it looks like and what the problem may be etc.


robert

Re: How to center logo in 3.2?

Posted: Tue Jan 10, 2017 8:56 pm
by Maroon Caludin
Enabled it, but it doesn't move at all. Its probably my code, but I'm not sure what to do with it anymore.

From colors.css:

Code: Select all

.site_logo {

	background-image: url("./images/site_logo.gif");
background-size: 700px 300px;
padding-left: 590px;


	padding-top: 270px;
background-repeat: no-repeat;

}
Only way I could get it to show the whole banner, but it just won't center. I was able to have it centered on the old version but can't get it to on here.

Re: How to center logo in 3.2?

Posted: Tue Jan 10, 2017 10:03 pm
by Lumpy Burgertushie
I just installed the ext on a test board. It does not work as it should.

When you choose center for the logo, it should edit the site description css to allow it to center properly.

try this, in your common.css file find this:

Code: Select all

.site-description {
    float: left;
    width: 65%;
}
either remove it or comment it out or just change both settings to none

see if that centers what you have .


robert

Re: How to center logo in 3.2?

Posted: Tue Jan 10, 2017 11:37 pm
by Maroon Caludin
Thanks! Worked great! :D

Though it does center the prosilver one too. It looks okay, but I'm curious is there a way to center the logo without the extension?

Re: How to center logo in 3.2?

Posted: Wed Jan 11, 2017 9:42 am
by Mick
Maroon Caludin wrote:
Tue Jan 10, 2017 11:37 pm
is there a way to center the logo without the extension?
Probably but editing core code isn't recommended in 3.2, that's the job of extensions.

Re: How to center logo in 3.2?

Posted: Wed Jan 11, 2017 10:26 am
by Christian 2.0
Hello :)

Please disregard the advice above, you should not use extensions for making visual changes to your style.

I've checked your forum and it looks like your default style is prosilver. Based on your reply above it sounds like you were hoping to center the logo on a different style?

Should be a simple CSS edit if you can let me know which style you'd like to achieve this on :)

Re: How to center logo in 3.2?

Posted: Wed Jan 11, 2017 11:52 am
by david63
Lumpy Burgertushie wrote:
Tue Jan 10, 2017 10:03 pm
I just installed the ext on a test board. It does not work as it should.
Robert - that was a bug which is now fixed.
Christian 2.0 wrote:
Wed Jan 11, 2017 10:26 am
... you should not use extensions for making visual changes to your style.
Why?
I could say the same - you should not make core changes to effect visual changes to your style (but I don't)

Re: How to center logo in 3.2?

Posted: Wed Jan 11, 2017 12:22 pm
by Christian 2.0
david63 wrote:
Wed Jan 11, 2017 11:52 am
Why?
I could say the same - you should not make core changes to effect visual changes to your style (but I don't)
Because it is complete overkill to achieve something that could otherwise be done with a one-line code edit. And since the CSS changes in maintenance releases are negligible, the argument that extensions == easier upgrades in this case is not valid.

Also if you scroll through the styles in development forum, extensions don't exist for many of the customisations people want to make. And not that many people have the skill to make an extension, but are capable of editing a file.

Would you use an extension to increase the padding for one element in your style? Probably not. "Use an extension" is the lazy answer to too many things around here.

Re: How to center logo in 3.2?

Posted: Wed Jan 11, 2017 12:53 pm
by david63
Christian 2.0 wrote:
Wed Jan 11, 2017 12:22 pm
Would you use an extension to increase the padding for one element in your style?
If you accept, which I may be wrong - but you don't, that one of the basic tenets of phpBB 3.1/3.2 is that core files are not changed then that is one option. On the other hand if I wanted to make several changes to the style that I used then I would, as should everyone else in my opinion, create a "child" style with those changes in it.

You only have to look at the myriad of support problems with users trying to use the auto update method to realise that file replacement for an update/upgrade would be far less problematical.

Re: How to center logo in 3.2?

Posted: Wed Jan 11, 2017 1:22 pm
by Volksdevil
It would be far less problematic if those who do modify were catered for... :roll: