phpBB 3.2 style changes

For support and discussion related to templates, themes, and imagesets in phpBB 3.2.
User avatar
P_I
Registered User
Posts: 838
Joined: Tue Mar 01, 2011 8:35 pm
Location: Calgary
Contact:

Re: phpBB 3.2 style changes

Post by P_I » Mon Jan 08, 2018 7:41 pm

Marc wrote:
Tue Jun 27, 2017 8:23 pm
3.2.1 to 3.2.2:
https://gist.github.com/marc1706/dbca9c ... 17e98916b9
If there are style changes in a dot release, I'm a bit curious why styles/prosilver/theme/stylesheet.css isn't being updated with each dot release to reflect the new phpBB version?

Code: Select all

/*  phpBB3 Style Sheet
    --------------------------------------------------------------
	Style name:			prosilver (the default phpBB 3.2.x style)
	Based on style:
	Original author:	Tom Beddard ( http://www.subblue.com/ )
	Modified by:		phpBB Limited ( https://www.phpbb.com/ )
    --------------------------------------------------------------
*/

@import url("normalize.css?v=3.2");
@import url("base.css?v=3.2");
@import url("utilities.css?v=3.2");
@import url("common.css?v=3.2");
@import url("links.css?v=3.2");
@import url("content.css?v=3.2");
@import url("buttons.css?v=3.2");
@import url("cp.css?v=3.2");
@import url("forms.css?v=3.2");
@import url("icons.css?v=3.2");
@import url("colours.css?v=3.2");
@import url("responsive.css?v=3.2");
Shouldn't the v=3.2 become v=3.2.2 with the phpBB 3.2.2 release just announced?
Normal people… believe that if it ain’t broke, don’t fix it. Engineers believe that if it ain’t broke, it doesn’t have enough features yet. – Scott Adams

User avatar
Lumpy Burgertushie
Registered User
Posts: 64471
Joined: Mon May 02, 2005 3:11 am
Contact:

Re: phpBB 3.2 style changes

Post by Lumpy Burgertushie » Mon Jan 08, 2018 8:31 pm

notice it says 3.2.x
that means that it will stay the same with all 3.2 versions. If that changes then it would be updated to reflect those changes.


robert
I am available for custom work on a donation basis. Please send me a PM with your needs.

Premium phpBB 3.2 Styles by PlanetStyles.net

User avatar
Hanakin
Infrastructure Team Member
Infrastructure Team Member
Posts: 685
Joined: Wed Dec 30, 2009 8:14 am
Name: Michael Miday
Contact:

Re: phpBB 3.2 style changes

Post by Hanakin » Wed Jan 10, 2018 2:14 am

well, your both kind of correct. the v=3.2 was added to force browsers to recache as nothing was being changed in the stylesheet.css there were render issues. This is also due to an archaic practice of using loading multiple css files via imports. This is an extremely bad practice from the browser's perspective and one we will be eliminated going forward in 3.3 as we push to move towards using scss and a minified served css file. If anything it should have just been a style version tag added rather than versioning the imports but its already said and done for 3.2.

User avatar
Sajaki
Registered User
Posts: 1347
Joined: Mon Mar 02, 2009 1:41 pm
Name: Andreas
Contact:

Re: phpBB 3.2 style changes

Post by Sajaki » Wed Jan 10, 2018 5:31 pm

I presume you'll include scss source files with 3.3 then ?

User avatar
Hanakin
Infrastructure Team Member
Infrastructure Team Member
Posts: 685
Joined: Wed Dec 30, 2009 8:14 am
Name: Michael Miday
Contact:

Re: phpBB 3.2 style changes

Post by Hanakin » Wed Jan 10, 2018 11:00 pm

yes, if not then at least in the dev repo. There will be minified and non-minified versions of the css files however.

WWu777
Registered User
Posts: 537
Joined: Tue Aug 14, 2007 12:40 pm
Contact:

Re: phpBB 3.2 style changes

Post by WWu777 » Sat Jan 13, 2018 8:21 pm

If I upgrade to phpbb 3.2.2 would any of my extensions be affected? Could any issues result?

User avatar
Crizzo
Translations & International Support Teams Manager
Translations & International Support Teams Manager
Posts: 745
Joined: Thu Apr 23, 2009 1:20 pm
Location: Germany
Name: Christian
Contact:

Re: phpBB 3.2 style changes

Post by Crizzo » Sat Jan 13, 2018 9:13 pm

WWu777 wrote:
Sat Jan 13, 2018 8:21 pm
If I upgrade to phpbb 3.2.2 would any of my extensions be affected? Could any issues result?
How could anyone know, nobody knows your extensions. Try it with a test board. And yes, issues can result. But this is not a support topic.
My extensions for phpBB: crizzo.de
German phpBB Support at www.phpbb.de

User avatar
Marc
Development Team Leader
Development Team Leader
Posts: 5290
Joined: Tue Oct 30, 2007 10:57 pm
Location: Munich, Germany
Name: Marc
Contact:

Re: phpBB 3.2 style changes

Post by Marc » Mon Mar 26, 2018 7:22 pm

Updated the first post to add changes between 3.2.2 & 3.2.3-RC1.
Quickedit for phpBB 3.1
I'm available for custom work - just send me a PM for a quote.

Post Reply

Return to “[3.2.x] Styles Support & Discussion”

Who is online

Users browsing this forum: asososo and 7 guests