phpBB 3.2 style changes

For support and discussion related to templates, themes, and imagesets in phpBB 3.2.
User avatar
P_I
Community Team Member
Community Team Member
Posts: 2344
Joined: Tue Mar 01, 2011 8:35 pm
Location: Western Canada 🇨🇦
Contact:

Re: phpBB 3.2 style changes

Post by P_I »

Marc wrote: Tue Jun 27, 2017 8:23 pm 3.2.1 to 3.2.2:
https://gist.github.com/marc1706/dbca9c ... 17e98916b9
If there are style changes in a dot release, I'm a bit curious why styles/prosilver/theme/stylesheet.css isn't being updated with each dot release to reflect the new phpBB version?

Code: Select all

/*  phpBB3 Style Sheet
    --------------------------------------------------------------
	Style name:			prosilver (the default phpBB 3.2.x style)
	Based on style:
	Original author:	Tom Beddard ( http://www.subblue.com/ )
	Modified by:		phpBB Limited ( https://www.phpbb.com/ )
    --------------------------------------------------------------
*/

@import url("normalize.css?v=3.2");
@import url("base.css?v=3.2");
@import url("utilities.css?v=3.2");
@import url("common.css?v=3.2");
@import url("links.css?v=3.2");
@import url("content.css?v=3.2");
@import url("buttons.css?v=3.2");
@import url("cp.css?v=3.2");
@import url("forms.css?v=3.2");
@import url("icons.css?v=3.2");
@import url("colours.css?v=3.2");
@import url("responsive.css?v=3.2");
Shouldn't the v=3.2 become v=3.2.2 with the phpBB 3.2.2 release just announced?
Normal people… believe that if it ain’t broke, don’t fix it. Engineers believe that if it ain’t broke, it doesn’t have enough features yet. – Scott Adams
User avatar
Lumpy Burgertushie
Registered User
Posts: 69223
Joined: Mon May 02, 2005 3:11 am
Contact:

Re: phpBB 3.2 style changes

Post by Lumpy Burgertushie »

notice it says 3.2.x
that means that it will stay the same with all 3.2 versions. If that changes then it would be updated to reflect those changes.


robert
Premium phpBB 3.3 Styles by PlanetStyles.net

I am pleased to announce that I have completed the first item on my bucket list. I have the bucket.
User avatar
Hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 1065
Joined: Wed Dec 30, 2009 8:14 am
Name: Michael Miday
Contact:

Re: phpBB 3.2 style changes

Post by Hanakin »

well, your both kind of correct. the v=3.2 was added to force browsers to recache as nothing was being changed in the stylesheet.css there were render issues. This is also due to an archaic practice of using loading multiple css files via imports. This is an extremely bad practice from the browser's perspective and one we will be eliminated going forward in 3.3 as we push to move towards using scss and a minified served css file. If anything it should have just been a style version tag added rather than versioning the imports but its already said and done for 3.2.
User avatar
Sajaki
Registered User
Posts: 1390
Joined: Mon Mar 02, 2009 1:41 pm
Location: Amsterdam
Contact:

Re: phpBB 3.2 style changes

Post by Sajaki »

I presume you'll include scss source files with 3.3 then ?
User avatar
Hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 1065
Joined: Wed Dec 30, 2009 8:14 am
Name: Michael Miday
Contact:

Re: phpBB 3.2 style changes

Post by Hanakin »

yes, if not then at least in the dev repo. There will be minified and non-minified versions of the css files however.
WWu777
Registered User
Posts: 802
Joined: Tue Aug 14, 2007 12:40 pm
Contact:

Re: phpBB 3.2 style changes

Post by WWu777 »

If I upgrade to phpbb 3.2.2 would any of my extensions be affected? Could any issues result?
User avatar
Crizzo
Translations & International Support Teams Manager
Translations & International Support Teams Manager
Posts: 1645
Joined: Thu Apr 23, 2009 1:20 pm
Location: Stuttgart, Germany
Name: Christian
Contact:

Re: phpBB 3.2 style changes

Post by Crizzo »

WWu777 wrote: Sat Jan 13, 2018 8:21 pm If I upgrade to phpbb 3.2.2 would any of my extensions be affected? Could any issues result?
How could anyone know, nobody knows your extensions. Try it with a test board. And yes, issues can result. But this is not a support topic.
My extensions for phpBB: CDB
German phpBB Support at www.phpbb.de
User avatar
Marc
Development Team Leader
Development Team Leader
Posts: 5657
Joined: Tue Oct 30, 2007 10:57 pm
Location: Munich, Germany
Name: Marc
Contact:

Re: phpBB 3.2 style changes

Post by Marc »

Updated the first post to add changes between 3.2.2 & 3.2.3-RC1.
User avatar
Marc
Development Team Leader
Development Team Leader
Posts: 5657
Joined: Tue Oct 30, 2007 10:57 pm
Location: Munich, Germany
Name: Marc
Contact:

Re: phpBB 3.2 style changes

Post by Marc »

Update first post with changes for 3.2.3-RC2.
WWu777
Registered User
Posts: 802
Joined: Tue Aug 14, 2007 12:40 pm
Contact:

Re: phpBB 3.2 style changes

Post by WWu777 »

What does RC1 mean?
User avatar
RMcGirr83
Former Team Member
Posts: 22011
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: phpBB 3.2 style changes

Post by RMcGirr83 »

Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
Appreciate the extensions/mods/support then buy me a beer Image
User avatar
Raul [ThE KuKa]
Style Customisations
Style Customisations
Posts: 11072
Joined: Mon Dec 08, 2003 9:24 pm
Location: Spain
Name: Raul Arroyo
Contact:

Re: phpBB 3.2 style changes

Post by Raul [ThE KuKa] »

Marc wrote: Thu Aug 02, 2018 6:11 pm Update first post with changes for 3.2.3-RC2.
Marc hardcoded for "Terms" and "Privacy" text... :?

Thanks for all!
All unsolicited PMs will be ignored.
:warning: Knowledge Base | Documentation | Board rules | phpBB Styles Rules & Policies | Styles Queue Stats :warning:


If you like my styles, translations, etc. and want to show some appreciation, then feel free to Donate.
:flag_es: phpBB Spain - Online Since 2003 :heart:


User avatar
3Di
I've Been Banned!
Posts: 17538
Joined: Mon Apr 04, 2005 11:09 pm
Location: I'm with Ukraine 🇺🇦
Name: Marco
Contact:

Re: phpBB 3.2 style changes

Post by 3Di »

Raul [ThE KuKa] wrote: Fri Aug 03, 2018 4:10 pm Marc hardcoded for "Terms" and "Privacy" text... :?
https://github.com/phpbb/phpbb/pull/5314
🆓 Free support for our extensions also provided here: phpBB Studio
🚀 Looking for a specific feature or alternative option? We will rock you!
Please PM me only to request paid works. Thx. Buy me a coffee -> Image
My development's activity º PhpStorm's proud user º Extensions, Scripts, MOD porting, Update/Upgrades
User avatar
Marc
Development Team Leader
Development Team Leader
Posts: 5657
Joined: Tue Oct 30, 2007 10:57 pm
Location: Munich, Germany
Name: Marc
Contact:

Re: phpBB 3.2 style changes

Post by Marc »

List of diffs updated after latest changes.
User avatar
Marc
Development Team Leader
Development Team Leader
Posts: 5657
Joined: Tue Oct 30, 2007 10:57 pm
Location: Munich, Germany
Name: Marc
Contact:

Re: phpBB 3.2 style changes

Post by Marc »

Added 3.2.3 to 3.2.4-RC1
Post Reply

Return to “[3.2.x] Styles Support & Discussion”