Overlap of pagination with last post date

For support and discussion related to templates, themes, and imagesets in phpBB 3.2.
FourierTransformer
Registered User
Posts: 20
Joined: Fri Jan 13, 2017 5:01 pm

Overlap of pagination with last post date

Post by FourierTransformer »

When I browse this very forum (with Firefox 52.3.0), I get to see the following artifact:
https://abload.de/img/paginationyksg0.png

On my own 3.2.1 board, the same thing happens, but also in topic searches (like egosearch or unanswered), which is apparently prevented here by limiting the column width below the default.

It seems like this has been around for a long time, so it is a known issue? Is there any workaround?
User avatar
RMcGirr83
Former Team Member
Posts: 22016
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: Overlap of pagination with last post date

Post by RMcGirr83 »

Known issue and only affects prosilver SE.
Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
Appreciate the extensions/mods/support then buy me a beer Image
FourierTransformer
Registered User
Posts: 20
Joined: Fri Jan 13, 2017 5:01 pm

Re: Overlap of pagination with last post date

Post by FourierTransformer »

RMcGirr83 wrote: Mon Aug 14, 2017 1:08 am Known issue and only affects prosilver SE.
It definitely affects prosilver, too.
User avatar
david63
Registered User
Posts: 20646
Joined: Thu Dec 19, 2002 8:08 am

Re: Overlap of pagination with last post date

Post by david63 »

... and other styles
David
Remember: You only know what you know and - you don't know what you don't know!

I now no longer support any of my extensions but they will start to become available here
User avatar
RMcGirr83
Former Team Member
Posts: 22016
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: Overlap of pagination with last post date

Post by RMcGirr83 »

FourierTransformer wrote: Mon Aug 14, 2017 2:46 am
RMcGirr83 wrote: Mon Aug 14, 2017 1:08 am Known issue and only affects prosilver SE.
It definitely affects prosilver, too.
Doesn't seem to

https://area51.phpbb.com/phpBB/viewforum.php?f=126
Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
Appreciate the extensions/mods/support then buy me a beer Image
FourierTransformer
Registered User
Posts: 20
Joined: Fri Jan 13, 2017 5:01 pm

Re: Overlap of pagination with last post date

Post by FourierTransformer »

RMcGirr83 wrote: Mon Aug 14, 2017 9:16 am
FourierTransformer wrote: Mon Aug 14, 2017 2:46 am
RMcGirr83 wrote: Mon Aug 14, 2017 1:08 am Known issue and only affects prosilver SE.
It definitely affects prosilver, too.
Doesn't seem to

https://area51.phpbb.com/phpBB/viewforum.php?f=126
See here: https://abload.de/img/pagination2ibuw3.png

Admittedly, you have to scale the browser window to just the right size. But if there were more threads with many pages created by people with long user names, the problem would occur more frequently.
User avatar
RMcGirr83
Former Team Member
Posts: 22016
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: Overlap of pagination with last post date

Post by RMcGirr83 »

Former Modifications/Extensions Team Member | My extensions | github | All requests for support via PM will be ignored
Appreciate the extensions/mods/support then buy me a beer Image
FourierTransformer
Registered User
Posts: 20
Joined: Fri Jan 13, 2017 5:01 pm

Re: Overlap of pagination with last post date

Post by FourierTransformer »

RMcGirr83 wrote: Mon Aug 14, 2017 1:23 pm viewtopic.php?p=14788851#p14788851
That works as a quickfix, but it breaks the line every time, even when it is not necessary.

Is there any CSS magic to prevent that?
User avatar
Hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 1065
Joined: Wed Dec 30, 2009 8:14 am
Name: Michael Miday
Contact:

Re: Overlap of pagination with last post date

Post by Hanakin »

Not one without having major backwards compatibility breaks
User avatar
Hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 1065
Joined: Wed Dec 30, 2009 8:14 am
Name: Michael Miday
Contact:

Re: Overlap of pagination with last post date

Post by Hanakin »

ultimately the entire second line of html needs overhauled with some minor css tweaks. That is the fix unfortunately. If you wish to make the changes to any of your themes have a look at how its handled here: https://codepen.io/hanakin/pen/PKOjLe?editors=1100

**NOTE: you have to make similar changes in all occurrences however ie search results
FourierTransformer
Registered User
Posts: 20
Joined: Fri Jan 13, 2017 5:01 pm

Re: Overlap of pagination with last post date

Post by FourierTransformer »

I noticed that in the responsive theme, we already have the "left-box" class in the search results, which kind of does what would be needed. It's only the spacing that is very inconsistent between the desktop and the responsive theme, so I'm a bit afraid to touch it.
User avatar
Hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 1065
Joined: Wed Dec 30, 2009 8:14 am
Name: Michael Miday
Contact:

Re: Overlap of pagination with last post date

Post by Hanakin »

That class is used in other places as well from what i recall. I don't really have the time at the moment, but probably can try to add a new temp class in 3.2.2 and tweak the settings for that to quick fix the search page.
FourierTransformer
Registered User
Posts: 20
Joined: Fri Jan 13, 2017 5:01 pm

Re: Overlap of pagination with last post date

Post by FourierTransformer »

Using the left-box class and removing the negative margin-top should work as a quickfix. I am just confused that in responsive mode, the pagination suddenly has 4px of top and bottom margin. Should that also apply to full-width mode?
User avatar
Hanakin
Front-End Dev Team Lead
Front-End Dev Team Lead
Posts: 1065
Joined: Wed Dec 30, 2009 8:14 am
Name: Michael Miday
Contact:

Re: Overlap of pagination with last post date

Post by Hanakin »

It's done to account for mobile wrapping...

Can you post the changes you made?
FourierTransformer
Registered User
Posts: 20
Joined: Fri Jan 13, 2017 5:01 pm

Re: Overlap of pagination with last post date

Post by FourierTransformer »

So far, I have just tested a few things in Firefox, but I can prepare a patch.
Post Reply

Return to “[3.2.x] Styles Support & Discussion”