3.2.3 Notifications On Small Screen

For support and discussion related to templates, themes, and imagesets in phpBB 3.2.
Post Reply
User avatar
Dan Stylez
Registered User
Posts: 183
Joined: Tue Jan 16, 2018 6:17 am
Contact:

3.2.3 Notifications On Small Screen

Post by Dan Stylez » Tue Sep 18, 2018 4:02 am

This only happens with my 3.2.3 test forum, which was a fresh install, so i'm wondering if i have a corrupted file or if anyone else using a fresh 3.2.3 install is getting this ?

If i minimize the screen to less than 350px and press the notification dropdown button, it's just a long line about 3px wide.

Screen Shot 2018-09-18 at 04.43.34-fullpage.png

Edit, i've just tried this with a fresh install and still get the same,

Removing this bit of code from responsive.css solves it, but the same code is in 3.2.2 and that works fine.

Code: Select all

@media (max-width: 350px) {
	.dropdown-extended .dropdown-contents {
		width: auto;
	}
}

User avatar
Mannix_
Registered User
Posts: 355
Joined: Sun Oct 25, 2015 2:56 pm
Contact:

Re: 3.2.3 Notifications On Small Screen

Post by Mannix_ » Tue Sep 18, 2018 8:18 am

This can't be style related issue I tried using 3.2.2 version of prosilver and different styles for 3.2.2 and 3.2.3 and all have the same result as shown above. Only non prosilver based style I have is working properly which is making it even weirder
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
My CDB contributions . Like my work? Want me to do make a style just for you? PM here or on twitter.
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Need some graphics? PM here or on twitter.

User avatar
Dan Stylez
Registered User
Posts: 183
Joined: Tue Jan 16, 2018 6:17 am
Contact:

Re: 3.2.3 Notifications On Small Screen

Post by Dan Stylez » Wed Sep 19, 2018 8:39 pm

Mannix_ wrote:
Tue Sep 18, 2018 8:18 am
This can't be style related issue I tried using 3.2.2 version of prosilver and different styles for 3.2.2 and 3.2.3 and all have the same result as shown above. Only non prosilver based style I have is working properly which is making it even weirder
I bet the non Prosilver based style doesn't have that bit of code in,

Does a bug ticket thingy need to be opened?

sakm
Registered User
Posts: 511
Joined: Sun Jan 21, 2007 8:14 pm
Location: Hull, uk
Name: Stu
Contact:

Re: 3.2.3 Notifications On Small Screen

Post by sakm » Wed Sep 19, 2018 9:32 pm

Dan Stylez wrote:
Wed Sep 19, 2018 8:39 pm

Does a bug ticket thingy need to be opened?
I believe its a bug I have the same trouble

viewtopic.php?f=556&t=2486741

User avatar
Mannix_
Registered User
Posts: 355
Joined: Sun Oct 25, 2015 2:56 pm
Contact:

Re: 3.2.3 Notifications On Small Screen

Post by Mannix_ » Thu Sep 20, 2018 10:16 am

Dan Stylez wrote:
Wed Sep 19, 2018 8:39 pm
Mannix_ wrote:
Tue Sep 18, 2018 8:18 am
This can't be style related issue I tried using 3.2.2 version of prosilver and different styles for 3.2.2 and 3.2.3 and all have the same result as shown above. Only non prosilver based style I have is working properly which is making it even weirder
I bet the non Prosilver based style doesn't have that bit of code in,

Does a bug ticket thingy need to be opened?
Yep that's definitely a bug and you should open a ticket about it so they can fix it :)
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
My CDB contributions . Like my work? Want me to do make a style just for you? PM here or on twitter.
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Need some graphics? PM here or on twitter.

User avatar
GanstaZ
Jr. Extension Validator
Posts: 642
Joined: Wed Oct 11, 2017 10:29 pm
Location: Zverse

Re: 3.2.3 Notifications On Small Screen

Post by GanstaZ » Thu Sep 20, 2018 10:33 am

Maybe it needs a min-width to be set or some other change. Was this bug in 3.2.2 prosilver as well?
"When answer lies in the question,.. question becomes redundant!"

User avatar
Mannix_
Registered User
Posts: 355
Joined: Sun Oct 25, 2015 2:56 pm
Contact:

Re: 3.2.3 Notifications On Small Screen

Post by Mannix_ » Thu Sep 20, 2018 10:45 am

GanstaZ wrote:
Thu Sep 20, 2018 10:33 am
Maybe it needs a min-width to be set or some other change. Was this bug in 3.2.2 prosilver as well?
That works but I'm curious what changed that it caused that issue
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
My CDB contributions . Like my work? Want me to do make a style just for you? PM here or on twitter.
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Need some graphics? PM here or on twitter.

User avatar
GanstaZ
Jr. Extension Validator
Posts: 642
Joined: Wed Oct 11, 2017 10:29 pm
Location: Zverse

Re: 3.2.3 Notifications On Small Screen

Post by GanstaZ » Thu Sep 20, 2018 10:49 am

I haven't updated my development environment yet, so can't tell much. If it was present in 3.2.2 then the problem goes deeper. But if it started in 3.2.3, it may be related to a change in assets/javascript/core.js file.
"When answer lies in the question,.. question becomes redundant!"

User avatar
Mannix_
Registered User
Posts: 355
Joined: Sun Oct 25, 2015 2:56 pm
Contact:

Re: 3.2.3 Notifications On Small Screen

Post by Mannix_ » Thu Sep 20, 2018 10:57 am

GanstaZ wrote:
Thu Sep 20, 2018 10:49 am
I haven't updated my development environment yet, so can't tell much. If it was present in 3.2.2 then the problem goes deeper. But if it started in 3.2.3, it may be related to a change in assets/javascript/core.js file.
It must be the 2nd option since I tested 3.2.3 version of prosilver on phpbb 3.2.2 and it works fine there.
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
My CDB contributions . Like my work? Want me to do make a style just for you? PM here or on twitter.
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Need some graphics? PM here or on twitter.

User avatar
GanstaZ
Jr. Extension Validator
Posts: 642
Joined: Wed Oct 11, 2017 10:29 pm
Location: Zverse

Re: 3.2.3 Notifications On Small Screen

Post by GanstaZ » Thu Sep 20, 2018 11:03 am

Maybe this change is affecting it => [ticket/15613]? Seems to be the only one related to dropdown.
"When answer lies in the question,.. question becomes redundant!"

User avatar
Mannix_
Registered User
Posts: 355
Joined: Sun Oct 25, 2015 2:56 pm
Contact:

Re: 3.2.3 Notifications On Small Screen

Post by Mannix_ » Thu Sep 20, 2018 11:05 am

GanstaZ wrote:
Thu Sep 20, 2018 11:03 am
Maybe this change is affecting it => [ticket/15613]? Seems to be the only one related to dropdown.
That's it :D
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
My CDB contributions . Like my work? Want me to do make a style just for you? PM here or on twitter.
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Need some graphics? PM here or on twitter.

User avatar
_Vinny_
Style Customisations
Style Customisations
Posts: 8084
Joined: Tue Aug 11, 2009 12:45 am
Location: Brazil
Name: Marcus Vinicius
Contact:

Re: 3.2.3 Notifications On Small Screen

Post by _Vinny_ » Thu Sep 20, 2018 11:58 am

I just updated my test forum, I faced the same problem. Could you report the problem to the tracker? :)

hubaishan
Translator
Posts: 129
Joined: Sun Apr 10, 2011 2:47 pm
Name: Saeed Hubaishan
Contact:

Re: 3.2.3 Notifications On Small Screen

Post by hubaishan » Thu Sep 20, 2018 2:41 pm

This bug has been fixed but a mistake prevent it to appear in 3.2.3. It will be in 3.2.4.

The fix is simple just do as in https://github.com/phpbb/phpbb/pull/5229/files

User avatar
Hanakin
Infrastructure Team Member
Infrastructure Team Member
Posts: 754
Joined: Wed Dec 30, 2009 8:14 am
Name: Michael Miday
Contact:

Re: 3.2.3 Notifications On Small Screen

Post by Hanakin » Mon Oct 08, 2018 2:08 am

and this is also why we are removing all the js crap for the new theme ;)

Post Reply

Return to “[3.2.x] Styles Support & Discussion”

Who is online

Users browsing this forum: No registered users and 3 guests