It shouldn't be in the file literally, you should copy the rendered CDATA without the HTML escaping.Helter Skelter wrote:Thank you for the quick reply! I assume that the replacement will function the same in the overall_header because it is an html file? Seems to work fine atm.
Of course I can do it from now, I just want to contribute...tumba25 wrote:You can put that in the Author notes if you want.
That certainly sounds reasonable to me. I know I messed something up once trying to use Windows Notepad because of the requirements for editing text files (UTF-8 with no BOM or something most newbies -- or Windows users -- wouldn't understand).leviatan21 wrote:Of course I can do it from now, I just want to contribute...tumba25 wrote:You can put that in the Author notes if you want.
You should know this is a very common problem, mostly for newbie
IMHO the user is right, this should be a common note for all.
I was thinking add a note in the Disclaimer & Other Notes
So you can put it in either the root, in contrib/ or in xml/.All changes to the phpBB core files should be placed in the install.xml file. Changes for non-English languages and non-prosilver templates should not be placed in this file. These should have a separate XML file, but should be linked to from the main install file using the link tag.
Optional install files or instructions should be placed within the contrib directory. Additional required instructions should be placed in the root directory or in a directory called named xml/.
Code: Select all
Code: Select all
<edit> <condition> <find><![CDATA[//@define('EMED_MYMOD', true);]]></find> <then> <action>action type</action> </then> <else> <action>another action type</action> </else> </condition> </edit>