Can not open attached file directly with I.E. without saving

Do not post support requests, bug reports or feature requests. Discuss phpBB here. Non-phpBB related discussion goes in General Discussion!
Get Involved
Jan Christensen
Registered User
Posts: 140
Joined: Sun May 16, 2004 10:42 am
Location: Denmark

Can not open attached file directly with I.E. without saving

Post by Jan Christensen » Fri May 28, 2010 7:40 am

Support Request Template
What version of phpBB are you using? phpBB 3.0.7-PL1
What is your board's URL? http://n/a
Who do you host your board with? No answer given
How did you install your board? I used the download package from phpBB.com
Is your board a fresh install or a conversion? Fresh Install
Do you have any MODs installed? No
Is registration required to reproduce this issue? Yes
What styles do you currently have installed? prosilver and subsilver2
What language(s) is your board currently using? danish
Which database type/version are you using? MySQL 4
What is your level of experience? Experienced with PHP and phpBB
What username can be used to view this issue?
Please do not provide this information if the user requires more than "regular user" privilages.
No answer given
What password can be used to view this issue? No answer given
When did your problem begin? After fresh install of 3.0.7-PL1
Please describe your problem. My problem is internet explorer related.

When downloading attached files on my board, I can choose to open them directly or to save them on my computer, when I use Firefox.

When using Microsoft Internet Explorer I can only choose to save the file, and not to open it directly.

I would like to ask for help to resolve this issue, so that I can also choose to open attached files directly using internet explorer, without the need of saving the file first. Is there a fix for this some where I might have missed?
Generated by SRT Generator ($Rev: 3988 $)
Jan Christensen • Danish language package author • Olympus DK Team

User avatar
tbackoff
Former Team Member
Posts: 7022
Joined: Thu Jun 04, 2009 1:41 am
Location: cheerleading practice
Name: Tabitha Backoff

Re: Can not open attached file directly with I.E. without sa

Post by tbackoff » Fri May 28, 2010 1:15 pm

This isn't a phpBB issue, it's an IE issue. The same thing happens on this board using IE (you can verify by visiting this post).
Flying is the second best thrill to cheerleaders; being caught is the first.

Jan Christensen
Registered User
Posts: 140
Joined: Sun May 16, 2004 10:42 am
Location: Denmark

Re: Can not open attached file directly with I.E. without sa

Post by Jan Christensen » Fri May 28, 2010 2:35 pm

Hi

I dont understand that, in 3.0.4 it was possible in I.E. to choose between opening files directly or save them first, but after I upgraded to 3.0.7 the choice is no longer presented to me in I.E. - so I figure it has to be a phpBB issue after all?

Is there a fix or a tweak I can implement in the code that triggers I.E. to present me for the two choices?
Jan Christensen • Danish language package author • Olympus DK Team

Jan Christensen
Registered User
Posts: 140
Joined: Sun May 16, 2004 10:42 am
Location: Denmark

Re: Can not open attached file directly with I.E. without sa

Post by Jan Christensen » Sat May 29, 2010 6:52 pm

BUMP

I would like an answer from phpBB support team about this issue, if possible, thx.
Jan Christensen • Danish language package author • Olympus DK Team

Pit$Bull
Former Team Member
Posts: 23099
Joined: Sat Dec 02, 2006 4:08 pm
Name: Can't Remember

Re: Can not open attached file directly with I.E. without sa

Post by Pit$Bull » Sat May 29, 2010 6:57 pm

t_backoff wrote:This isn't a phpBB issue, it's an IE issue. The same thing happens on this board using IE (you can verify by visiting this post).

Jan Christensen
Registered User
Posts: 140
Joined: Sun May 16, 2004 10:42 am
Location: Denmark

Re: Can not open attached file directly with I.E. without sa

Post by Jan Christensen » Sat May 29, 2010 7:04 pm

Then why did it work in 3.0.4 but not after upgrading to 3.0.7?
Jan Christensen • Danish language package author • Olympus DK Team

User avatar
tbackoff
Former Team Member
Posts: 7022
Joined: Thu Jun 04, 2009 1:41 am
Location: cheerleading practice
Name: Tabitha Backoff

Re: Can not open attached file directly with I.E. without sa

Post by tbackoff » Sat May 29, 2010 10:17 pm

This is still an IE issue. I just downloaded and installed a fresh copy of 3.0.4 and am only presented with the option to save the file. I'm not sure what else to tell you other than to complain to Microsoft. :?
Flying is the second best thrill to cheerleaders; being caught is the first.

User avatar
John P
Registered User
Posts: 1237
Joined: Mon Jan 21, 2008 3:55 pm
Location: Netherlands
Name: John
Contact:

Re: Can not open attached file directly with I.E. without sa

Post by John P » Sat May 29, 2010 10:33 pm

In file file.php in function sen_file_to_browser change the

Removed

If you want to open download files immediately
Last edited by Marshalrusty on Sat Jun 05, 2010 7:16 pm, edited 1 time in total.
Reason: Removed code. Please do not suggest fixes unless you fully understand the ramifications
Image
Webhosting, Custom MODs, Technical management, MOD installation and Webdesign

stokerpiller
Registered User
Posts: 1934
Joined: Wed Feb 28, 2007 8:06 pm

Re: Can not open attached file directly with I.E. without sa

Post by stokerpiller » Sun May 30, 2010 9:13 pm

Not a phpBB issue :?

Off course its a phpBB issue, IE8 can open PDF directly without saving when using other forum software than phpBB or CMS.
I am done with phpBB

User avatar
Kellanved
Former Team Member
Posts: 2635
Joined: Wed Jan 26, 2005 2:48 pm
Location: Meta-level

Re: Can not open attached file directly with I.E. without sa

Post by Kellanved » Sun May 30, 2010 9:41 pm

A stated in the code, it's a necessary security precaution - the way internet explorer handles files would create a XSS issue otherwise. As such, it is an IE issue - partially solved in ie8, hopefully solved in ie9.
Nocando is in Idontwanna county. No support via PM

stokerpiller
Registered User
Posts: 1934
Joined: Wed Feb 28, 2007 8:06 pm

Re: Can not open attached file directly with I.E. without sa

Post by stokerpiller » Sun May 30, 2010 10:21 pm

So doing what earlier suggested would cause a security issue?
I am done with phpBB

Jan Christensen
Registered User
Posts: 140
Joined: Sun May 16, 2004 10:42 am
Location: Denmark

Re: Can not open attached file directly with I.E. without sa

Post by Jan Christensen » Mon May 31, 2010 1:55 am

@Stef775: Thx a million, I will try it out :)

@Stokerpiller: Good question m8, I dont get it either, I wait and see the answer to it, thx. :)
Jan Christensen • Danish language package author • Olympus DK Team

Jan Christensen
Registered User
Posts: 140
Joined: Sun May 16, 2004 10:42 am
Location: Denmark

Re: Can not open attached file directly with I.E. without sa

Post by Jan Christensen » Mon May 31, 2010 2:12 am

@Stef775: Thx again m8, much apreciated your code works like a charm, I would very much like to hear more about how this code change becomes a security issue. :)
Jan Christensen • Danish language package author • Olympus DK Team

Jan Christensen
Registered User
Posts: 140
Joined: Sun May 16, 2004 10:42 am
Location: Denmark

Re: Can not open attached file directly with I.E. without sa

Post by Jan Christensen » Mon May 31, 2010 4:35 am

@Kellanved:

I try to figure this one out, sorry if I have misunderstood you, english is not my native language. :)

In the file download/file.php it says the following:

Code: Select all

// Send out the Headers. Do not set Content-Disposition to inline please, it is a security measure for users using the Internet Explorer.
	$is_ie8 = false; //(strpos(strtolower($user->browser), 'msie 8.0') !== false);
	header('Content-Type: ' . $attachment['mimetype']);

*Note: The above code is after implementing the suggested code change*
As I understand the explanation in the code, the security issue concerns the Content-Type, but the suggested code change by Stef775 does not have anything to do with the Content-Type, as I understand it?

Maybe I did not understand this properly and missed something important?
Jan Christensen • Danish language package author • Olympus DK Team

Jan Christensen
Registered User
Posts: 140
Joined: Sun May 16, 2004 10:42 am
Location: Denmark

Re: Can not open attached file directly with I.E. without sa

Post by Jan Christensen » Wed Jun 02, 2010 5:18 am

Hi - I know how easily a topic on big boards like this can dissapear in the crowd, so I take the chance and BUMP this topic. :)
Jan Christensen • Danish language package author • Olympus DK Team

Post Reply

Return to “phpBB Discussion”