[Discuss] Introducing "phpBB Ideas"!

Do not post support requests, bug reports or feature requests. Discuss phpBB here. Non-phpBB related discussion goes in General Discussion!
Scam Warning
Danielx64
Registered User
Posts: 1369
Joined: Wed Nov 04, 2009 5:51 am
Location: In a server room in Australia
Name: Daniel
Contact:

Re: [Discuss] Introducing phpBB Ideas!

Post by Danielx64 »

Christian 2.0 wrote:
Jessica wrote:I really like it!
Thanks Jessica :)
Jessica wrote: Is there any way you could provide those new buttons? I know you made a PR on Github...but I don't know how to get the images (buttons). And for "View All", is it a button too?
The images are part of the pull request (or should be), and will be included as and when Callum merges it. I got a little bit lazy by the time "view all" came around, so it's literally just the .forumbg class with some extra CSS to apply width, padding and to center it. :)
I can not wait for it too. Also please dont merge my edit: I just found a nasty bug that will be corrected when I get up: it is 1:30 am right now.
Please note that I will not be porting any of my mods to phpBB 3.1. Sorry for the inconvenience this may cause.
Image
User avatar
Martin Truckenbrodt
Registered User
Posts: 3045
Joined: Sun Mar 23, 2003 6:22 pm
Location: Franconia
Name: Martin Truckenbrodt
Contact:

Re: [Discuss] Introducing phpBB Ideas!

Post by Martin Truckenbrodt »

Hello,
many, many years of hard and sad discussions. Now it's done :!: :idea: :) :) :)

Thank you very much!

Bye Martin
Free tutorial: Installing MODs in phpBB 3.0
Advanced Block MOD - Prevent spam on your phpBB 3.0 board with Stop Forum Spam, BotScout, Akismet, Project Honey Pot and several IP-RBL and Domain-RBL DNS blacklists!
My MODs
Use the official phpBB Ideas to vote missing core features!!!
User avatar
DionDesigns
Registered User
Posts: 515
Joined: Sun Feb 26, 2012 11:22 pm
Location: Uncertain due to momentum.
Contact:

Re: [Discuss] Introducing phpBB Ideas!

Post by DionDesigns »

If you remove the following code from posting.php:

Code: Select all

// Is the user able to read within this forum?
if (!$auth->acl_get('f_read', $forum_id))
{
	if ($user->data['user_id'] != ANONYMOUS)
	{
		trigger_error('USER_CANNOT_READ');
	}

	login_box('', $user->lang['LOGIN_EXPLAIN_POST']);
}
You can then set permissions for a forum where "see forum" and "read forum" are set to NEVER, but "start new topics" and "reply to topics" are set to YES, and those permissions will work.

It certainly appears as though this check was considered a feature. I've always considered it a bug because it reduces the capabilities of the permissions system.

(And FWIW, this change makes it simple to add a "Contact Us" link that can be used by members and guests to send private comments to the board administrators.)
Danielx64
Registered User
Posts: 1369
Joined: Wed Nov 04, 2009 5:51 am
Location: In a server room in Australia
Name: Daniel
Contact:

Re: [Discuss] Introducing phpBB Ideas!

Post by Danielx64 »

DionDesigns wrote:If you remove the following code from posting.php:

Code: Select all

// Is the user able to read within this forum?
if (!$auth->acl_get('f_read', $forum_id))
{
	if ($user->data['user_id'] != ANONYMOUS)
	{
		trigger_error('USER_CANNOT_READ');
	}

	login_box('', $user->lang['LOGIN_EXPLAIN_POST']);
}
You can then set permissions for a forum where "see forum" and "read forum" are set to NEVER, but "start new topics" and "reply to topics" are set to YES, and those permissions will work.

It certainly appears as though this check was considered a feature. I've always considered it a bug because it reduces the capabilities of the permissions system.

(And FWIW, this change makes it simple to add a "Contact Us" link that can be used by members and guests to send private comments to the board administrators.)
Now that is a good point, I'm going to give that a shot.
Please note that I will not be porting any of my mods to phpBB 3.1. Sorry for the inconvenience this may cause.
Image
User avatar
callumacrae
Former Team Member
Posts: 2662
Joined: Tue Feb 12, 2008 12:28 pm
Location: London, UK
Name: Callum Macrae
Contact:

Re: [Discuss] Introducing phpBB Ideas!

Post by callumacrae »

If you make that change and change the permissions, stuff will break
macr.ae = my website. you probably won't like it.
Proud user ofProud user of
Danielx64
Registered User
Posts: 1369
Joined: Wed Nov 04, 2009 5:51 am
Location: In a server room in Australia
Name: Daniel
Contact:

Re: [Discuss] Introducing phpBB Ideas!

Post by Danielx64 »

callumacrae wrote:If you make that change and change the permissions, stuff will break
So what the fix for this issue?
Please note that I will not be porting any of my mods to phpBB 3.1. Sorry for the inconvenience this may cause.
Image
User avatar
callumacrae
Former Team Member
Posts: 2662
Joined: Tue Feb 12, 2008 12:28 pm
Location: London, UK
Name: Callum Macrae
Contact:

Re: [Discuss] Introducing phpBB Ideas!

Post by callumacrae »

*Daniel wrote:
callumacrae wrote:If you make that change and change the permissions, stuff will break
So what the fix for this issue?
What issue?
macr.ae = my website. you probably won't like it.
Proud user ofProud user of
User avatar
Meis2M
Translator
Posts: 931
Joined: Wed Mar 03, 2010 11:32 am
Location: IR.Damghan
Name: میثم نوبری
Contact:

Re: [Discuss] Introducing phpBB Ideas!

Post by Meis2M »

Code: Select all

SQL ERROR [ mysqli ]

BIGINT UNSIGNED value is out of range in '(`phpbb`.`community_ideas_ideas`.`idea_votes_up` - `phpbb`.`community_ideas_ideas`.`idea_votes_down`)' [1690]

An SQL error occurred while fetching this page. Please contact the Board Administrator if this problem persists.
:D
phpBB persian international support
Follow us in Instagram
Free upgrade and install extensions on your forum - drop me PM
Ultimate phpBB SEO Friendly URL extension
Danielx64
Registered User
Posts: 1369
Joined: Wed Nov 04, 2009 5:51 am
Location: In a server room in Australia
Name: Daniel
Contact:

Re: [Discuss] Introducing phpBB Ideas!

Post by Danielx64 »

Meis2M wrote:

Code: Select all

SQL ERROR [ mysqli ]

BIGINT UNSIGNED value is out of range in '(`phpbb`.`community_ideas_ideas`.`idea_votes_up` - `phpbb`.`community_ideas_ideas`.`idea_votes_down`)' [1690]

An SQL error occurred while fetching this page. Please contact the Board Administrator if this problem persists.
:D
Is that on this forum? If so it need to go into the bug tracker
Please note that I will not be porting any of my mods to phpBB 3.1. Sorry for the inconvenience this may cause.
Image
User avatar
DionDesigns
Registered User
Posts: 515
Joined: Sun Feb 26, 2012 11:22 pm
Location: Uncertain due to momentum.
Contact:

Re: [Discuss] Introducing phpBB Ideas!

Post by DionDesigns »

callumacrae wrote:If you make that change and change the permissions, stuff will break
Stuff? It might help to be a little more specific. ;)

I've certainly never run into any problems with the change, and I've made it on a LOT of boards through the years. There is a need for private posting..."contact the admin", contest entries, and requests for membership into a private forum have been common reasons for wanting the feature.

Code: Select all

SQL ERROR [ mysqli ]

BIGINT UNSIGNED value is out of range in '(`phpbb`.`community_ideas_ideas`.`idea_votes_up` - `phpbb`.`community_ideas_ideas`.`idea_votes_down`)' [1690]

An SQL error occurred while fetching this page. Please contact the Board Administrator if this problem persists.
That field shouldn't be unsigned...a bad idea is going to generate a negative number.

BIGINT? Are you expecting the entire planet to be voting? :lol:
User avatar
callumacrae
Former Team Member
Posts: 2662
Joined: Tue Feb 12, 2008 12:28 pm
Location: London, UK
Name: Callum Macrae
Contact:

Re: [Discuss] Introducing phpBB Ideas!

Post by callumacrae »

DionDesigns wrote:
callumacrae wrote:If you make that change and change the permissions, stuff will break
Stuff? It might help to be a little more specific. ;)

I've certainly never run into any problems with the change, and I've made it on a LOT of boards through the years. There is a need for private posting..."contact the admin", contest entries, and requests for membership into a private forum have been common reasons for wanting the feature.
It will break ideas, unless you consider a permissions error on posting to be not an error :)
DionDesigns wrote:

Code: Select all

SQL ERROR [ mysqli ]

BIGINT UNSIGNED value is out of range in '(`phpbb`.`community_ideas_ideas`.`idea_votes_up` - `phpbb`.`community_ideas_ideas`.`idea_votes_down`)' [1690]

An SQL error occurred while fetching this page. Please contact the Board Administrator if this problem persists.
That field shouldn't be unsigned...a bad idea is going to generate a negative number.

BIGINT? Are you expecting the entire planet to be voting? :lol:
I'm a front-end developer and have no idea what any of that means :-(

Do I want to change this to be INT?
macr.ae = my website. you probably won't like it.
Proud user ofProud user of
User avatar
Ger
Recognised Extension Developer
Posts: 1976
Joined: Wed Jan 02, 2008 7:35 pm
Location: 192.168.1.100
Contact:

Re: [Discuss] Introducing phpBB Ideas!

Post by Ger »

callumacrae wrote:Do I want to change this to be INT?
I can't open that link, seems like github is down.

However, if it concerns the code in your quote, MEDIUMINT without the unsigned flag is more than sufficient. It can be +/- 8388607.
MEDIUMINT is 3 bytes while BIGINT is 8.

Check out http://dev.mysql.com/doc/refman/5.0/en/ ... types.html

PS: with such errors and the permission issues, earlier comments about this idea center being more like a BETA aren't really unfair. It ain't a bad idea and it's a very good start, but you can hardly call it a "finished product".
Last edited by Ger on Fri Jul 19, 2013 12:38 pm, edited 1 time in total.
My extensions:
Simple CMS, Feed post bot, Avatar Resize, Modbreak, Magic OGP, Live topic update, Modern Quote, Quoted Where (GDPR) and Autoresponder.
Newest: FAQ manager for 3.2

Like my work? Buy me a coffee to keep it coming. :ugeek:

-Don't PM me for support-
User avatar
callumacrae
Former Team Member
Posts: 2662
Joined: Tue Feb 12, 2008 12:28 pm
Location: London, UK
Name: Callum Macrae
Contact:

Re: [Discuss] Introducing phpBB Ideas!

Post by callumacrae »

Ger wrote:MEDIUMINT without the unsigned flag is more than sufficient. It can be +/- 8388607.
MEDIUMINT is 3 bytes while BIGINT is 8.

Check out http://dev.mysql.com/doc/refman/5.0/en/ ... types.html

PS:
callumacrae wrote:Do I want to change this to be INT?
I can't open that link, seems like github is down.
Yeah, they're being DDoSed
macr.ae = my website. you probably won't like it.
Proud user ofProud user of
User avatar
PlanetStyles.net
Former Team Member
Posts: 4713
Joined: Wed Nov 04, 2009 11:16 pm
Location: UK
Name: Christian
Contact:

Re: [Discuss] Introducing phpBB Ideas!

Post by PlanetStyles.net »

Ger wrote:PS: with such errors and the permission issues, earlier comments about this idea center being more like a BETA aren't really unfair. It ain't a bad idea and it's a very good start, but you can hardly call it a "finished product".
I can't speak for the Website Team, however I'm not really sure it was really intended for mass public distribution in the same way that AutoMOD and Support Toolkit are. More like: "Here's the new part of our website, download it here if you want to".

While it's great that the community are embracing it and contributing, it's not really fair to publicly scrutinise the coding skills of the person who developed it. End of the day it serves its purpose for the phpBB website. :)

My $0.02
User avatar
Ger
Recognised Extension Developer
Posts: 1976
Joined: Wed Jan 02, 2008 7:35 pm
Location: 192.168.1.100
Contact:

Re: [Discuss] Introducing phpBB Ideas!

Post by Ger »

I'm not saying anything about coding skills. Just pointing out that it isn't really production-ready.
My extensions:
Simple CMS, Feed post bot, Avatar Resize, Modbreak, Magic OGP, Live topic update, Modern Quote, Quoted Where (GDPR) and Autoresponder.
Newest: FAQ manager for 3.2

Like my work? Buy me a coffee to keep it coming. :ugeek:

-Don't PM me for support-
Post Reply

Return to “phpBB Discussion”