thank God, you are not my boss...... and I do not have to listen to you.......marvin-miller wrote:In short, you're fired!
even if you were, I would not listen to you no matter what.....
thank God, you are not my boss...... and I do not have to listen to you.......marvin-miller wrote:In short, you're fired!
there is no need to write in CAPITALS...............RMcGirr83 wrote:You need to read up on the GPL. The code that this forum is written on is GPL meaning that anyone can take it and modify it and release it as their own and even charge for it if they want...they just need to maintain the original credits.
The GPL has nothing to do with accepting PR's into the CORE of the original software.
so again, you seem to be making statements of fact which aren't fact at all.The license embodies the Free Software Foundation's "copyleft" rule, which means that anyone is allowed to make changes or extend the source code and redistribute it as long as the changes are clearly marked, and the modified work is also licensed under the GNU General Public License.
Yeah, I think it's becoming clear to everyone that you are unemployeddeveloper11 wrote:thank God, you are not my boss...... and I do not have to listen to you.......marvin-miller wrote:In short, you're fired!
even if you were, I would not listen to you no matter what.....
Again you clearly do not understand the purpose of the GNU GPL. I suggest you google it and try to understand what it's purpose is. That is why I wrote in capitals. To try and get you to understand the difference between what you are suggesting as opposed to fact. This isn't the first time you have spouted off misinformation and I doubt if it will be the last.developer11 wrote:Why there needs to be approval of PR if anyone can modify this software......?
No they shouldn't. If the code being merged is crap then the PR is crap and will affect the quality of the phpBB software. All my mods/extensions are GPL. Using your flawed logic I should accept every PR no matter the quality of the PR. Are you then suggesting that I provide support for the crappy code that was merged or should the original author? Here's a hint, the original author of the crappy code will, more than likely, become a lost soul on the internet which then leaves the mod/extension writer to provide support.Team should make automatic acceptance of PRs.
In which case you would be fired for insubordination. At least if you worked for me you would be not that I need a reason to begin with.developer11 wrote:thank God, you are not my boss...... and I do not have to listen to you.......
even if you were, I would not listen to you no matter what.....
Oh do go away you tedious little tit.developer11 wrote:blah blah whinge blah blah moan blah blah whine blah blah complain blah blah...
they should make PRs being accepted automatically. If PR is crap than QA team steps in and (in cooperation with code author) corrects the code within PR. Thats what QA team is for.....RMcGirr83 wrote:No they shouldn't. If the code being merged is crap then the PR is crap and will affect the quality of the phpBB software. All my mods/extensions are GPL. Using your flawed logic I should accept every PR no matter the quality of the PR. Are you then suggesting that I provide support for the crappy code that was merged or should the original author? Here's a hint, the original author of the crappy code will, more than likely, become a lost soul on the internet which then leaves the mod/extension writer to provide support.Team should make automatic acceptance of PRs.
Again you are incorrect. The QA team is for testing release candidates. If the code is crap to begin with then why waste the time. The QA team very rarely makes PR's of code. That isn't their job. Their job is to ensure that the forum operates correctly given changes as well as test bug fixes. The dev's work with the code author to get the code in to the core.developer11 wrote:they should make PRs being accepted automatically. If PR is crap than QA team steps in and (in cooperation with code author) corrects the code within PR. Thats what QA team is for.....RMcGirr83 wrote:No they shouldn't. If the code being merged is crap then the PR is crap and will affect the quality of the phpBB software. All my mods/extensions are GPL. Using your flawed logic I should accept every PR no matter the quality of the PR. Are you then suggesting that I provide support for the crappy code that was merged or should the original author? Here's a hint, the original author of the crappy code will, more than likely, become a lost soul on the internet which then leaves the mod/extension writer to provide support.Team should make automatic acceptance of PRs.
Nice essayRMcGirr83 wrote:Again you are incorrect. The QA team is for testing release candidates. If the code is crap to begin with then why waste the time. The QA team very rarely makes PR's of code. That isn't their job. Their job is to ensure that the forum operates correctly given changes as well as test bug fixes. The dev's work with the code author to get the code in to the core.developer11 wrote:they should make PRs being accepted automatically. If PR is crap than QA team steps in and (in cooperation with code author) corrects the code within PR. Thats what QA team is for.....RMcGirr83 wrote:No they shouldn't. If the code being merged is crap then the PR is crap and will affect the quality of the phpBB software. All my mods/extensions are GPL. Using your flawed logic I should accept every PR no matter the quality of the PR. Are you then suggesting that I provide support for the crappy code that was merged or should the original author? Here's a hint, the original author of the crappy code will, more than likely, become a lost soul on the internet which then leaves the mod/extension writer to provide support.Team should make automatic acceptance of PRs.
This whole debate has gone on long enough and this topic is not about what you believe the jobs of the different teams are. I have proven you wrong time and time again and to be honest it is tiring. The adage "You can lead a horse to water but you can't make him drink" seems to be very apropos here.
I find it interesting that you think you know an awful lot about how the phpBB code authoring system works and you gleaned this information from your all of 21 days on this forum.
I am reminded of this saying
"It is better to remain silent and be thought a fool, than to speak out and remove all doubt."
/me shakes headQA stands for quality assurance and as such their primary responsibility is to assure code remains highh quality......
Testing the code is responsibility of developers team.
The developers are the ones to assure code remains high quality, the QA team ensures that the code does what it is supposed to do without mucking up the works.a program for the systematic monitoring and evaluation of the various aspects of a project, service, or facility to ensure that standards of quality are being met