Does "that" refer to the ticket or the quoted code? I still don't know why it was a fix, because nowhere is explained why the oldnickvergessen wrote:No, that's from the security fix.
generate_board_url()
would be bad in that case.From the ACP. It was linked in the admin control panel as the release topic for 3.1.4.nickvergessen wrote:Where did you get this link from?Dragosvr92 wrote:I see 3.1.4 was released, but the topic linked into the acp says "the requested topic doesnt exist"
https://area51.phpbb.com/phpBB/viewtopi ... &t=2313941
Imo, It should be properly linked on the area51 though as thats where the RC versions were announced, and thats where it should be announced how to upgrade from the latest provided RC to the stable release.nickvergessen wrote: RC update packages need to be downloaded from the package archive, since they were not ment for live usage: https://download.phpbb.com/pub/release/3.1/3.1.4/
You should start a support topic. This is for discussion of the release, not support questions about it.cpapaioannou wrote:I am running in to file check issues (now, I have customized some of the files) and am not sure of the process to take to keep my custom modifications (can't recall exactly what was changed or how)
that refers to the quoted code.AmigoJack wrote:Does "that" refer to the ticket or the quoted code? I still don't know why it was a fix, because nowhere is explained why the oldgenerate_board_url()
would be bad in that case.
Right, I fixed it, now we just need someone to git pull:Dragosvr92 wrote:From the ACP. It was linked in the admin control panel as the release topic for 3.1.4.
I checked a localhost forum and i see it is now changed to the real announcement topic.
viewtopic.php?f=14&t=2313941
The topic id is the same, but someone must have mistaken the board...
Do you think the RC announcement topic is enough for that? If so I can easily do that in the future.Dragosvr92 wrote:Imo, It should be properly linked on the area51 though as thats where the RC versions were announced, and thats where it should be announced how to upgrade from the latest provided RC to the stable release.nickvergessen wrote: RC update packages need to be downloaded from the package archive, since they were not ment for live usage: https://download.phpbb.com/pub/release/3.1/3.1.4/
I do, all RC packages were provided there, so the last stable update package should also be provided there. Not everyone knows about the FTP index page that holds all the packages, or that they have to bookmark it somewhere, when they need to search for the package... After they search through many bookmarks to find the url... An anncouncement would be great in the future, please. Thank you !nickvergessen wrote: Do you think the RC announcement topic is enough for that? If so I can easily do that in the future.
One announcement is enough (the one this topic references). Those that installed an RC should just visit Area 51 or know where to download the updates since RCs are not meant for the general population and we rightfully expect those that installed an RC to know where to look. But perhaps some clarity on this can be made in future RC topics on Area 51.Dragosvr92 wrote:An anncouncement would be great in the future, please.
Thank you for that. Is there a rigorous way through git or somehow to determine it?kinerity wrote:Unofficial:
http://www.acsyste.com/docs/phpBB/phpBB ... hanges.xml
The official diff https://gist.github.com/nickvergessen/b ... 978d3a13c3 is generated with the git command from https://area51.phpbb.com/phpBB/viewtopi ... 81&t=47301aleha wrote:Thank you for that. Is there a rigorous way through git or somehow to determine it?
Maybe we should put this command in wiki or in the docs?
Code: Select all
git diff release-3.1.3 release-3.1.4-RC1 phpBB/language/ > language_changes_3.1.3_to_3.1.4-RC1.diff