[Discuss] Extension Skeleton Development Tool

Do not post support requests, bug reports or feature requests. Discuss phpBB here. Non-phpBB related discussion goes in General Discussion!
Ideas Centre
User avatar
DavidIQ
Customisations Team Leader
Customisations Team Leader
Posts: 17256
Joined: Thu Jan 06, 2005 1:30 pm
Location: Fishkill, NY
Name: David Colón
Contact:

Re: [Discuss] Extension Skeleton Development Tool

Post by DavidIQ »

RMcGirr83 wrote:PS is that ext.php file I made going to be merged?
We just took ownership so give it some time. :P
Apply to become a Jr. Extension Validator
My extensions | In need of phpBB services? | Was I helpful today?
No unsolicited PMs unless you're planning on asking for paid help.
User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21172
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: [Discuss] Extension Skeleton Development Tool

Post by RMcGirr83 »

No, I'm impatient. :P
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions | My extensions are updated regularly on github
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored
User avatar
david63
Registered User
Posts: 17983
Joined: Thu Dec 19, 2002 8:08 am
Location: Lancashire, UK
Contact:

Re: [Discuss] Extension Skeleton Development Tool

Post by david63 »

3Di wrote:Do you have debug enabled?
Sure do - but there were no errors
David
Remember: You only know what you know and - you don't know what you don't know!
My CDB Contributions | How to install an extension
I will not be accepting translations for any of my extensions in Github - please post any translations in the appropriate topic.
No support requests via PM or email as they will be ignored
User avatar
3Di
Former Team Member
Posts: 15720
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [Discuss] Extension Skeleton Development Tool

Post by 3Di »

DavidIQ wrote:
david63 wrote:It means that there was a topic a few days ago where VSE said that extensions should not be downloaded directly from a git repro but from a release!
VSE wrote:Poke
For reference: viewtopic.php?p=14387501#p14387501
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
:studio_microphone: Looking for a specific feature or alternative option?
User avatar
3Di
Former Team Member
Posts: 15720
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [Discuss] Extension Skeleton Development Tool

Post by 3Di »

david63 wrote:
3Di wrote:Do you have debug enabled?
Sure do - but there were no errors
Strange, anyway before to file that issue I deeply checked the code (3.1.x) and found what I wrote there. Instead in 3.2.x that class does exists, sort of discrepance?!?
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
:studio_microphone: Looking for a specific feature or alternative option?
User avatar
HiFiKabin
Community Team Member
Community Team Member
Posts: 4717
Joined: Wed May 14, 2014 9:10 am
Location: Swearing at the PC, UK
Name: James
Contact:

Re: [Discuss] Extension Skeleton Development Tool

Post by HiFiKabin »

I thought it was just me, but I am not getting anything other than errors.

Fill in the fields, hit submit and ...
screenshot_1383.jpg
User avatar
3Di
Former Team Member
Posts: 15720
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [Discuss] Extension Skeleton Development Tool

Post by 3Di »

HiFiKabin wrote:I thought it was just me, but I am not getting anything other than errors.

Fill in the fields, hit submit and ...
screenshot_1383.jpg
https://github.com/phpbb-extensions/php ... /issues/10
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
:studio_microphone: Looking for a specific feature or alternative option?
User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21172
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: [Discuss] Extension Skeleton Development Tool

Post by RMcGirr83 »

3Di wrote:
david63 wrote:
3Di wrote:Do you have debug enabled?
Sure do - but there were no errors
Strange, anyway before to file that issue I deeply checked the code (3.1.x) and found what I wrote there. Instead in 3.2.x that class does exists, sort of discrepance?!?
Seems we have an issue with this development tool. It is partly coded for 3.1.x and partly coded for 3.2.x. David63 didn't have any errors (other than the twig thingy) because he was installing on 3.2, 3Di had errors because he was installing on 3.1 and, as had been stated, 3.1 doesn't have symfony finder class whereas 3.2 does.

I guess no one actually tests things these days prior to implementing them with PRs. A bit sloppy if you ask me.
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions | My extensions are updated regularly on github
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored
User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21172
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: [Discuss] Extension Skeleton Development Tool

Post by RMcGirr83 »

One last note on this I don't think this is a very good idea.

Code: Select all

			'require-dev' => array(
				'phpbb/epv' => 'dev-master',
if an extension writer is using dependencies, then when compiled by composer it will include extraneous stuff within the extension writers vendor folder...like symphony.

Issue opened I suppose.
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions | My extensions are updated regularly on github
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored
Paul
Infrastructure Team Leader
Infrastructure Team Leader
Posts: 26285
Joined: Sat Dec 04, 2004 3:44 pm
Location: The netherlands.
Name: Paul Sohier
Contact:

Re: [Discuss] Extension Skeleton Development Tool

Post by Paul »

it should include EPV, it is best practise to use travis and test with EPV to prevent insta-deny.
Knock knock
Race condition
Who's there?

My BlogMy Photosmy phpBB Extensionscustom phpBB work & Development
User avatar
MattF
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 5164
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman
Contact:

Re: [Discuss] Extension Skeleton Development Tool

Post by MattF »

RMcGirr83 wrote:I was led to believe, by Paul and/or VSE, that if there are releases they should be packaged and made available. That way users don't have to download the zip, unzip, rename the directory (in this case phpbb-ext-skeleton-3.1.x), upload to the forum, etc.
You do not have to take that as gospel.

However, it's a best practice to tag your "releases" and even nicer to make releases on Github where users can download a pre-packaged build, instead of the raw source code, where they have to build the packaging structure themselves.

Even more so if you actually have dependencies from composer packages.

As for EPV, I no longer consider it correct to make it a dependency of your extension. Because, frankly, your extension does not need it. Instead of adding EPV to your composer, and running composer install in your travis file, I instead call this new travis script, See these changes, for example. This makes EPV part of phpBB dynamically during the testing process.
Formerly known as VSEMy ExtensionsPlease do not PM me for support.
User avatar
MattF
Extensions Development Coordinator
Extensions Development Coordinator
Posts: 5164
Joined: Sat Jan 17, 2009 9:37 am
Location: Los Angeles, CA
Name: Matt Friedman
Contact:

Re: [Discuss] Extension Skeleton Development Tool

Post by MattF »

Anyway, yes there should be releases and phpBB 3.2 compatibility soon for the Extension skeleton. It's still in "dev" which is why there were no releases yet.
Formerly known as VSEMy ExtensionsPlease do not PM me for support.
User avatar
RMcGirr83
Recognised Extension Developer
Posts: 21172
Joined: Wed Jun 22, 2005 4:33 pm
Location: Your display
Name: Rich McGirr

Re: [Discuss] Extension Skeleton Development Tool

Post by RMcGirr83 »

@Paul I disagree. EPV is already run when submitting to the CDB plus I have run into issues with false positives using EPV and travis in the past (can't find it now naturally).

Don't see why it can't be a user choice just as Questions are asked concerning PHP listeners and even for Travis itself.

Code: Select all

    'SKELETON_QUESTION_COMPONENT_TRAVIS'            => 'Should we add a sample for test execution on Travis CI',
    'SKELETON_QUESTION_COMPONENT_TRAVIS_UI'            => 'Test execution on Travis CI',
    'SKELETON_QUESTION_COMPONENT_TRAVIS_EXPLAIN'    => 'default: y; [y/n]',
Only things that should be "required" would be the license and the type. If an extension writer wants to include EPV when testing on travis that would require a check on the yes box. Are you going to allow extension writers, if using dependencies, to include the EPV stuff within their extension when submitted to the CDB after they compiled it using composer? I highly doubt it.

To sum it shouldn't be "required" IMHO.
In times of change, learners inherit the earth, while the learned find themselves beautifully equipped to deal with a world that no longer exists - Eric Hoffer
Former Modifications/Extensions Team Member | My extensions | My extensions are updated regularly on github
Appreciate the extensions/mods/support then buy me a beer
All requests for support via PM will be ignored
User avatar
3Di
Former Team Member
Posts: 15720
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: [Discuss] Extension Skeleton Development Tool

Post by 3Di »

EPV can be also just locally run, btw.
Ie.: on windows I can.

The most interesting stuff to me - atm - is to have it running at least for 3.1.x.
The issue I filed (#10) explains it all.
There is no way to test and provide feedback or PRs if it doesn't works.
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
:studio_microphone: Looking for a specific feature or alternative option?
Post Reply

Return to “phpBB Discussion”