Page 1 of 4

[Discuss] Extension Skeleton Development Tool

Posted: Tue Mar 29, 2016 5:07 pm
by DavidIQ
Please use this topic to discuss the blog post Extension Skeleton Development Tool

Re: [Discuss] Extension Skeleton Development Tool

Posted: Tue Mar 29, 2016 7:22 pm
by 3Di
I was bound to ask VSE about why not to better expose this useful extension.
Like to put it into the extensions in development forum.

I forked it a while ago, found on github while navigating. Though I have serious probs to make it working, I reported into the issues tracker and I hope to get some answers. It is a very interesting tool for developpers, thank you. :)

Re: [Discuss] Extension Skeleton Development Tool

Posted: Wed Mar 30, 2016 1:24 pm
by david63
Just had a quick look at this and it came back with an error
Catchable Fatal Error: Argument 3 passed to phpbb\template\twig\twig::__construct() must be an instance of phpbb\template\context, instance of phpbb\user given, called in C:\htdocs\phpbb_dev\ext\phpbb\skeleton\helper\packager.php on line 116 and defined

Re: [Discuss] Extension Skeleton Development Tool

Posted: Wed Mar 30, 2016 1:34 pm
by RMcGirr83
david63 wrote:Just had a quick look at this and it came back with an error
Catchable Fatal Error: Argument 3 passed to phpbb\template\twig\twig::__construct() must be an instance of phpbb\template\context, instance of phpbb\user given, called in C:\htdocs\phpbb_dev\ext\phpbb\skeleton\helper\packager.php on line 116 and defined
That's because you are trying to use this on 3.2 and it was designed for 3.1.

Re: [Discuss] Extension Skeleton Development Tool

Posted: Wed Mar 30, 2016 1:41 pm
by DavidIQ
Please report that to the GitHub repo as we'll need to make it 3.2 ready as well. Thanks.

Re: [Discuss] Extension Skeleton Development Tool

Posted: Wed Mar 30, 2016 1:45 pm
by RMcGirr83
I've made a PR against the 3.1 branch (added ext.php to disallow installing it on boards > 3.2.0@dev).

Re: [Discuss] Extension Skeleton Development Tool

Posted: Wed Mar 30, 2016 1:59 pm
by 3Di
1 month ago I issued this one:
https://github.com/nickv-phpbb/phpbb-ex ... /issues/10
Using 3.1.

Re: [Discuss] Extension Skeleton Development Tool

Posted: Wed Mar 30, 2016 2:04 pm
by 3Di
RMcGirr83 wrote: > 3.2.0@dev).
Should it be >= 3.2.0@dev ?

Edit: I saw your PR, < is the way to go.

Re: [Discuss] Extension Skeleton Development Tool

Posted: Wed Mar 30, 2016 2:19 pm
by RMcGirr83
DavidIQ wrote:Please report that to the GitHub repo as we'll need to make it 3.2 ready as well. Thanks.
There should be releases?

Re: [Discuss] Extension Skeleton Development Tool

Posted: Wed Mar 30, 2016 2:26 pm
by david63
Sorry did not realise it did not work on 3.2

So I went to my 3.1 board - ran it again and all it created were three files
  • composer.json
  • license.txt
  • README.md

Re: [Discuss] Extension Skeleton Development Tool

Posted: Wed Mar 30, 2016 2:29 pm
by DavidIQ
RMcGirr83 wrote:There should be releases?
I'm not sure what that means.

FYI for everyone: the repository ownership has been changed and moved to:
https://github.com/phpbb-extensions/phpbb-ext-skeleton

The blog post has been updated to reflect this change.

Re: [Discuss] Extension Skeleton Development Tool

Posted: Wed Mar 30, 2016 2:34 pm
by david63
DavidIQ wrote:
RMcGirr83 wrote:There should be releases?
I'm not sure what that means.
It means that there was a topic a few days ago where VSE said that extensions should not be downloaded directly from a git repro but from a release!

Re: [Discuss] Extension Skeleton Development Tool

Posted: Wed Mar 30, 2016 2:38 pm
by DavidIQ
david63 wrote:It means that there was a topic a few days ago where VSE said that extensions should not be downloaded directly from a git repro but from a release!
VSE wrote:Poke

Re: [Discuss] Extension Skeleton Development Tool

Posted: Wed Mar 30, 2016 2:40 pm
by RMcGirr83
DavidIQ wrote:
RMcGirr83 wrote:There should be releases?
I'm not sure what that means.
https://github.com/phpbb-extensions/php ... n/releases

I was led to believe, by Paul and/or VSE, that if there are releases they should be packaged and made available. That way users don't have to download the zip, unzip, rename the directory (in this case phpbb-ext-skeleton-3.1.x), upload to the forum, etc.

for example, https://github.com/RMcGirr83/phpBB-3.1- ... /tag/1.2.0

PS is that ext.php file I made going to be merged?

Re: [Discuss] Extension Skeleton Development Tool

Posted: Wed Mar 30, 2016 2:41 pm
by 3Di
david63 wrote:Sorry did not realise it did not work on 3.2

So I went to my 3.1 board - ran it again and all it created were three files
  • composer.json
  • license.txt
  • README.md
Yes, same here.

Because of this I think
https://github.com/phpbb-extensions/php ... /issues/10

Do you have debug enabled?