phpBB 3.2.1 : why hiding online registered users list?

Do not post support requests, bug reports or feature requests. Discuss phpBB here. Non-phpBB related discussion goes in General Discussion!
Ideas Centre
Post Reply
User avatar
Big Monstro
Registered User
Posts: 27
Joined: Tue Nov 15, 2016 5:42 pm

phpBB 3.2.1 : why hiding online registered users list?

Post by Big Monstro » Sun Jul 09, 2017 5:35 pm

Hello.

I've tested the new phpBB 3.2.1 (currently in RC1 status). I've noticed a disturbing difference between prosilver for phpBB 3.2.1 and earlier versions.

In phpBB 3.2.0 and older, when you browse a board as a guest, you can view the online registered users list at the footer (index_body, viewforum_body and viewtopic_body). But now, that list is hidden except if you enable the viewing profiles for guest users (same permission for profiles, memberlist and online list).

For example, index_body.html (similar changes have been made in viewforum_body and viewtopic_body)

phpBB 3.2.0

Code: Select all

{TOTAL_USERS_ONLINE} ({L_ONLINE_EXPLAIN})<br />{RECORD_USERS}<br /> <br />{LOGGED_IN_USER_LIST}
<!-- IF LEGEND --><br /><em>{L_LEGEND}{L_COLON} {LEGEND}</em><!-- ENDIF -->
phpBB 3.2.1-RC1

Code: Select all

{TOTAL_USERS_ONLINE} ({L_ONLINE_EXPLAIN})<br />{RECORD_USERS}<br /> 
<!-- IF U_VIEWONLINE -->
	<br />{LOGGED_IN_USER_LIST}
	<!-- IF LEGEND --><br /><em>{L_LEGEND}{L_COLON} {LEGEND}</em><!-- ENDIF -->
<!-- ENDIF -->
Why that change, considering it's not possible to enable online list for guests without enabling the memberlist and profiles? As a board administrator, I could decide to prevent viewing profiles and memberlist but still display the currently online users at the bottom.

What about birthday block in index_body.html? It's totally useless for guests if they cannot view profiles (always "No birthdays today" message is displayed).

Thank you for your answers!

User avatar
JimA
Community Team Leader
Community Team Leader
Posts: 7078
Joined: Thu Jul 31, 2008 5:54 am
Location: The Netherlands
Name: Jim Mossing Holsteyn
Contact:

Re: phpBB 3.2.1 : why hiding online registered users list?

Post by JimA » Sun Jul 09, 2017 6:02 pm

You can read some of the discussion behind why these changes were made in the tracker ticket and the discussion about the implementation in the Pull Request.

Basically, the consensus was that the permission now respects the wording of the permission correctly, as setting it to "No" now actually means that you can't view the Who is Online list. This as opposed to the earlier behaviour where you only couldn't view the Who is Online page but could still see the list on the index. Part of the discussion on implementation was also (as you can read) that using a simple template switch makes it easier for board admins (like you) to reverse the change if they dislike the new behaviour.
Image Jim Mossing Holsteyn - Community Team Leader
Knowledge Base | Documentation | Board rules

If you're having any questions about the rules/customs of this website, feel free to drop me a PM.

User avatar
3Di
Registered User
Posts: 11872
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milano - Frankfurt
Name: Marco
Contact:

Re: phpBB 3.2.1 : why hiding online registered users list?

Post by 3Di » Sun Jul 09, 2017 6:22 pm

Enough already discussed there, I wasn't aware of this merge. I have to say I disagree.
Looks to me like "hackish", but that's just me. :)
Want to compensate me for my interest? Donate
Please PM me only to request paid works. Thx.
Extensions, Scripts, MOD porting, Update/Upgrades

User avatar
Big Monstro
Registered User
Posts: 27
Joined: Tue Nov 15, 2016 5:42 pm

Re: phpBB 3.2.1 : why hiding online registered users list?

Post by Big Monstro » Sun Jul 09, 2017 6:54 pm

JimA wrote:
Sun Jul 09, 2017 6:02 pm
Basically, the consensus was that the permission now respects the wording of the permission correctly, as setting it to "No" now actually means that you can't view the Who is Online list. This as opposed to the earlier behaviour where you only couldn't view the Who is Online page but could still see the list on the index. Part of the discussion on implementation was also (as you can read) that using a simple template switch makes it easier for board admins (like you) to reverse the change if they dislike the new behaviour.
Thank you for your explanations!

Another question :

what's about birthday block? The mentioned tracker ticket PHPBB3-14498 talks about that too. If guests are not allowed to view profiles, the birthday block always displays the message "No birthdays today", regardless the actual members' data : if today is the birthday of one of my board member, I can see that when I log on, but not when I log off (unless I enable viewing profiles for guests). So, it's totally useless for guests and the birthday block should be entirely hidden if they cannot view profiles. It's a suggestion for the final release of phpBB 3.2.1 (or phpBB 3.2.1-RC2) ;)

User avatar
JimA
Community Team Leader
Community Team Leader
Posts: 7078
Joined: Thu Jul 31, 2008 5:54 am
Location: The Netherlands
Name: Jim Mossing Holsteyn
Contact:

Re: phpBB 3.2.1 : why hiding online registered users list?

Post by JimA » Mon Jul 10, 2017 9:32 am

Big Monstro wrote:
Sun Jul 09, 2017 6:54 pm
So, it's totally useless for guests and the birthday block should be entirely hidden if they cannot view profiles. It's a suggestion for the final release of phpBB 3.2.1 (or phpBB 3.2.1-RC2) ;)
If you feel you've found a bug introduced by this change, then please report it to the Bug Tracker. The Developers will review the report and (depending on the urgency and validity) might be able to fix it even before the final release of phpBB 3.2.1.

When you know how to solve this yourself, feel free to send your own pull request with a fix. :)
Image Jim Mossing Holsteyn - Community Team Leader
Knowledge Base | Documentation | Board rules

If you're having any questions about the rules/customs of this website, feel free to drop me a PM.

GoesOn
Registered User
Posts: 413
Joined: Sun Mar 05, 2017 7:31 pm

Re: phpBB 3.2.1 : why hiding online registered users list?

Post by GoesOn » Wed Jul 12, 2017 6:49 pm

Are there hidden or not online members?
English is not my native language :!:

User avatar
dontcoz
Registered User
Posts: 442
Joined: Mon Sep 29, 2008 9:49 pm
Location: Vancouver, BC
Contact:

Re: phpBB 3.2.1 : why hiding online registered users list?

Post by dontcoz » Sat Dec 02, 2017 10:32 pm

Big Monstro wrote:
Sun Jul 09, 2017 5:35 pm
Hello.

I've tested the new phpBB 3.2.1 (currently in RC1 status). I've noticed a disturbing difference between prosilver for phpBB 3.2.1 and earlier versions.

In phpBB 3.2.0 and older, when you browse a board as a guest, you can view the online registered users list at the footer (index_body, viewforum_body and viewtopic_body). But now, that list is hidden except if you enable the viewing profiles for guest users (same permission for profiles, memberlist and online list).

For example, index_body.html (similar changes have been made in viewforum_body and viewtopic_body)

phpBB 3.2.0

Code: Select all

{TOTAL_USERS_ONLINE} ({L_ONLINE_EXPLAIN})<br />{RECORD_USERS}<br /> <br />{LOGGED_IN_USER_LIST}
<!-- IF LEGEND --><br /><em>{L_LEGEND}{L_COLON} {LEGEND}</em><!-- ENDIF -->
phpBB 3.2.1-RC1

Code: Select all

{TOTAL_USERS_ONLINE} ({L_ONLINE_EXPLAIN})<br />{RECORD_USERS}<br /> 
<!-- IF U_VIEWONLINE -->
	<br />{LOGGED_IN_USER_LIST}
	<!-- IF LEGEND --><br /><em>{L_LEGEND}{L_COLON} {LEGEND}</em><!-- ENDIF -->
<!-- ENDIF -->
Why that change, considering it's not possible to enable online list for guests without enabling the memberlist and profiles? As a board administrator, I could decide to prevent viewing profiles and memberlist but still display the currently online users at the bottom.

What about birthday block in index_body.html? It's totally useless for guests if they cannot view profiles (always "No birthdays today" message is displayed).

Thank you for your answers!
thank you. i though it was something i changed in permissions, until i found your post. i went back to the old setting.

nothing kills the buzz like giving something to the people, then taking it away.

User avatar
Elias
Registered User
Posts: 4608
Joined: Sat Feb 25, 2006 4:31 pm
Location: In the Water!
Name: Elias
Contact:

Re: phpBB 3.2.1 : why hiding online registered users list?

Post by Elias » Sun Dec 03, 2017 12:30 am

GoesOn wrote:
Wed Jul 12, 2017 6:49 pm
Are there hidden or not online members?
Not online since he’s referring to guests.
"Mystery creates wonder, and wonder is the basis of man's desire to understand." - Neil Armstrong
|Installing Extensions|Writing Extensions|Extension Validation Policy|

Post Reply

Return to “phpBB Discussion”

Who is online

Users browsing this forum: 3Di, JohnnyBigSpuds and 22 guests

cron