Clever quote testing

Do not post support requests, bug reports or feature requests. Discuss phpBB here. Non-phpBB related discussion goes in General Discussion!
Scam Warning
User avatar
P_I
Registered User
Posts: 838
Joined: Tue Mar 01, 2011 8:35 pm
Location: Calgary
Contact:

Clever quote testing

Post by P_I » Sun Dec 10, 2017 1:03 pm

This post really isn't quotable, but I'm testing something here.

User avatar
P_I
Registered User
Posts: 838
Joined: Tue Mar 01, 2011 8:35 pm
Location: Calgary
Contact:

Re: Clever quote testing

Post by P_I » Sun Dec 10, 2017 1:03 pm

P_I wrote:
Sun Dec 10, 2017 1:03 pm
This post really isn't quotable, but I'm testing something here.
That really wasn't a clever quote, but then again I'm just testing.

User avatar
P_I
Registered User
Posts: 838
Joined: Tue Mar 01, 2011 8:35 pm
Location: Calgary
Contact:

Re: Clever quote testing

Post by P_I » Sun Dec 10, 2017 1:05 pm

P_I wrote:
Sun Dec 10, 2017 1:03 pm
P_I wrote:
Sun Dec 10, 2017 1:03 pm
This post really isn't quotable, but I'm testing something here.
That really wasn't a clever quote, but then again I'm just testing.
Anyone notice something strange about the user profile link that's part of the clever quote?

User avatar
HiFiKabin
Community Team Member
Community Team Member
Posts: 2694
Joined: Wed May 14, 2014 9:10 am
Location: Swearing at the PC, UK
Name: James
Contact:

Re: Clever quote testing

Post by HiFiKabin » Sun Dec 10, 2017 1:50 pm

P_I wrote:
Sun Dec 10, 2017 1:05 pm
P_I wrote:
Sun Dec 10, 2017 1:03 pm
P_I wrote:
Sun Dec 10, 2017 1:03 pm
This post really isn't quotable, but I'm testing something here.
That really wasn't a clever quote, but then again I'm just testing.
Anyone notice something strange about the user profile link that's part of the clever quote?
How did you do that?

User avatar
HiFiKabin
Community Team Member
Community Team Member
Posts: 2694
Joined: Wed May 14, 2014 9:10 am
Location: Swearing at the PC, UK
Name: James
Contact:

Re: Clever quote testing

Post by HiFiKabin » Sun Dec 10, 2017 1:53 pm

HiFiKabin wrote:
Sun Dec 10, 2017 1:50 pm
P_I wrote:
Sun Dec 10, 2017 1:05 pm
P_I wrote:
Sun Dec 10, 2017 1:03 pm
P_I wrote:
Sun Dec 10, 2017 1:03 pm
This post really isn't quotable, but I'm testing something here.
That really wasn't a clever quote, but then again I'm just testing.
Anyone notice something strange about the user profile link that's part of the clever quote?
How did you do that?
Ahhhh, thats how you do it.

Spooky

User avatar
P_I
Registered User
Posts: 838
Joined: Tue Mar 01, 2011 8:35 pm
Location: Calgary
Contact:

Re: Clever quote testing

Post by P_I » Sun Dec 10, 2017 1:58 pm

HiFiKabin wrote:
Sun Dec 10, 2017 1:53 pm
Spooky
I agree.

I am actually trying to demonstrate [PHPBB3-15477] Clever quote feature should display current username in case where username was changed. Since I don't have ACP access on this board, I manually manipulated some data to show what could happen.

User avatar
HiFiKabin
Community Team Member
Community Team Member
Posts: 2694
Joined: Wed May 14, 2014 9:10 am
Location: Swearing at the PC, UK
Name: James
Contact:

Re: Clever quote testing

Post by HiFiKabin » Sun Dec 10, 2017 2:08 pm

so when you submit a post with a quote, the 'byline' is posted as is with no internal checking.

... but why does the poster name not change when obviously the content has? Obviously it is linking to the name of the original quoted poster, but why?

User avatar
P_I
Registered User
Posts: 838
Joined: Tue Mar 01, 2011 8:35 pm
Location: Calgary
Contact:

Re: Clever quote testing

Post by P_I » Sun Dec 10, 2017 2:43 pm

HiFiKabin wrote:
Sun Dec 10, 2017 2:08 pm
so when you submit a post with a quote, the 'byline' is posted as is with no internal checking.
There is really no need for internal checking at this point, other than to detect and prevent what you and I have done.

From my perspective the real problem is Quoted replies have always suffered from a problem that they don't contemplate a future username change. They capture the quoted poster's username when the post is submitted.

I'm not sure if this is the right place to discuss the issue, if not, could a moderator please move this topic into the appropriate place.

This is really a boundary test case for the clever quote feature that was introduced in phpBB 3.2. The bug is minor and not likely to happen often. But as we've demonstrated, it can happen and the end result is "spooky" or misleading or confusing, take your pick. Hence the reason to report it in the tracker.

Some background, I'm involved in a couple of financial education boards and periodically we get requests from members to change their username for privacy reasons. It is simple to change the username, but how do you handle the instances where the member was quoted in a reply? There is still leakage of their old identity. If the number of quoted posts is small enough, we sometimes resort to phpMyAdmin to manually update the database to reflect the new username.

What changed in phpBB 3.2 with clever quotes is additional information was captured, including the quoted poster's user_id. When the clever quotes feature was introduced I was hopeful that having the quoted poster's user_id would be useful to handle this boundary case when the username got changed. Perhaps phpBB could detect that the quoted username didn't match the username that was referenced via the user_id information when it built the link to the member's profile that is now part of the byline of the quoted post. Unfortunately that's not the case, hence the bug report.

User avatar
HiFiKabin
Community Team Member
Community Team Member
Posts: 2694
Joined: Wed May 14, 2014 9:10 am
Location: Swearing at the PC, UK
Name: James
Contact:

Re: Clever quote testing

Post by HiFiKabin » Sun Dec 10, 2017 4:46 pm

I think it belongs in discussion, so I'll move it there now.

To unconfuse the confused. When you quote a post you get something like P_I was posting
P_I wrote:
Sun Dec 10, 2017 1:05 pm
P_I wrote:
Sun Dec 10, 2017 1:03 pm
P_I wrote:
Sun Dec 10, 2017 1:03 pm
This post really isn't quotable, but I'm testing something here.
That really wasn't a clever quote, but then again I'm just testing.
Anyone notice something strange about the user profile link that's part of the clever quote?
but if you look at the raw code of the above quote, you will see

Code: Select all

[quote=P_I post_id=14882826 time=1512911155 user_id=1314447]
[quote=P_I post_id=14882821 time=1512911028 user_id=1325630]
[quote=P_I post_id=14882816 time=1512910985 user_id=1314447]
This post really isn't quotable, but I'm testing something here.
[/quote]
That really wasn't a clever quote, but then again I'm just testing.
[/quote]
Anyone notice something strange about the user profile link that's part of the clever quote?
[/quote]
index.php
You can see that the user id has been changed on one of the quotes. The quote is still attributed to P_I but clicking the username takes you to another profile. Try it and see.

User avatar
P_I
Registered User
Posts: 838
Joined: Tue Mar 01, 2011 8:35 pm
Location: Calgary
Contact:

Re: Clever quote testing

Post by P_I » Sun Dec 10, 2017 5:12 pm

HiFiKabin wrote:
Sun Dec 10, 2017 4:46 pm
I think it belongs in discussion, so I'll move it there now.
Thanks for the move and also the unconfuse instructions. My bad, I should have explained it.
Normal people… believe that if it ain’t broke, don’t fix it. Engineers believe that if it ain’t broke, it doesn’t have enough features yet. – Scott Adams

User avatar
david63
Jr. Extension Validator
Posts: 13911
Joined: Thu Dec 19, 2002 8:08 am
Location: Lancashire, UK
Name: David Wood
Contact:

Re: Clever quote testing

Post by david63 » Sun Dec 10, 2017 5:31 pm

This is also an issue when you delete a user, whether you leave their posts or not, and may be relevant to the GDPR discussion
David
Remember: You only know what you know and - you don't know what you don't know!
My CDB Contributions | How to install an extension
I will not be accepting translations for any of my extensions in Github - please post any translations in the appropriate topic.
No support requests via PM or email as they will be ignored

User avatar
canonknipser
Registered User
Posts: 1434
Joined: Thu Sep 08, 2011 4:16 am
Location: Germany
Name: Frank Jakobs
Contact:

Re: Clever quote testing

Post by canonknipser » Sun Dec 10, 2017 5:41 pm

In my opinion the current implementation is a kind of overloading and in error.

For a valid backward reference to the quoted post the post-id is enough. All other information (like user_id, username, time of post) can and should be fetched directly from the quoted post.
So, there should be three use-cases for quotes:
  1. [quote][/quote] without any parameters
  2. [quote="name"][/quote] with a single string as parameter, to cite a "non-post" text (like external sources etc.)
  3. [quote p=post_id][/quote] to create a backward reference to a given post, all values like username, timestamp etc. should be fetched on displaying, not posting a post
1. and 2. are the same use-cases which have been in phpBB since at least 3.0
3. should replace the current multi-parameter-implementation of 3.2

Edit: Look at the time ;)
P_I wrote:
Tue Feb 09, 2021 10:49 pm
This post really isn't quotable, but I'm testing something here.
Greetings
Frank
phpbb.de support team member
English is not my native language
New arrival - Extensions and scripts for phpBB
no support via PM or mail

User avatar
3Di
Registered User
Posts: 12381
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: Clever quote testing

Post by 3Di » Sun Dec 10, 2017 6:58 pm

HiFiKabin wrote:
Sun Dec 10, 2017 4:46 pm
You can see that the user id has been changed on one of the quotes. The quote is still attributed to P_I but clicking the takes you to another profile. Try it and see.
Clicking the takes you to the quoted post as it should be but clicking on the username in quote takes you to another profile (JoshyPHP in this case),
Want to compensate me for my interest? Donate
Please PM me only to request paid works. Thx.
Extensions, Scripts, MOD porting, Update/Upgrades
My development's activity º PhpStorm's proud user

User avatar
HiFiKabin
Community Team Member
Community Team Member
Posts: 2694
Joined: Wed May 14, 2014 9:10 am
Location: Swearing at the PC, UK
Name: James
Contact:

Re: Clever quote testing

Post by HiFiKabin » Sun Dec 10, 2017 7:09 pm

3Di wrote:
Sun Dec 10, 2017 6:58 pm
HiFiKabin wrote:
Sun Dec 10, 2017 4:46 pm
You can see that the user id has been changed on one of the quotes. The quote is still attributed to P_I but clicking the takes you to another profile. Try it and see.
Clicking the takes you to the quoted post as it should be but clicking on the username in quote takes you to another profile (JoshyPHP in this case),
Bums, that what I meant to put

User avatar
3Di
Registered User
Posts: 12381
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: Clever quote testing

Post by 3Di » Sun Dec 10, 2017 7:59 pm

As long as the takes you to the quoted post as it should be I don't see where the issue is, you can change whatever you want but the reference speak books in any case, I feel confused tough, still.

Btw the present behaviour has been always this way, as far as I remember.
Also noted in the tracker, now that I am reading the report....
david63 wrote:
Sun Dec 10, 2017 5:31 pm
This is also an issue when you delete a user, whether you leave their posts or not, and may be relevant to the GDPR discussion
Me too I would leave to an extension the duty to eventually do some magic here.
Want to compensate me for my interest? Donate
Please PM me only to request paid works. Thx.
Extensions, Scripts, MOD porting, Update/Upgrades
My development's activity º PhpStorm's proud user

Post Reply

Return to “phpBB Discussion”

Who is online

Users browsing this forum: alex75, Baidu [Spider], koraldon and 49 guests