Raul [ThE KuKa] wrote: ↑
Wed Feb 06, 2019 6:32 pm
As you say... if a user wants to edit the prosilver
style, it's true which can simply copy/paste, change the name style, change, style.cfg
fil, etc. and ready.
But to all this...
I don't understand the ID of style
, what else?
Honestly, I don't see any "utility" to what you say.
OK, I see that my opening post is unclear. It was not really about editing the standard phpBB style, but only allowing updating to start if the standard style delivered with phpBB (currently prosilver), is present in its unmodified state and active and set as default style.
I have seen updates fail when prosilver has style_id = 2 and another style (usually subsilver-like) has style_id=1 (and is default style).
The point is to try and avoid all update failures due to absence or modification of prosilver.
So, when update is attempted, there could be a test on the presence (and active state/default style) of "prosilver" with style_id = 1 and a check of the unmodified set (CRC-check of the files?). If the test fails, then updating would not be possible (with an explanatory message - like with the requirement test) until prosilver is restored, active and set as default style)
Similarly (and I forgot to mention that) the update test could check that extensions are disabled (sometimes this also causes a failed update).
Apologies for lots of repetitions in the above but it's to make sure it's clear that I have no problem with prosilver being copied and edited, but I'm trying to find a way of eliminating those avoidable failed updates.