Page 2 of 4

Re: Discuss: phpBB 3.2.6 Release

Posted: Mon Apr 29, 2019 7:38 pm
by </Solidjeuh>

Re: Discuss: phpBB 3.2.6 Release

Posted: Mon Apr 29, 2019 7:44 pm
by Joyce&Luna
I could have looked there too.
did not think about it.
I just looked here.
viewtopic.php?f=591&t=2428791

Re: Discuss: phpBB 3.2.6 Release

Posted: Mon Apr 29, 2019 9:54 pm
by 3Di
Thanks for the great job Devs. :)
Applied also hotfix https://github.com/phpbb/phpbb/pull/5578

3.2.5 to 3.2.6
325-to-326.png

Re: Discuss: phpBB 3.2.6 Release

Posted: Tue Apr 30, 2019 12:22 am
by M.O.B.
Since it seems the update was botched, should we wait until a re-release gets pushed out? Seems like many template files fail when attempting to login from there. Seems not all files were fixed to have the new code changes...

Re: Discuss: phpBB 3.2.6 Release

Posted: Tue Apr 30, 2019 6:09 am
by Crizzo
There will be never a re-release. If the development team thinks there is a problem, which needs a quick fix and needs a new release, then there will be a new release, like 3.2.7 or a patch-level release, e. g. 3.2.6-pl1.

Re: Discuss: phpBB 3.2.6 Release

Posted: Tue Apr 30, 2019 9:43 am
by Tastenplayer
When customizing the style I noticed that there is a problem with the search header in the private messages.
Everything looks normal at first.
But if I then click in the navigation e.g. on Outbox, this happens with the Searchbox:
PM 3.2.6.png
PM 3.2.6.png (38.7 KiB) Viewed 881 times
The two icons shrink. In my Ahoy style at the bottom of the picture, it looks terrible. As you can see, the style has an additional bar at the bottom. Also in the Prosilver, if you look closely. Styles are all adapted. But I will definitely not submit a style update for 3.2.6 for validation.

Edit: I have only now seen that there is also an error message in the header
[phpBB Debug] PHP Notice: in file [ROOT]/includes/ucp/ucp_pm_viewfolder.php on line 141: Undefined index: pm_message_reported

(Board is a newly created local Quickinstall Style Testboard)

Re: Discuss: phpBB 3.2.6 Release

Posted: Tue Apr 30, 2019 12:22 pm
by Mick
Marc wrote:
Mon Apr 29, 2019 8:58 am
please do not post support requests here but rather use the Support Forum

Re: Discuss: phpBB 3.2.6 Release

Posted: Tue Apr 30, 2019 12:32 pm
by Tastenplayer
This is not a support contribution (If there is already only with the Prosilver such a mistake, it is logical that it can not be correct also in my Styles :lol: ).
I just wanted to point out that something is wrong. It also has nothing to do with my style, because it already looks like that in Prosilver.

open - privat messages - outbox (in the outbox is a pm) https://abload.de/img/3.2.6vanilla-prosilve7ske6.jpg

Re: Discuss: phpBB 3.2.6 Release

Posted: Tue Apr 30, 2019 1:01 pm
by </Solidjeuh>
Hmz, I don't have that error @Tastenplayer. Went to outbox, there is 1 PM. But no error. Also the search looks normal ...

Re: Discuss: phpBB 3.2.6 Release

Posted: Tue Apr 30, 2019 1:03 pm
by kinerity
Tastenplayer wrote:
Tue Apr 30, 2019 12:32 pm
This is not a support contribution (If there is already only with the Prosilver such a mistake, it is logical that it can not be correct also in my Styles :lol: ).
I just wanted to point out that something is wrong. It also has nothing to do with my style, because it already looks like that in Prosilver.

open - privat messages - outbox (in the outbox is a pm) https://abload.de/img/3.2.6vanilla-prosilve7ske6.jpg
That would qualify as a support request. ;)

Re: Discuss: phpBB 3.2.6 Release

Posted: Tue Apr 30, 2019 1:24 pm
by Tastenplayer
</Solidjeuh> wrote:
Tue Apr 30, 2019 1:01 pm
Hmz, I don't have that error @Tastenplayer. Went to outbox, there is 1 PM. But no error. Also the search looks normal ...
That's odd. I have now created 3 local testboards and always the same problem. :D That's the only problem I've had so far.
Local Quickinstall TB - Win 10 in Xampp- PHP version: 7.1.19 - MySQL(i) 10.1.34-MariaDB

Re: Discuss: phpBB 3.2.6 Release

Posted: Tue Apr 30, 2019 1:29 pm
by </Solidjeuh>
Tastenplayer wrote:
Tue Apr 30, 2019 1:24 pm
</Solidjeuh> wrote:
Tue Apr 30, 2019 1:01 pm
Hmz, I don't have that error @Tastenplayer. Went to outbox, there is 1 PM. But no error. Also the search looks normal ...
That's odd. I have now created 3 local testboards and always the same problem. :D That's the only problem I've had so far.
Local Quickinstall TB - Win 10 in Xampp- PHP version: 7.1.19 - MySQL(i) 10.1.34-MariaDB
I see this css change: https://gist.github.com/marc1706/61d449 ... 1-css-diff

But don't think it can cause that error ... Maybe you missed some change in the templates?

Re: Discuss: phpBB 3.2.6 Release

Posted: Tue Apr 30, 2019 2:12 pm
by Tastenplayer
Maybe you missed some change in the templates?
This is unfortunately the same in the new board where only the Prosilver and no Ext. is installed. ;)
The error message is because of the new color in the PN for reported. However, the PN sent is a completely normal.

Code: Select all

[phpBB Debug] PHP Notice: in file [ROOT]/includes/ucp/ucp_pm_viewfolder.php on line 141: Undefined index: pm_message_reported
line 141 if (($var != 'friend' && $var != 'foe' && $row['pm_' . $var])

I'm not updating my styleforum to 3.2.6 anyway.
Edit:A ticket has already been opened for this problem :oops:
https://tracker.phpbb.com/browse/PHPBB3-16037

Re: Discuss: phpBB 3.2.6 Release

Posted: Tue Apr 30, 2019 2:15 pm
by canonknipser
@</Solidjeuh>
What is your php error_reporting-level? Is it including E_NOTICE?
It is not a change in a style, it is a core change: https://area51.phpbb.com/code-changes/3 ... r.php.html
But the array $row does not contain that index (line 127 ff. of ucp_pm_viewfolder.php:

Code: Select all

			foreach ($folder_info['pm_list'] as $message_id)
			{
				$row = &$folder_info['rowset'][$message_id];

				$folder_img = ($row['pm_unread']) ? 'pm_unread' : 'pm_read';
				$folder_alt = ($row['pm_unread']) ? 'NEW_MESSAGES' : 'NO_NEW_MESSAGES';

				// Generate all URIs ...
				$view_message_url = append_sid("{$phpbb_root_path}ucp.$phpEx", "i=$id&amp;mode=view&amp;f=$folder_id&amp;p=$message_id");
				$remove_message_url = append_sid("{$phpbb_root_path}ucp.$phpEx", "i=$id&amp;mode=compose&amp;action=delete&amp;p=$message_id");

Re: Discuss: phpBB 3.2.6 Release

Posted: Tue Apr 30, 2019 4:20 pm
by John connor
Removing the database backup from the ACP was probably a good one. I new used it anyway since I went to my cPanel and downloaded the whole lot there and then pulled out the database and home directory.

If you did it where you downloaded your files via FTP and the database from the ACP, it will take an ungodly amount of time since the inherit slowness of FTP transfer.

Besides, when I get my backup I have a copy in the root directory and an email telling me if a file was bad, etc.