nou nou wrote: Sun May 05, 2019 5:16 pm
As I was about to try 3.2.6 with the adjustments mentioned here:
viewtopic.php?f=556&t=2510296#p15246461 I found another instance of
{S_LOGIN_REDIRECT}
inside
ucp_login_link.html
.
I've added
{S_FORM_TOKEN_LOGIN}
in there to be on the safe side - unsure if that was necessary?
I don't know how to exercise the code path that would actually invoke that form of the login during the association to an external account, but I have to assume it will ultimately need to have the same modifications as the other login forms.
In phpBB 3.2.7 it should be fine for other users even if they don't make the same modification you already performed on
ucp_login_link.html
. Since in phpBB 3.2.7, if
{S_FORM_TOKEN_LOGIN}
doesn't exist in the style template containing a login form, the required fields are sent through the existing
{S_LOGIN_REDIRECT}
variable, which all the phpBB 3.2.5-compatible templates already consumed.
But sometime after phpBB 3.2.7 (maybe phpBB 3.3.0?) the
{S_FORM_TOKEN_LOGIN}
usage will become mandatory again, and hopefully by then all of the templates have had time to consume these phpBB 3.2.6 and phpBB 3.2.7 changes (and the additional one you've identified). So yes, I do expect you ultimately need and should leave that template change in there.
Entered as
https://tracker.phpbb.com/browse/PHPBB3-16046 for evaluation.