Quoting a post vs quoting a PM

Do not post support requests, bug reports or feature requests. Discuss phpBB here. Non-phpBB related discussion goes in General Discussion!
Scam Warning
Post Reply
User avatar
warmweer
Jr. Extension Validator
Posts: 3853
Joined: Fri Jul 04, 2003 6:34 am
Location: Van Allen Bel ... gium

Quoting a post vs quoting a PM

Post by warmweer »

Just noticed something today:

When quoting a post, the quote is headed with [quote=username post_id=xxxxxxx time=yyyyyyy user_id=zzzzzzz]
but when quoting a PM, the quote is headed with [quote=username time=yyyyyyy user_id=zzzzzzz]

There is no identifier for the PM.
Is there any special reason why msg_id was omitted?
We should embrace problems, without which there wouldn't be any solutions.

User avatar
thecoalman
Community Team Member
Community Team Member
Posts: 3489
Joined: Wed Dec 22, 2004 3:52 am
Location: Pennsylvania, U.S.A.
Contact:

Re: Quoting a post vs quoting a PM

Post by thecoalman »

I would image the primary reason is so you are not creating links to something no one has access to. e.g. quote the PM and forward it to someone else or if you copied the quote from PM and posted in public forum.
“Results! Why, man, I have gotten a lot of results! I have found several thousand things that won’t work.”

Attributed - Thomas Edison

User avatar
warmweer
Jr. Extension Validator
Posts: 3853
Joined: Fri Jul 04, 2003 6:34 am
Location: Van Allen Bel ... gium

Re: Quoting a post vs quoting a PM

Post by warmweer »

thecoalman wrote:
Wed Dec 04, 2019 10:54 pm
I would image the primary reason is so you are not creating links to something no one has access to...
Understandable and probably the logical thing (although there's no risk, it just like a forum of which I know the id but don't have the permissions to see or read).
We should embrace problems, without which there wouldn't be any solutions.

User avatar
JoshyPHP
Code Contributor
Posts: 1091
Joined: Mon Jul 11, 2011 12:28 am

Re: Quoting a post vs quoting a PM

Post by JoshyPHP »

I don't remember there being a specific reason, I didn't add that feature because it's probably more work than it's worth. If you want to give it a try, you'd need to edit the BBCode definition to add an attribute to store the PM's id and the PM's URL, edit the template to add the a element, edit the UCP file to add the PM's id when quoting and edit the quote helper to generate the URL when the quote is displayed.

https://github.com/phpbb/phpbb/blob/ad2 ... hp#L90-L91
https://github.com/phpbb/phpbb/blob/ad2 ... ml#L36-L39
https://github.com/phpbb/phpbb/blob/ad2 ... L993-L1001
https://github.com/phpbb/phpbb/blob/ad2 ... hp#L64-L67

If you go forward with it, feel free to tag me in on the tracker or on GitHub and I'll give it a look.
I wrote the thing that does BBCodes in 3.3.

User avatar
3Di
Former Team Member
Posts: 14807
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: Quoting a post vs quoting a PM

Post by 3Di »

You could open a ticket in the tracker otherwise.
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
:studio_microphone: Premium extensions @ The Studio

User avatar
warmweer
Jr. Extension Validator
Posts: 3853
Joined: Fri Jul 04, 2003 6:34 am
Location: Van Allen Bel ... gium

Re: Quoting a post vs quoting a PM

Post by warmweer »

JoshyPHP wrote:
Thu Dec 05, 2019 1:42 am
I don't remember there being a specific reason, I didn't add that feature because it's probably more work than it's worth. If you want to give it a try, you'd need to edit the BBCode definition to add an attribute to store the PM's id and the PM's URL, edit the template to add the a element, edit the UCP file to add the PM's id when quoting and edit the quote helper to generate the URL when the quote is displayed.

https://github.com/phpbb/phpbb/blob/ad2 ... hp#L90-L91
https://github.com/phpbb/phpbb/blob/ad2 ... ml#L36-L39
https://github.com/phpbb/phpbb/blob/ad2 ... L993-L1001
https://github.com/phpbb/phpbb/blob/ad2 ... hp#L64-L67

If you go forward with it, feel free to tag me in on the tracker or on GitHub and I'll give it a look.
Thanks for the info.
I don't need it (what's a need anyway :lol: ) nor really want it but just noticed it yesterday when I replied to a PM with quotes from 2 previous PMs (1 which had sent, and another which I had received). Probably the first time that I actively noticed the absence of a link to the source message(s).

I'll certainly have a look at the github sections, but since I don't see a real need for it (a PM should only be readable by the sender and by the receiver, so a third party really has no business with a link to another PM), any coding I would do would be just for proof of concept, when and if I have lots of time to kill. By then (and at the speed with which I code) phpBB4 will probably have been released already ;)
We should embrace problems, without which there wouldn't be any solutions.

User avatar
3Di
Former Team Member
Posts: 14807
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: Quoting a post vs quoting a PM

Post by 3Di »

warmweer wrote:
Thu Dec 05, 2019 7:35 am
By then (and at the speed with which I code) phpBB4 will probably have been released already
Good perspectives we got here then. :) It was a question of 10 minutes, just I guess I need 2 hours more to understand how to fix that "minimal" glitch, I will resume it sooner or later. Or probably I will poke JoshyPHP. :)

Edit: got it, it was an extra ? :lol:


2019-12-05 09_40_35-(1) 328email - User Control Panel - View messages.png
2019-12-05 09_40_35-(1) 328email - User Control Panel - View messages.png (3.94 KiB) Viewed 664 times
2019-12-05 09_48_33-(1) 328email - User Control Panel - Compose message.png
2019-12-05 09_48_33-(1) 328email - User Control Panel - Compose message.png (3.21 KiB) Viewed 664 times


https://tracker.phpbb.com/browse/PHPBB3-16247
https://github.com/phpbb/phpbb/pull/5768
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
:studio_microphone: Premium extensions @ The Studio

User avatar
warmweer
Jr. Extension Validator
Posts: 3853
Joined: Fri Jul 04, 2003 6:34 am
Location: Van Allen Bel ... gium

Re: Quoting a post vs quoting a PM

Post by warmweer »

That was quick. :o
Just in case: I started this topic out of interest, curious as to why it wasn't included, perhaps side-effects I can't think of, and not as a bug report or feature request, hence : phpBB Discussion.

The feature could be useful in certain cases (seldom I think) but 3Di apparently considers it worth it.
Any specific cases where it would prove useful?
We should embrace problems, without which there wouldn't be any solutions.

User avatar
3Di
Former Team Member
Posts: 14807
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: Quoting a post vs quoting a PM

Post by 3Di »

warmweer wrote:
Thu Dec 05, 2019 10:31 am
Any specific cases where it would prove useful?
Did you even try to get back to a specific PM into a long discussion? Edit: like when it is a partial quote, an excerpt, and you want to re-read the whole message. The identifier can help if someone quoted your PM(s).

Others can't in any case reach it if not permitted.
And well, let me say I proofed my level of attention this morning. :lol: (I hope I did it right)
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
:studio_microphone: Premium extensions @ The Studio

User avatar
warmweer
Jr. Extension Validator
Posts: 3853
Joined: Fri Jul 04, 2003 6:34 am
Location: Van Allen Bel ... gium

Re: Quoting a post vs quoting a PM

Post by warmweer »

3Di wrote:
Thu Dec 05, 2019 10:35 am
Did you even try to get back to a specific PM into a long discussion?
The identifier can help if someone quoted your PM(s).
Yes, and that's what made me notice the (at that moment woeful) absence of the msg_id.
The only drawback I can think of (currently) is that inadvertently the receiver of my PM then also knows who wrote what (which in some cases isn't desirable). Of course it's easy to delete the identifiers (just like in post quotes) so being alert solves that.
We should embrace problems, without which there wouldn't be any solutions.

User avatar
3Di
Former Team Member
Posts: 14807
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: Quoting a post vs quoting a PM

Post by 3Di »

I mean, the identifier (msg_id) helps getting back to the original message.
Those are PMs, protected.
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
:studio_microphone: Premium extensions @ The Studio

User avatar
warmweer
Jr. Extension Validator
Posts: 3853
Joined: Fri Jul 04, 2003 6:34 am
Location: Van Allen Bel ... gium

Re: Quoting a post vs quoting a PM

Post by warmweer »

3Di wrote:
Thu Dec 05, 2019 11:02 am
I mean, the identifier (msg_id) helps getting back to the original message.
Those are PMs, protected.
I know, and I agree it it useful specifically in that case, but if I quote that and send it to another person (who doesn't have access), then that person will know to whom I sent that part of the message or who sent it to me, and when it was sent (not always considerate, so staying alert can prevent unnecessary misunderstandings - as with posts).
We should embrace problems, without which there wouldn't be any solutions.

User avatar
3Di
Former Team Member
Posts: 14807
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: Quoting a post vs quoting a PM

Post by 3Di »

warmweer wrote:
Thu Dec 05, 2019 11:22 am
... then that person will know to whom I sent that part of the message or who sent it to me ...
Do you realise that the username , time and user_id with profile link were already there in PM quotes? :P
I am "just" adding the identifier to get the arrow that leads you to the quoted origin.

Anyway, I am done here. :)
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
:studio_microphone: Premium extensions @ The Studio

User avatar
warmweer
Jr. Extension Validator
Posts: 3853
Joined: Fri Jul 04, 2003 6:34 am
Location: Van Allen Bel ... gium

Re: Quoting a post vs quoting a PM

Post by warmweer »

3Di wrote:
Thu Dec 05, 2019 11:29 am
Do you realise that the username , time and user_id with profile link were already there in PM quotes? :P
I am "just" adding the identifier to get the arrow that leads you to the quoted origin.
True, you are right.
I was being partially-alert in a senseless way :oops:. (had a very short night is the only excuse I can think of :roll: ).
That does away with the only drawback I could think of (up to now).
We should embrace problems, without which there wouldn't be any solutions.

User avatar
3Di
Former Team Member
Posts: 14807
Joined: Mon Apr 04, 2005 11:09 pm
Location: Milan (IT) Frankfurt (DE)
Name: Marco
Contact:

Re: Quoting a post vs quoting a PM

Post by 3Di »

warmweer wrote:
Thu Dec 05, 2019 10:31 am
... but 3Di apparently considers it worth it.
Yes, it was worth it: ✅ Merged :)
Please PM me only to request paid works. Thx.
Want to compensate me for my interest? Donate
My development's activity º PhpStorm's proud user
Extensions, Scripts, MOD porting, Update/Upgrades
:studio_microphone: Premium extensions @ The Studio

Post Reply

Return to “phpBB Discussion”