Page 6 of 6

Re: Discuss: phpBB 3.3.0-RC1 Release

Posted: Fri Jan 03, 2020 11:13 am
by warmweer
24unix wrote:
Thu Jan 02, 2020 3:53 am
I thought a while about it, was glimpsing through the 3.3 code.

If you become PSR compliant and use CamelCase instead of the 80ies snkae_case phpBB might become an interesting softwarestack.
errr?
Naming conventions change overtime (depending on which type of language is used, and renewed insights) but implementing those is a major (correction MAJOR) overhaul, and that is planned for 4.0 but not for 3.3 which isn't a full rewrite.

Re: Discuss: phpBB 3.3.0-RC1 Release

Posted: Fri Jan 03, 2020 11:41 am
by david63
warmweer wrote:
Fri Jan 03, 2020 11:13 am
but implementing those is a major (correction MAJOR) overhaul, and that is planned for 4.0 but not for 3.3 which isn't a full rewrite.
I was not aware that phpBB 4 was to be a full re-write - where have you seen that?

Re: Discuss: phpBB 3.3.0-RC1 Release

Posted: Fri Jan 03, 2020 11:53 am
by warmweer
david63 wrote:
Fri Jan 03, 2020 11:41 am
I was not aware that phpBB 4 was to be a full re-write - where have you seen that?
OK, wrong wording :oops:
Re-thinking, Overhaul, some serious rewriting but not a "full" rewrite.
There is a discussion on Area51 about naming conventions (for functions).

The point I was trying to make is that introducing a different naming convention isn't just a matter of search and replace.

Re: Discuss: phpBB 3.3.0-RC1 Release

Posted: Fri Jan 03, 2020 11:55 am
by 24unix
warmweer wrote:
Fri Jan 03, 2020 11:13 am
24unix wrote:
Thu Jan 02, 2020 3:53 am
I thought a while about it, was glimpsing through the 3.3 code.

If you become PSR compliant and use CamelCase instead of the 80ies snkae_case phpBB might become an interesting softwarestack.
errr?
Naming conventions change overtime (depending on which type of language is used, and renewed insights) but implementing those is a major (correction MAJOR) overhaul, and that is planned for 4.0 but not for 3.3 which isn't a full rewrite.
Is there a way to see how 4.0 will look like?
My Extensions will currently not be compatible to the phpBB styleguide, but maybe that will change in the future?

Re: Discuss: phpBB 3.3.0-RC1 Release

Posted: Fri Jan 03, 2020 11:58 am
by david63
24unix wrote:
Fri Jan 03, 2020 11:55 am
Is there a way to see how 4.0 will look like?
Only by going to Github
24unix wrote:
Fri Jan 03, 2020 11:55 am
My Extensions will currently not be compatible to the phpBB styleguide, but maybe that will change in the future?
I would not hold your breath that it will be in the foreseeable future.
warmweer wrote:
Fri Jan 03, 2020 11:53 am
There is a discussion on Area51 about naming conventions (for functions).
That is for Twig functions.

Re: Discuss: phpBB 3.3.0-RC1 Release

Posted: Fri Jan 03, 2020 11:59 am
by warmweer
24unix wrote:
Fri Jan 03, 2020 11:55 am
Is there a way to see how 4.0 will look like?
Have a look at The Blog
and at Development

Re: Discuss: phpBB 3.3.0-RC1 Release

Posted: Fri Jan 03, 2020 12:42 pm
by Paul
24unix wrote:
Fri Jan 03, 2020 11:55 am
warmweer wrote:
Fri Jan 03, 2020 11:13 am
24unix wrote:
Thu Jan 02, 2020 3:53 am
I thought a while about it, was glimpsing through the 3.3 code.

If you become PSR compliant and use CamelCase instead of the 80ies snkae_case phpBB might become an interesting softwarestack.
errr?
Naming conventions change overtime (depending on which type of language is used, and renewed insights) but implementing those is a major (correction MAJOR) overhaul, and that is planned for 4.0 but not for 3.3 which isn't a full rewrite.
Is there a way to see how 4.0 will look like?
My Extensions will currently not be compatible to the phpBB styleguide, but maybe that will change in the future?
An extension will most likely not be denied for coding style if you use psr.

Re: Discuss: phpBB 3.3.0-RC1 Release

Posted: Fri Jan 03, 2020 12:58 pm
by 24unix
Thx for the links, and yes, they will be PSR compliant.

Re: Discuss: phpBB 3.3.0-RC1 Release

Posted: Sun Jan 05, 2020 6:55 pm
by BFeely
I just deployed phpBB 3.3.0-RC1 to my webserver, and upgraded to php7.4-fpm to run it. I didn't see any problems, but Google suddenly started giving breadcrumbs issues on for instance https://forum.dxgl.info/viewtopic.php?t=57 with the following code highlited:

Code: Select all

<a href="./index.php" itemtype="https://schema.org/Thing" itemscope="" itemprop="item" accesskey="h" data-navbar-reference="index" title="Board index"><i class="icon fa-home fa-fw"></i><span itemprop="name">Board index</span></a>
and

Code: Select all

<a href="./viewforum.php?f=4" itemtype="https://schema.org/Thing" itemscope="" itemprop="item" title="DXGL"><span itemprop="name">DXGL</span></a>
with in a <span class="crumb"> span.

The error it gave is Missing field "id" and so far has been triggered on 2 pages.

Re: Discuss: phpBB 3.3.0-RC1 Release

Posted: Sun Jan 05, 2020 9:43 pm
by david63
@BFeely

Have you reported it in the Bug Tracker?

Re: Discuss: phpBB 3.3.0-RC1 Release

Posted: Sun Apr 19, 2020 12:13 pm
by thepostman
Has anybody done this upgrade and if so did they have issues? I performed the upgrade last night and now I can not access my forum while logged in which means I can't access ACP to set everything back up. When I am logged out I'm able go navigate go all the pages but once I log in I get a 501 error and can no longer navigate any page in the forum. I have reached out to our service provider and am still waiting on response.

Re: Discuss: phpBB 3.3.0-RC1 Release

Posted: Sun Apr 19, 2020 1:04 pm
by P_I
thepostman wrote:
Sun Apr 19, 2020 12:13 pm
Has anybody done this upgrade and if so did they have issues? I performed the upgrade last night and now I can not access my forum while logged in which means I can't access ACP to set everything back up. When I am logged out I'm able go navigate go all the pages but once I log in I get a 501 error and can no longer navigate any page in the forum. I have reached out to our service provider and am still waiting on response.
Am I missing something here because rather than 3.3.0-RC1, shouldn't you have upgraded to the actual phpBB 3.3 Proteus Feature Release Published (3.3.0)?

What version of phpBB where you running before the upgrade? What method did you use? If you were running phpBB 3.2.x, the recommended procedure is Upgrading from 3.2 to 3.3 using the phpBB 3.3 Full Package.

Have you looked through Common problems while upgrading to 3.3.0

Re: Discuss: phpBB 3.3.0-RC1 Release

Posted: Sun Apr 19, 2020 1:09 pm
by thepostman
I apologize. I posted in the wrong area. I installed 3.3.